Skip to contentSkip to conversation

ARM: dts: koelsch: Move cec_clock to root node

PATCH New Simon Horman 3 participants 3 messages Nov 2, 2017 – Nov 3, 2017 Device tree bindings

lore
Share & tools
lore

Simon Horman

author
#0 lore raw

PATCH 1/1 ARM: dts: koelsch: Move cec_clock to root node

cec-clock is a fixed clock generator that is not controlled by i2c5 and thus should not be a child of the i2c5 bus node. Rather, it should be a child of the root node of the DT.

Fixes 02a5ab18d366 ("ARM: dts: koelsch: Add CEC clock for HDMI transmitter")
Reported-by Laurent Pinchart <[email protected]>
Signed-off-by Simon Horman <[email protected]>
---
 arch/arm/boot/dts/r8a7791-koelsch.dts | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
arch/arm/boot/dts/r8a7791-koelsch.dts +6 -6
index e164eda69baf..4126de417922 100644
@@ -278,6 +278,12 @@
 		};
 	};
 
+	cec_clock: cec-clock {
+		compatible = "fixed-clock";
+		#clock-cells = <0>;
+		clock-frequency = <12000000>;
+	};
+
 	hdmi-out {
 		compatible = "hdmi-connector";
 		type = "a";

@@ -640,12 +646,6 @@
 		};
 	};
 
-	cec_clock: cec-clock {
-		compatible = "fixed-clock";
-		#clock-cells = <0>;
-		clock-frequency = <12000000>;
-	};
-
 	hdmi at 39 {
 		compatible = "adi,adv7511w";
 		reg = <0x39>;
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 ARM: dts: koelsch: Move cec_clock to root node

Hi Simon,

Thank you for the patch.

Quoted 8 lines · On Thursday, 2 November 2017 11:18:05 EET Simon Horman wrote:

cec-clock is a fixed clock generator that is not controlled by i2c5 and thus should not be a child of the i2c5 bus node. Rather, it should be a child of the root node of the DT.

Fixes 02a5ab18d366 ("ARM: dts: koelsch: Add CEC clock for HDMI

transmitter") Reported-by: Laurent Pinchart
<[email protected]>

Signed-off-by Simon Horman <[email protected]>
Reviewed-by Laurent Pinchart <[email protected]>
Quoted 35 lines
---
 arch/arm/boot/dts/r8a7791-koelsch.dts | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
(quoted diff) +0 -0

b/arch/arm/boot/dts/r8a7791-koelsch.dts index e164eda69baf..4126de417922 100644

arch/arm/boot/dts/r8a7791-koelsch.dts +6 -6
@@ -278,6 +278,12 @@
 		};
 	};
 
+	cec_clock: cec-clock {
+		compatible = "fixed-clock";
+		#clock-cells = <0>;
+		clock-frequency = <12000000>;
+	};
+
 	hdmi-out {
 		compatible = "hdmi-connector";
 		type = "a";

@@ -640,12 +646,6 @@
 		};
 	};
 
-	cec_clock: cec-clock {
-		compatible = "fixed-clock";
-		#clock-cells = <0>;
-		clock-frequency = <12000000>;
-	};
-
 	hdmi at 39 {
 		compatible = "adi,adv7511w";
 		reg = <0x39>;
Signature · 3 lines
Regards,

Laurent Pinchart
Applied
#2 lore raw

PATCH 1/1 ARM: dts: koelsch: Move cec_clock to root node

Quoted 9 lines · Laurent Pinchart

Hi Simon,

Thank you for the patch.

Quoted 4 lines · On Thursday, 2 November 2017 11:18:05 EET Simon Horman wrote:

cec-clock is a fixed clock generator that is not controlled by i2c5 and thus should not be a child of the i2c5 bus node. Rather, it should be a child of the root node of the DT.

Quoted 6 lines
Quoted 4 lines
Fixes 02a5ab18d366 ("ARM: dts: koelsch: Add CEC clock for HDMI

transmitter") Reported-by: Laurent Pinchart
<[email protected]>

Signed-off-by Simon Horman <[email protected]>
Reviewed-by Laurent Pinchart <[email protected]>

Thanks, applied.