test-cmdline: Disable test cases for --rxfh hash key parsing
Subsystems (2)
PATCH 1/1 test-cmdline: Disable test cases for --rxfh hash key parsing
test-cmdline does not mock the result of send_ioctl() but just treats a call to send_ioctl() as indicating successful parsing. Any parse failure after this point cannot be tested for. Currently, the hash key string passed to --rxfh isn't parsed until after the device's key size is known, so we can't test it tis way.
Signed-off-by Ben Hutchings <[email protected]>
--- test-cmdline.c | 6 ++++++ 1 file changed, 6 insertions(+)
test-cmdline.c +6 -0
@@ -184,8 +184,14 @@ static struct test_case { { 0, "--set-rxfh-indir devname weight 1 2 3 4" }, { 0, "--rxfh devname hkey 48:15:6e:bb:d8:bd:6f:b1:a4:c6:7a:c4:76:1c:29:98:da:e1:ae:6c:2e:12:2f:c0:b9:be:61:3d:00:54:35:9e:09:05:c7:d7:93:72:4a:ee" }, { 0, "-X devname hkey 48:15:6e:bb:d8:bd:6f:b1:a4:c6:7a:c4:76:1c:29:98:da:e1:ae:6c:2e:12:2f:c0:b9:be:61:3d:00:54:35:9e:09:05:c7:d7:93:72:4a:ee" }, +#if 0 + /* XXX These won't fail as expected because we don't parse the + * hash key until after the first send_ioctl(). That needs to + * be changed before we enable them. + */ { 1, "--rxfh devname hkey foo" }, { 1, "-X devname hkey foo" }, +#endif { 0, "--rxfh devname hkey 48:15:6e:bb:d8:bd:6f:b1:a4:c6:7a:c4:76:1c:29:98:da:e1:ae:6c:2e:12:2f:c0:b9:be:61:3d:00:54:35:9e:09:05:c7:d7:93:72:4a:ee weight 1 2 3 4" }, { 0, "-X devname weight 1 2 3 4 hkey 48:15:6e:bb:d8:bd:6f:b1:a4:c6:7a:c4:76:1c:29:98:da:e1:ae:6c:2e:12:2f:c0:b9:be:61:3d:00:54:35:9e:09:05:c7:d7:93:72:4a:ee" }, { 0, "--rxfh devname hkey 48:15:6e:bb:d8:bd:6f:b1:a4:c6:7a:c4:76:1c:29:98:da:e1:ae:6c:2e:12:2f:c0:b9:be:61:3d:00:54:35:9e:09:05:c7:d7:93:72:4a:ee equal 2" },
Signature · 3 lines
Ben Hutchings
We get into the habit of living before acquiring the habit of thinking.
- Albert Camus