Skip to contentSkip to conversation

ARC: ARC_BOARD_ANGEL4 and ARC_BOARD_ML509

PATCH Applied Paul Bolle 2 participants 7 messages Jun 4, 2014 – Sep 25, 2014 Synopsys ARC architecture

lore
Share & tools
lore

Paul Bolle

author
#0 lore raw

Hi Vineet,

Linux-next included commit c00bfd974fb0 ("ARC: [arcfpga] Get rid of legacy BVCI latency unit support") in next-20140604. It removes the Kconfig symbol ARC_HAS_BVCI_LAT_UNIT. And that symbol's entry is the only place were the symbols ARC_BOARD_ANGEL4 and ARC_BOARD_ML509 are currently used. So it follows that the entries for ARC_BOARD_ANGEL4 and ARC_BOARD_ML509 could be removed too.

If that's correct: is the trivial patch to remove the Kconfig entries for ARC_BOARD_ANGEL4 and ARC_BOARD_ML509 queued somewhere?

Paul Bolle

#1 lore raw

Hi Paul,

Quoted 8 lines · Paul Bolle

Hi Vineet,

Linux-next included commit c00bfd974fb0 ("ARC: [arcfpga] Get rid of legacy BVCI latency unit support") in next-20140604. It removes the Kconfig symbol ARC_HAS_BVCI_LAT_UNIT. And that symbol's entry is the only place were the symbols ARC_BOARD_ANGEL4 and ARC_BOARD_ML509 are currently used. So it follows that the entries for ARC_BOARD_ANGEL4 and ARC_BOARD_ML509 could be removed too.

Thx for noticing this.

I'm planning to use these symbols to set up default builtin DT blobs from Kconfig itself (rather than current defconfigs). If that doesn't workout - sure I will remove the symbols.

Thx,
-Vineet

Quoted 8 lines

If that's correct: is the trivial patch to remove the Kconfig entries for ARC_BOARD_ANGEL4 and ARC_BOARD_ML509 queued somewhere?

Paul Bolle

author
#2 lore raw

Hi Vineet,

Quoted 8 lines · Vineet Gupta
Quoted 6 lines · Paul Bolle

Linux-next included commit c00bfd974fb0 ("ARC: [arcfpga] Get rid of legacy BVCI latency unit support") in next-20140604. It removes the Kconfig symbol ARC_HAS_BVCI_LAT_UNIT. And that symbol's entry is the only place were the symbols ARC_BOARD_ANGEL4 and ARC_BOARD_ML509 are currently used. So it follows that the entries for ARC_BOARD_ANGEL4 and ARC_BOARD_ML509 could be removed too.

Quoted 5 lines

Thx for noticing this.

I'm planning to use these symbols to set up default builtin DT blobs from Kconfig itself (rather than current defconfigs). If that doesn't workout - sure I will remove the symbols.

No news here as of v3.17-rc4 and next-20140912. Are you still planning to use these symbols or should I submit the trivial patch to drop them?

Thanks,

Paul Bolle

#3 lore raw
Quoted 10 lines · Paul Bolle

Hi Vineet,

Quoted 7 lines · Vineet Gupta
Quoted 6 lines · Paul Bolle

Linux-next included commit c00bfd974fb0 ("ARC: [arcfpga] Get rid of legacy BVCI latency unit support") in next-20140604. It removes the Kconfig symbol ARC_HAS_BVCI_LAT_UNIT. And that symbol's entry is the only place were the symbols ARC_BOARD_ANGEL4 and ARC_BOARD_ML509 are currently used. So it follows that the entries for ARC_BOARD_ANGEL4 and ARC_BOARD_ML509 could be removed too.

Quoted 7 lines
Quoted 5 lines

Thx for noticing this.

I'm planning to use these symbols to set up default builtin DT blobs from Kconfig itself (rather than current defconfigs). If that doesn't workout - sure I will remove the symbols.

No news here as of v3.17-rc4 and next-20140912. Are you still planning to use these symbols or should I submit the trivial patch to drop them?

Please send over patch - I'll queue it up for 3.18

Thx,
-Vineet

Quoted 7 lines

Thanks,

Paul Bolle

author
#4 lore raw

PATCH 1/1 ARC: [arcfpga] Get rid of ARC_BOARD_ANGEL4 and ARC_BOARD_ML509

Commit c00bfd974fb0 ("ARC: [arcfpga] Get rid of legacy BVCI latency unit support") removed the Kconfig symbol ARC_HAS_BVCI_LAT_UNIT. And that symbol's entry was the only place were the symbols ARC_BOARD_ANGEL4 and ARC_BOARD_ML509 were used. So ARC_BOARD_ANGEL4 and ARC_BOARD_ML509 can be removed too.

---
Done on top of next-20140923. Tested by grepping the tree only.

There are still references in defconfig files. Should those be removed too?

 arch/arc/plat-arcfpga/Kconfig | 11 -----------
 1 file changed, 11 deletions(-)
arch/arc/plat-arcfpga/Kconfig +0 -11
index 4965f9f4ffdc..217593a70751 100644
@@ -18,17 +18,6 @@ menuconfig ARC_PLAT_FPGA_LEGACY
 
 if ARC_PLAT_FPGA_LEGACY
 
-config ARC_BOARD_ANGEL4
-	bool "ARC Angel4"
-	default y
-	help
-	  ARC Angel4 FPGA Ref Platform (Xilinx Virtex Based)
-
-config ARC_BOARD_ML509
-	bool "ML509"
-	help
-	  ARC ML509 FPGA Ref Platform (Xilinx Virtex-5 Based)
-
 config ISS_SMP_EXTN
 	bool "ARC SMP Extensions (ISS Models only)"
 	default n
Signature · 1 line
1.9.3
Applied
#5 lore raw

Re: [PATCH] ARC: [arcfpga] Get rid of ARC_BOARD_ANGEL4 and ARC_BOARD_ML509

On Tuesday 23 September 2014 03:09 PM, Paul Bolle wrote:

Commit c00bfd974fb0 ("ARC: [arcfpga] Get rid of legacy BVCI latency unit support") removed the Kconfig symbol ARC_HAS_BVCI_LAT_UNIT. And that symbol's entry was the only place were the symbols ARC_BOARD_ANGEL4 and ARC_BOARD_ML509 were used. So ARC_BOARD_ANGEL4 and ARC_BOARD_ML509 can be removed too.

---
Done on top of next-20140923. Tested by grepping the tree only.

Applied to ARC for-next.

Thx Paul,
-Vineet

Applied
#6 lore raw

Re: [PATCH] ARC: [arcfpga] Get rid of ARC_BOARD_ANGEL4 and ARC_BOARD_ML509

On Thursday 25 September 2014 12:52 PM, Vineet Gupta wrote:
On Tuesday 23 September 2014 03:09 PM, Paul Bolle wrote:

Commit c00bfd974fb0 ("ARC: [arcfpga] Get rid of legacy BVCI latency unit support") removed the Kconfig symbol ARC_HAS_BVCI_LAT_UNIT. And that symbol's entry was the only place were the symbols ARC_BOARD_ANGEL4 and ARC_BOARD_ML509 were used. So ARC_BOARD_ANGEL4 and ARC_BOARD_ML509 can be removed too.

---
Done on top of next-20140923. Tested by grepping the tree only.

Applied to ARC for-next.

Thx Paul,
-Vineet

I did a grep for ARC_BOARD in arch/arc and it seems we have a few stragglers in def configs. I've pruned them and squashed in same commit.

-Vineet