Skip to contentSkip to conversation

canfestival: new package

PATCH Superseded Samuel Martin 3 participants 5 messages Jun 29, 2014 – Sep 23, 2014

v7 of 8 Superseded Latest is v8 →

lore
Share & tools
lore
#0 lore raw

PATCH v7 1/1 canfestival: new package

Cc Eric Jarrige <[email protected]>
Cc Julien Boibessot <[email protected]>
Cc Davide Viti <[email protected]>

---
changes v6 -> v7:
- rebase
- remove patch (merged upstream)
- bump version

changes v5 -> v6:
- rebase
- fix typoes (ThomasP)
- remove Anagate and PeakSystem support (ThomasP)
- fix kernel dependency (ThomasP)
- fix license details (ThomasP)
- add comment why we are using generic-infra (ThomasP)
- make install commands failed if something goes wrong (ThomasP)

changes v4 -> v5:
- rebase
- cosmetic changes (Davide)

changes v3 -> v4:
- rebase
- pass --prefix=/usr to the configure call (Davide)
- misc. cleanup in canfestival.mk (Yann)
- keep package/Config.in alphabetically ordered

changes v2 -> v3:
- rename package libcanfestival -> canfestival (follow upstream name)
- add option to install examples
- use latest revision
- use tarball instead of hg clone
- cosmetic fixes and typos (Peter and Yegor)
- add note about the standard mainline can interface (Peter)
- set default max bus number to 1 (Peter)

changes v1 -> v2:
- clean/fix *.mk

---
 package/Config.in                  |  1 +
 package/canfestival/Config.in      | 96 ++++++++++++++++++++++++++++++++++++++
 package/canfestival/canfestival.mk | 61 ++++++++++++++++++++++++
 3 files changed, 158 insertions(+)
 create mode 100644 package/canfestival/Config.in
 create mode 100644 package/canfestival/canfestival.mk
package/Config.in +1 -0
index d7e1acc..125571f 100644
@@ -724,6 +724,7 @@ endmenu
 menu "Networking"
 	source "package/agentpp/Config.in"
 	source "package/c-ares/Config.in"
+	source "package/canfestival/Config.in"
 	source "package/cppzmq/Config.in"
 	source "package/czmq/Config.in"
 	source "package/filemq/Config.in"
package/canfestival/Config.in new file +96 -0

96 lines not on this page · raw message

package/canfestival/canfestival.mk new file +61 -0

61 lines not on this page · raw message

Signature · 1 line
2.0.1
#1 lore raw

PATCH v7 1/1 canfestival: new package

I'd like to propose a little patch to add pkg-config support. It's only a draft proposal, even if I'm using it. I hope it could be useful. Claudio

canfestival.pc.in new file +12 -0
new file mode 100644
index 0000000..08ecbe1
@@ -0,0 +1,12 @@
+PREFIX = SUB_PREFIX
+TARGET = SUB_TARGET
+
+prefix=${DESTDIR}${PREFIX}
+libdir=${prefix}/lib
+includedir=${prefix}/include/canfestival
+
+Name: Canfestival
+Description: Canfestival CANOpen library 
+Version: 1
+Libs: -L${libdir} -lcanfestival -lcanfestival_${TARGET} -lrt -ldl -lpthread
+Cflags: -I${includedir}
configure +0 -0
index b63b276..6d909d6 100755
@@ -825,6 +825,7 @@ elif [ "$SUB_TARGET" = "unix" -a "$SUB_TIMERS_DRIVER" =

"kernel_xeno" ]; then

elif [ "$SUB_TARGET" = "unix" ]; then
MAKEFILES=$MAKEFILES\
+\ canfestival.pc.in\
\ examples/CANOpenShell/Makefile.in\
\ examples/TestMasterSlave/Makefile.in\
\ examples/TestMasterSlaveLSS/Makefile.in\

src/Makefile.in +2 -1
index e709f4f..8bee33d 100644
@@ -132,9 +132,10 @@ $(TARGET)_%.o: %.c
 	$(CC) $(CFLAGS) $(PROG_CFLAGS) ${PROGDEFINES} $(INCLUDES) -o $@ -c $<
 
 install: libcanfestival.a
-	mkdir -p $(DESTDIR)$(PREFIX)/lib/
+	mkdir -p $(DESTDIR)$(PREFIX)/lib/pkgconfig/
 	mkdir -p $(DESTDIR)$(PREFIX)/include/canfestival
 	cp libcanfestival.a $(DESTDIR)$(PREFIX)/lib/
+	cp ../canfestival.pc $(DESTDIR)$(PREFIX)/lib/pkgconfig/
 	cp ../include/*.h $(DESTDIR)$(PREFIX)/include/canfestival
 
 uninstall:

--
View this message in context: http://buildroot-busybox.2317881.n4.nabble.com/PATCH-v7-canfestival-new-package-tp73727p80004.html
Sent from the Buildroot (busybox) mailing list [email protected].

#2 lore raw

PATCH v7 1/1 canfestival: new package

Dear claurita,

Quoted 2 lines · claurita

I'd like to propose a little patch to add pkg-config support. It's only a draft proposal, even if I'm using it. I hope it could be useful.

Thanks. But your patch is against canfestival itself, while you're posting to the Buildroot mailing list. So you have two choices here:

*/ Submit your patch to the canfestival project directly.

*/ Add your patch inside Buildroot, in package/canfestival/, and then
post a Buildroot patch adding your patch (yes, you'll have a patch adding a patch!)

Thanks,

Thomas Petazzoni

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#3 lore raw

PATCH v7 1/1 canfestival: new package

In reply to Samuel Martin

Thank you for your attention.
My intention was exactly the second choice you offered.
Those few lines are the contents of a file named canfestival-add-pkgconfig-support.patch that I put into /buildroot/package/canfestival. It only does what I actually need and I thought it may save a bit of time to someone else.
Think of my first post as a "(more or less) already done" feature request to the author of the real patch, in case of his interest for V8.

Claudio

--
View this message in context: http://buildroot-busybox.2317881.n4.nabble.com/PATCH-v7-canfestival-new-package-tp73727p80043.html
Sent from the Buildroot (busybox) mailing list archive at Nabble.com.

#4 lore raw

PATCH v7 1/1 canfestival: new package

Hi Claudio,

Quoted 9 lines · claurita

Thank you for your attention.
My intention was exactly the second choice you offered.
Those few lines are the contents of a file named canfestival-add-pkgconfig-support.patch that I put into /buildroot/package/canfestival. It only does what I actually need and I thought it may save a bit of time to someone else.
Think of my first post as a "(more or less) already done" feature request to the author of the real patch, in case of his interest for V8.

Thanks for the patch.

I plan to respin this patch soon (in the coming days or weeks at worst). I'll integrate this patch if not already merged upstream.

If you could try to submit this patch to canfestival mailing list [1] (you need to subscribe to the canfestival list [2]), it'd be good. From my little experience working with the canfestival developer, patches get merged rather quickly.

Regards,

[1] canfestival-devel at lists.sourceforge.net
[2] https://lists.sourceforge.net/lists/listinfo/canfestival-devel

Signature · 1 line
Samuel