Skip to contentSkip to conversation

parisc:Remove unnecessary FIXMES in init.c

PATCH In review Nicholas Krause 3 participants 5 messages Sep 24, 2014 PA-RISC architecture

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 parisc:Remove unnecessary FIXMES in init.c

This removes the two fixmes in the file, init.c for compiler hints for comments related to compiler hints in linux_gateway_page_addr and map_hpux_gateway_page to change from FIXME to HINT in order for people reading this code to understand that these are compiler hints.

---
 arch/parisc/mm/init.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/parisc/mm/init.c +2 -2
index 0bef864..668102e 100644
@@ -733,7 +733,7 @@ static void __init pagetable_init(void)
 static void __init gateway_init(void)
 {
 	unsigned long linux_gateway_page_addr;
-	/* FIXME: This is 'const' in order to trick the compiler
+	/* HINT: This is 'const' in order to trick the compiler
 	   into not treating it as DP-relative data. */
 	extern void * const linux_gateway_page;
 
@@ -761,7 +761,7 @@ map_hpux_gateway_page(struct task_struct *tsk, struct mm_struct *mm)
 	unsigned long start_pte;
 	unsigned long address;
 	unsigned long hpux_gw_page_addr;
-	/* FIXME: This is 'const' in order to trick the compiler
+	/* HINT: This is 'const' in order to trick the compiler
 	   into not treating it as DP-relative data. */
 	extern void * const hpux_gateway_page;
 
Signature · 1 line
1.9.1
#1 lore raw
Quoted 6 lines · Nicholas Krause

This removes the two fixmes in the file, init.c for compiler hints for comments related to compiler hints in linux_gateway_page_addr and map_hpux_gateway_page to change from FIXME to HINT in order for people reading this code to understand that these are compiler hints.

"* const" tells the compiler that a pointer is a constant. It doesn't tell the compiler that the data shall not be treated as DP-relative.

FIXME as in: We should find a better way to tell the compiler to not treat this data as DP-relative.

Can you please stop this ?

Guenter

Quoted 37 lines
---
 arch/parisc/mm/init.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/parisc/mm/init.c +2 -2
index 0bef864..668102e 100644
@@ -733,7 +733,7 @@ static void __init pagetable_init(void)
 static void __init gateway_init(void)
 {
 	unsigned long linux_gateway_page_addr;
-	/* FIXME: This is 'const' in order to trick the compiler
+	/* HINT: This is 'const' in order to trick the compiler
 	   into not treating it as DP-relative data. */
 	extern void * const linux_gateway_page;
 
@@ -761,7 +761,7 @@ map_hpux_gateway_page(struct task_struct *tsk, struct mm_struct *mm)
 	unsigned long start_pte;
 	unsigned long address;
 	unsigned long hpux_gw_page_addr;
-	/* FIXME: This is 'const' in order to trick the compiler
+	/* HINT: This is 'const' in order to trick the compiler
 	   into not treating it as DP-relative data. */
 	extern void * const hpux_gateway_page;
 
Signature · 7 lines
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
author
#2 lore raw
Quoted 49 lines · Guenter Roeck
Quoted 6 lines · Nicholas Krause

This removes the two fixmes in the file, init.c for compiler hints for comments related to compiler hints in linux_gateway_page_addr and map_hpux_gateway_page to change from FIXME to HINT in order for people reading this code to understand that these are compiler hints.

"* const" tells the compiler that a pointer is a constant. It doesn't tell the compiler that the data shall not be treated as DP-relative.

FIXME as in: We should find a better way to tell the compiler to not treat this data as DP-relative.

Can you please stop this ?

Guenter

Quoted 30 lines
---
 arch/parisc/mm/init.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/parisc/mm/init.c +2 -2
index 0bef864..668102e 100644
@@ -733,7 +733,7 @@ static void __init pagetable_init(void)
 static void __init gateway_init(void)
 {
 	unsigned long linux_gateway_page_addr;
-	/* FIXME: This is 'const' in order to trick the compiler
+	/* HINT: This is 'const' in order to trick the compiler
 	   into not treating it as DP-relative data. */
 	extern void * const linux_gateway_page;
 
@@ -761,7 +761,7 @@ map_hpux_gateway_page(struct task_struct *tsk, struct mm_struct *mm)
 	unsigned long start_pte;
 	unsigned long address;
 	unsigned long hpux_gw_page_addr;
-	/* FIXME: This is 'const' in order to trick the compiler
+	/* HINT: This is 'const' in order to trick the compiler
 	   into not treating it as DP-relative data. */
 	extern void * const hpux_gateway_page;
 
Signature · 1 line
1.9.1
Quoted 7 lines
Quoted 7 lines

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Guenter,
I asked the maintainers and I got,

Quoted 4 lines · Helge Deller

The FIXME: is misleading. It should maybe better read "HINT:" or something like that. Trivially it's basically just casting the symbol so that the compiler will produce the correct code later on.
There is nothing you could try to "fix".

Why not just remove "FIXME: " from these comments?

Dave
As the reply.
Cheers Nick

#3 lore raw
Quoted 63 lines · nick
Quoted 50 lines · Guenter Roeck
Quoted 6 lines · Nicholas Krause

This removes the two fixmes in the file, init.c for compiler hints for comments related to compiler hints in linux_gateway_page_addr and map_hpux_gateway_page to change from FIXME to HINT in order for people reading this code to understand that these are compiler hints.

"* const" tells the compiler that a pointer is a constant. It doesn't tell the compiler that the data shall not be treated as DP-relative.

FIXME as in: We should find a better way to tell the compiler to not treat this data as DP-relative.

Can you please stop this ?

Guenter

Quoted 31 lines

---
arch/parisc/mm/init.c | 4 ++--

1 file changed, 2 insertions(+), 2 deletions(-)
arch/parisc/mm/init.c +2 -2
index 0bef864..668102e 100644
@@ -733,7 +733,7 @@ static void __init pagetable_init(void)
 static void __init gateway_init(void)
 {
 	unsigned long linux_gateway_page_addr;
-	/* FIXME: This is 'const' in order to trick the compiler
+	/* HINT: This is 'const' in order to trick the compiler
 	   into not treating it as DP-relative data. */
 	extern void * const linux_gateway_page;
 
@@ -761,7 +761,7 @@ map_hpux_gateway_page(struct task_struct *tsk,  
 struct mm_struct *mm)
 	unsigned long start_pte;
 	unsigned long address;
 	unsigned long hpux_gw_page_addr;
-	/* FIXME: This is 'const' in order to trick the compiler
+	/* HINT: This is 'const' in order to trick the compiler
 	   into not treating it as DP-relative data. */
 	extern void * const hpux_gateway_page;
Signature · 2 lines
-- 
1.9.1
Quoted 7 lines
Quoted 7 lines

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Guenter,
I asked the maintainers and I got,
On 9/23/2014 4:48 PM, Helge Deller wrote:

Quoted 5 lines
Quoted 4 lines

The FIXME: is misleading. It should maybe better read "HINT:" or something like that. Trivially it's basically just casting the symbol so that the compiler will produce the correct code later on.
There is nothing you could try to "fix".

Why not just remove "FIXME: " from these comments?

The wording of the comment is not good. You can't "trick" the compiler into not treating a constant as DP-relative data. Whether or not a constant is loaded as an immediate depends on its value.

Dave
--
John David Anglin [email protected]

#4 lore raw
Quoted 85 lines · John David Anglin
Quoted 67 lines · nick
Quoted 52 lines · Guenter Roeck
Quoted 7 lines · Nicholas Krause

This removes the two fixmes in the file, init.c for compiler hints for comments related to compiler hints in linux_gateway_page_addr and map_hpux_gateway_page to change from FIXME to HINT in order for people reading this code to understand that these are compiler hints.

"* const" tells the compiler that a pointer is a constant. It doesn't tell the compiler that the data shall not be treated as DP-relative.

FIXME as in: We should find a better way to tell the compiler to not treat this data as DP-relative.

Can you please stop this ?

Guenter

Quoted 31 lines

---
arch/parisc/mm/init.c | 4 ++--

1 file changed, 2 insertions(+), 2 deletions(-)
arch/parisc/mm/init.c +2 -3
index 0bef864..668102e 100644
@@ -733,7 +733,7 @@ static void __init pagetable_init(void)
 static void __init gateway_init(void)
 {
        unsigned long linux_gateway_page_addr;
-       /* FIXME: This is 'const' in order to trick the compiler
+       /* HINT: This is 'const' in order to trick the compiler
           into not treating it as DP-relative data. */
        extern void * const linux_gateway_page;
 
@@ -761,7 +761,7 @@ map_hpux_gateway_page(struct task_struct *tsk,
 struct mm_struct *mm)
        unsigned long start_pte;
        unsigned long address;
        unsigned long hpux_gw_page_addr;
-       /* FIXME: This is 'const' in order to trick the compiler
+       /* HINT: This is 'const' in order to trick the compiler
           into not treating it as DP-relative data. */
        extern void * const hpux_gateway_page;
 
--

1.9.1

Quoted 8 lines
Quoted 8 lines

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Guenter,
I asked the maintainers and I got,

Quoted 1 line · Helge Deller
Quoted 7 lines
Quoted 5 lines

The FIXME: is misleading. It should maybe better read "HINT:" or something like that.
Trivially it's basically just casting the symbol so that the compiler will produce the correct code later on.
There is nothing you could try to "fix".

Why not just remove "FIXME: " from these comments?

The wording of the comment is not good. You can't "trick" the compiler into not
treating a constant as DP-relative data. Whether or not a constant is loaded as an
immediate depends on its value.

Quoted 6 lines

Dave
--
John David Anglin [email protected]

Are stating I need to change the wording of my commit or the comment? Nick