Skip to contentSkip to conversation

KVM: remove Kconfig symbol KVM_VFIO?

PATCH In review Paul Bolle 2 participants 4 messages Sep 23, 2014 – Sep 24, 2014

Subsystems (3)
x86 KVM KVM x86
lore
Share & tools
lore

Paul Bolle

author
#0 lore raw

Will,

Your commit 80ce1639727e ("KVM: VFIO: register kvm_device_ops dynamically") is included in linux-next since next-20140918. It removes the last usage of CONFIG_KVM_VFIO. After that commit setting KVM_VFIO is pointless.

Is the patch to remove the Kconfig symbol KVM_VFIO from the tree queued somewhere? If not, should I submit a trivial patch that does that?

Paul Bolle

maintainer
#1 lore raw

Il 23/09/2014 21:09, Paul Bolle ha scritto:

Quoted 9 lines

Will,

Your commit 80ce1639727e ("KVM: VFIO: register kvm_device_ops dynamically") is included in linux-next since next-20140918. It removes the last usage of CONFIG_KVM_VFIO. After that commit setting KVM_VFIO is pointless.

Is the patch to remove the Kconfig symbol KVM_VFIO from the tree queued somewhere? If not, should I submit a trivial patch that does that?

No, if you send that yourself it will be appreciated. Thanks!

Paolo

author
#2 lore raw

PATCH 1/1 KVM: Remove KVM_VFIO

There are no checks for CONFIG_KVM_VFIO and nothing depends on KVM_VFIO. Setting KVM_VFIO has no effect. Remove that Kconfig symbol.

Signed-off-by Paul Bolle <[email protected]>

---
I choose not to mention commit 80ce1639727e ("KVM: VFIO: register kvm_device_ops dynamically") as references to linux-next commits might go stale and only confuse future readers.

Done on top of next-21040923. Tested with "git grep" only.

 arch/x86/kvm/Kconfig | 1 -
 virt/kvm/Kconfig     | 3 ---
 2 files changed, 4 deletions(-)
arch/x86/kvm/Kconfig +0 -1
index f9d16ff56c6b..178d872734b1 100644
@@ -39,7 +39,6 @@ config KVM
 	select PERF_EVENTS
 	select HAVE_KVM_MSI
 	select HAVE_KVM_CPU_RELAX_INTERCEPT
-	select KVM_VFIO
 	---help---
 	  Support hosting fully virtualized guest machines using hardware
 	  virtualization extensions.  You will need a fairly recent
virt/kvm/Kconfig +0 -3
index fc0c5e603eb4..1f5ebc4693c3 100644
@@ -34,6 +34,3 @@ config HAVE_KVM_MSI
 
 config HAVE_KVM_CPU_RELAX_INTERCEPT
        bool
-
-config KVM_VFIO
-       bool
Signature · 1 line
1.9.3
maintainer
#3 lore raw

Re: [PATCH] [next-20140923] KVM: Remove KVM_VFIO

Il 24/09/2014 10:22, Paul Bolle ha scritto:

Quoted 8 lines

There are no checks for CONFIG_KVM_VFIO and nothing depends on KVM_VFIO. Setting KVM_VFIO has no effect. Remove that Kconfig symbol.

Signed-off-by Paul Bolle <[email protected]>

---
I choose not to mention commit 80ce1639727e ("KVM: VFIO: register kvm_device_ops dynamically") as references to linux-next commits might go stale and only confuse future readers.

In the case of KVM, linux-commit hashes are substantially stable. I'll add back the reference.

Thanks for the patch, I'll apply it.

Paolo