ncpfs: use list_for_each_entry() for list iteration
PATCH RESEND 1/1 ncpfs: use list_for_each_entry() for list iteration
Use list_for_each_entry() for the sake of simplicity and readability.
Signed-off-by Christoph Jaeger <[email protected]>
--- fs/ncpfs/dir.c | 6 +----- fs/ncpfs/ncplib_kernel.h | 14 ++------------ 2 files changed, 3 insertions(+), 17 deletions(-)
fs/ncpfs/dir.c +1 -5
@@ -388,7 +388,6 @@ static struct dentry * ncp_dget_fpos(struct dentry *dentry, struct dentry *parent, unsigned long fpos) { struct dentry *dent = dentry; -struct list_head *next;if (d_validate (dent, parent)) { if (dent->d_name.len <= NCP_MAXPATHLEN &&
@@ -404,9 +403,7 @@ ncp_dget_fpos(struct dentry *dentry, struct dentry *parent, unsigned long fpos)/* If a pointer is invalid, we search the dentry. */ spin_lock (&parent->d_lock); - next = parent->d_subdirs.next; -while (next != &parent->d_subdirs) { - dent = list_entry(next, struct dentry, d_u.d_child); +list_for_each_entry (dent, &parent->d_subdirs, d_u.d_child) {if ((unsigned long )dent->d_fsdata == fpos) {if (dent->d_inode)dget (dent);
@@ -415,7 +412,6 @@ ncp_dget_fpos(struct dentry *dentry, struct dentry *parent, unsigned long fpos)spin_unlock (&parent->d_lock); goto out; } - next = next->next; }spin_unlock (&parent->d_lock);return NULL ;
fs/ncpfs/ncplib_kernel.h +2 -12
@@ -188,20 +188,14 @@ static inline void ncp_renew_dentries(struct dentry *parent) {struct ncp_server *server =NCP_SERVER (parent->d_inode); -struct list_head *next;struct dentry *dentry;spin_lock (&parent->d_lock); - next = parent->d_subdirs.next; -while (next != &parent->d_subdirs) { - dentry = list_entry(next, struct dentry, d_u.d_child); - +list_for_each_entry (dentry, &parent->d_subdirs, d_u.d_child) {if (dentry->d_fsdata ==NULL )ncp_age_dentry (server, dentry);else ncp_new_dentry (dentry); - - next = next->next; }spin_unlock (&parent->d_lock); }
@@ -210,16 +204,12 @@ static inline void ncp_invalidate_dircache_entries(struct dentry *parent) {struct ncp_server *server =NCP_SERVER (parent->d_inode); -struct list_head *next;struct dentry *dentry;spin_lock (&parent->d_lock); - next = parent->d_subdirs.next; -while (next != &parent->d_subdirs) { - dentry = list_entry(next, struct dentry, d_u.d_child); +list_for_each_entry (dentry, &parent->d_subdirs, d_u.d_child) { dentry->d_fsdata =NULL ;ncp_age_dentry (server, dentry); - next = next->next; }spin_unlock (&parent->d_lock); }
Signature · 1 line
1.9.3