ARM: efm32: drop selecting NO_DMA
PATCH 1/1 ARM: efm32: drop selecting NO_DMA
The Kconfig entry for ARCH_EFM32 selects NO_DMA. But that doesn't have any effect as arm doesn't have a Kconfig entry for NO_DMA. This select is a nop. Drop it.
---
Tested by playing with arch/arm/configs/efm32_defconfig. After "make oldconfig" the .config contains CONFIG_HAS_DMA=y both before and after this patch, as is expected.
Actually, the only difference I found in the .config file was that after this patch the .config file contained
CONFIG_ARCH_EFM32=y
I have no idea why. Did I botch my test?
arch/arm/Kconfig | 1 - 1 file changed, 1 deletion(-)
arch/arm/Kconfig +0 -1
@@ -426,7 +426,6 @@ config ARCH_EFM32 select COMMON_CLK select CPU_V7M select GENERIC_CLOCKEVENTS - select NO_DMA select NO_IOPORT_MAP select SPARSE_IRQ select USE_OF
Signature · 1 line
1.9.3
Quoted 5 lines · Paul Bolle
Actually, the only difference I found in the .config file was that after this patch the .config file contained
CONFIG_ARCH_EFM32=yI have no idea why. Did I botch my test?
Apparently I did. I retested this patch using next-20140925. Now the generated .config before and after applying this patch are identical. So all's good: this select really is a nop.
Paul Bolle
Uwe Kleine-König
Acked-byHello Paul,
Quoted 6 lines · Paul Bolle
Quoted 5 lines · Paul Bolle
Actually, the only difference I found in the .config file was that after this patch the .config file contained
CONFIG_ARCH_EFM32=yI have no idea why. Did I botch my test?
Looking at the patch that introduced the NO_DMA select I think I just copied it from somewhere[1] without questioning it. It seems the symbol already didn't exist when efm32 hit mainline in 6d85e2b0b6bed6ae7070426d5e43174c593e075c.
Best regards
Uwe
[1] probably Catalin's 2.6.33 that introduced v7-M support initially.
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |