Skip to contentSkip to conversation

unicore32: Remove unneeded Kconfig entry NO_IOPORT_MAP

PATCH In review Paul Bolle 2 participants 4 messages Sep 24, 2014 – Oct 1, 2014 Generic include/asm header files

lore
Share & tools
lore

Paul Bolle

author
#0 lore raw

PATCH 1/1 unicore32: Remove unneeded Kconfig entry NO_IOPORT_MAP

Architectures only need a Kconfig entry for NO_IOPORT_MAP if it is possible that its value will be 'y'. For unicore32 its value will always be 'n', making it pointless. Remove it.

---
Tested by playing with arch/unicore32/configs/unicore32_defconfig. This patch made no difference whatsoever to the generated .config file. Please note that it has
CONFIG_HAS_IOPORT_MAP=y

set after invoking "make oldconfig" both before and after this patch.

 arch/unicore32/Kconfig | 3 ---
 1 file changed, 3 deletions(-)
arch/unicore32/Kconfig +0 -3
index 928237a7b9ca..2322cc87e7cb 100644
@@ -27,9 +27,6 @@ config UNICORE32
 config GENERIC_CSUM
 	def_bool y
 
-config NO_IOPORT_MAP
-	bool
-
 config STACKTRACE_SUPPORT
 	def_bool y
 
Signature · 1 line
1.9.3
#1 lore raw

Sorry for late reply.

I checked this config, and it's only used for HAS_IOPORT_MAP in lib/Kconfig Sure, removing it means no different for .config file.
I think a better way is reserving it or moving it into arch/Kconfig

Xuetao Guan

Quoted 33 lines · ----- Paul Bolle

Architectures only need a Kconfig entry for NO_IOPORT_MAP if it is possible that its value will be 'y'. For unicore32 its value will always be 'n', making it pointless. Remove it.

---
Tested by playing with arch/unicore32/configs/unicore32_defconfig. This patch made no difference whatsoever to the generated .config file. Please note that it has
CONFIG_HAS_IOPORT_MAP=y

set after invoking "make oldconfig" both before and after this patch.

 arch/unicore32/Kconfig | 3 ---
 1 file changed, 3 deletions(-)
arch/unicore32/Kconfig +0 -3
index 928237a7b9ca..2322cc87e7cb 100644
@@ -27,9 +27,6 @@ config UNICORE32
 config GENERIC_CSUM
 	def_bool y
 
-config NO_IOPORT_MAP
-	bool
-
 config STACKTRACE_SUPPORT
 	def_bool y
 
Signature · 1 line
1.9.3
author
#2 lore raw
Quoted 1 line · Xuetao Guan

Sorry for late reply.

You replied within four days. That's rather quick, actually.

Quoted 3 lines

I checked this config, and it's only used for HAS_IOPORT_MAP in lib/Kconfig Sure, removing it means no different for .config file.
I think a better way is reserving it

I'm not sure I get what you're saying here: what do mean with "reserving it"?

Quoted 1 line

or moving it into arch/Kconfig

Without a (treewide) patch I find it hard to say whether that's worth the trouble. But even if that move would be done, wouldn't it include dropping this entry from arch/unicore32 anyway?

Paul Bolle

#3 lore raw
Quoted 11 lines · ----- Paul Bolle
Quoted 1 line · Xuetao Guan

Sorry for late reply.

You replied within four days. That's rather quick, actually.

Quoted 3 lines

I checked this config, and it's only used for HAS_IOPORT_MAP in lib/Kconfig Sure, removing it means no different for .config file.
I think a better way is reserving it

I'm not sure I get what you're saying here: what do mean with "reserving it"?

I mean, it's better to keep the code unchanged.

Quoted 6 lines
Quoted 2 lines

or moving it into arch/Kconfig

Without a (treewide) patch I find it hard to say whether that's worth the trouble. But even if that move would be done, wouldn't it include dropping this entry from arch/unicore32 anyway?

IMHO, this config could be removed from kernel code.

Quoted 4 lines

Paul Bolle