Skip to contentSkip to conversation

ltp-networking/tcp_cmds/finger: fix finger bad user and host test

PATCH In review Hangbin Liu 2 participants 3 messages Sep 25, 2014 – Oct 9, 2014

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ltp-networking/tcp_cmds/finger: fix finger bad user and host test

Finger always return 0 with bad user and host test. And it also return different error message on different distros. So let's only check stderr message and decide whether the test pass or fail.

---
 testcases/network/tcp_cmds/finger/finger01 | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)
testcases/network/tcp_cmds/finger/finger01 +3 -6
index 203d746..89693ff 100755
@@ -115,13 +115,10 @@ do_test2()
     finger -x 2>&1 1>/dev/null && end_testcase "finger -x should fail"
 
     tst_resm TINFO "finger -bad user "
-    finger $BADUSER 2>&1 1>/dev/null || end_testcase "finger $BADUSER"
-    finger @$BADHOST 2>&1 1>/dev/null | grep "finger: unknown host" \
-        || end_testcase "finger @$BADHOST"
-    if ! finger $BADUSER@$BADHOST 2>&1 1>/dev/null \
-        | grep "finger: unknown host"; then
+    [ "finger $BADUSER 2>&1 1>/dev/null" ] || end_testcase "finger $BADUSER"
+    [ "finger @$BADHOST 2>&1 1>/dev/null" ] || end_testcase "finger @$BADHOST"
+    [ "finger $BADUSER@$BADHOST 2>&1 1>/dev/null" ] || \
         end_testcase "finger $BADUSER@$BADHOST"
-    fi
 }
 
 #-----------------------------------------------------------------------
Signature · 13 lines
1.9.3


------------------------------------------------------------------------------
Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports
Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
#1 lore raw

Hi!

Quoted 14 lines · Hangbin Liu

Finger always return 0 with bad user and host test. And it also return different error message on different distros. So let's only check stderr message and decide whether the test pass or fail.

---
  testcases/network/tcp_cmds/finger/finger01 | 9 +++------
  1 file changed, 3 insertions(+), 6 deletions(-)
testcases/network/tcp_cmds/finger/finger01 +0 -0
index 203d746..89693ff 100755

testcases/network/tcp_cmds/finger/finger01 do_test2() · line 115

Quoted 1 line
testcases/network/tcp_cmds/finger/finger01 +0 -0
@@ -115,13 +115,10 @@ do_test2()
      finger -x 2>&1 1>/dev/null && end_testcase "finger -x should fail"

I would change redirection here to > /dev/null 2>&1 as we don't need to print stderr.

testcases/network/tcp_cmds/finger/finger01 do_test2() · line 120

Quoted 10 lines
testcases/network/tcp_cmds/finger/finger01 +3 -5
      tst_resm TINFO "finger -bad user "
-    finger $BADUSER 2>&1 1>/dev/null || end_testcase "finger $BADUSER"
-    finger @$BADHOST 2>&1 1>/dev/null | grep "finger: unknown host" \
-        || end_testcase "finger @$BADHOST"
-    if ! finger $BADUSER@$BADHOST 2>&1 1>/dev/null \
-        | grep "finger: unknown host"; then
+    [ "finger $BADUSER 2>&1 1>/dev/null" ] || end_testcase "finger $BADUSER"
+    [ "finger @$BADHOST 2>&1 1>/dev/null" ] || end_testcase "finger @$BADHOST"
+    [ "finger $BADUSER@$BADHOST 2>&1 1>/dev/null" ] || \

Checking string constants... not command output, forgot to add '$()'?

Besides, it'd be great to get rid of obsolete 'net_cmdlib.sh' in the test.

Thanks
Alexey

------------------------------------------------------------------------------
Slashdot TV. Videos for Nerds. Stuff that Matters.
http://pubads.g.doubleclick.net/gampad/clk?id=160591471&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#2 lore raw
Quoted 12 lines · Alexey Kodanev

Hi!

Quoted 9 lines · Hangbin Liu

Finger always return 0 with bad user and host test. And it also return different error message on different distros. So let's only check stderr message and decide whether the test pass or fail.

---
 testcases/network/tcp_cmds/finger/finger01 | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)
Quoted 9 lines

testcases/network/tcp_cmds/finger/finger01 do_test2() · line 115

Quoted 6 lines
testcases/network/tcp_cmds/finger/finger01 +0 -0
index 203d746..89693ff 100755
@@ -115,13 +115,10 @@ do_test2()
     finger -x 2>&1 1>/dev/null && end_testcase "finger -x should fail"

I would change redirection here to > /dev/null 2>&1 as we don't need to print stderr.

Yes, will correct it.

Quoted 11 lines

testcases/network/tcp_cmds/finger/finger01 do_test2() · line 120

Quoted 10 lines
testcases/network/tcp_cmds/finger/finger01 +3 -5
     tst_resm TINFO "finger -bad user "
-    finger $BADUSER 2>&1 1>/dev/null || end_testcase "finger $BADUSER"
-    finger @$BADHOST 2>&1 1>/dev/null | grep "finger: unknown host" \
-        || end_testcase "finger @$BADHOST"
-    if ! finger $BADUSER@$BADHOST 2>&1 1>/dev/null \
-        | grep "finger: unknown host"; then
+    [ "finger $BADUSER 2>&1 1>/dev/null" ] || end_testcase "finger $BADUSER"
+    [ "finger @$BADHOST 2>&1 1>/dev/null" ] || end_testcase "finger @$BADHOST"
+    [ "finger $BADUSER@$BADHOST 2>&1 1>/dev/null" ] || \
Quoted 1 line

Checking string constants... not command output, forgot to add '$()'?

Opps, sorry for the stupid mistake.

Quoted 2 lines

Besides, it'd be great to get rid of obsolete 'net_cmdlib.sh' in the test.

OK, I will send another patch to clean up net_cmdlib.sh and mv read_opts() to test_net.sh

Signature · 13 lines
Thanks & Best Regards
Hangbin Liu <[email protected]>

------------------------------------------------------------------------------
Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports
Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list