Skip to contentSkip to conversation

ASoC: max98090: Enable both DMIC channels also when using mono configuration

PATCH Applied Jarkko Nikula 2 participants 4 messages Sep 26, 2014 – Sep 28, 2014

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 ASoC: max98090: Enable both DMIC channels also when using mono configuration

According to MAX98090 specification "Digital microphone clock (DMC) is enabled once both data channels are enabled.". Therefore both digital microphone data channels must be enabled also when using mono microphone configuration.

Fix this by moving "DMICL_ENA" and "DMICR_ENA" supply widgets from "DMICL" and "DMICR" inputs to "DMIC Mux" in order to enable both data channels whenever there is active mono or stereo digital microphone input path.

Use of "DMICL" and "DMICR" inputs are retained for informative source and in case the driver would find use for exact digital microphone configuration in the future.

---
for-next, only byt-max98090 uses DMIC and I noticed this after disabling unused codec pins.

---
 sound/soc/codecs/max98090.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
sound/soc/codecs/max98090.c +2 -2
index f2a3f30a5d9f..d519294f57c7 100644
@@ -1311,8 +1311,6 @@ static const struct snd_soc_dapm_route max98090_dapm_routes[] = {
 	{"MIC1 Input", NULL, "MIC1"},
 	{"MIC2 Input", NULL, "MIC2"},
 
-	{"DMICL", NULL, "DMICL_ENA"},
-	{"DMICR", NULL, "DMICR_ENA"},
 	{"DMICL", NULL, "AHPF"},
 	{"DMICR", NULL, "AHPF"},
 
@@ -1370,6 +1368,8 @@ static const struct snd_soc_dapm_route max98090_dapm_routes[] = {
 	{"DMIC Mux", "ADC", "ADCR"},
 	{"DMIC Mux", "DMIC", "DMICL"},
 	{"DMIC Mux", "DMIC", "DMICR"},
+	{"DMIC Mux", "DMIC", "DMICL_ENA"},
+	{"DMIC Mux", "DMIC", "DMICR_ENA"},
 
 	{"LBENL Mux", "Normal", "DMIC Mux"},
 	{"LBENL Mux", "Loopback", "LTENL Mux"},
Signature · 1 line
2.1.0
#1 lore raw

PATCH 2/2 ASoC: Intel: byt-max98090: Set card as fully routed

All byt-max98090 audio connections are known and described in DAPM routing table. Set the fully_routed flag in order to disable unused codec pins.

---
 sound/soc/intel/byt-max98090.c | 1 +
 1 file changed, 1 insertion(+)
sound/soc/intel/byt-max98090.c +1 -0
index b8b8af571ef1..d52681e7225e 100644
@@ -139,6 +139,7 @@ static struct snd_soc_card byt_max98090_card = {
 	.num_dapm_routes = ARRAY_SIZE(byt_max98090_audio_map),
 	.controls = byt_max98090_controls,
 	.num_controls = ARRAY_SIZE(byt_max98090_controls),
+	.fully_routed = true,
 };
 
 static int byt_max98090_probe(struct platform_device *pdev)
Signature · 1 line
2.1.0
maintainer Applied
#2 lore raw

Re: [PATCH 2/2] ASoC: Intel: byt-max98090: Set card as fully routed

Quoted 2 lines · Jarkko Nikula

All byt-max98090 audio connections are known and described in DAPM routing table. Set the fully_routed flag in order to disable unused codec pins.

Applied, thanks.

maintainer Applied
#3 lore raw
In reply to Jarkko Nikula
Quoted 4 lines · Jarkko Nikula

According to MAX98090 specification "Digital microphone clock (DMC) is enabled once both data channels are enabled.". Therefore both digital microphone data channels must be enabled also when using mono microphone configuration.

Applied, thanks.