ASoC: fsl_ssi: Remove unneeded 'i2s-slave' property
Subsystems (4)
Fabio Estevam
reviewerPATCH v3 1/2 ASoC: fsl_ssi: Remove unneeded 'i2s-slave' property
From: Fabio Estevam <[email protected]>
There is no need to use 'i2s-slave' property, since master/slave configuration are passed via machine layer.
This change does not break existing users because they do check for slave mode inside sound/soc/fsl/mpc8610_hpcd.c/p1022_ds.c/p1022_rdk.c
---
Changes since v2:
- Added Timur's Ack and CC the alsa-list
Changes since v1:
- None
sound/soc/fsl/fsl_ssi.c | 3 --- 1 file changed, 3 deletions(-)
sound/soc/fsl/fsl_ssi.c +0 -3
@@ -1285,9 +1285,6 @@ static int fsl_ssi_probe(struct platform_device *pdev)if (sprop) {if (!strcmp (sprop,"ac97-slave" )) ssi_private->dai_fmt =SND_SOC_DAIFMT_AC97 ; -else if (!strcmp (sprop,"i2s-slave" )) - ssi_private->dai_fmt =SND_SOC_DAIFMT_I2S | -SND_SOC_DAIFMT_CBM_CFM ; } ssi_private->use_dma = !of_property_read_bool(np,
Signature · 1 line
1.9.1
Fabio Estevam
reviewerPATCH v3 2/2 ASoC: fsl ssi doc: Remove unused properties
From: Fabio Estevam <[email protected]>
The fsl_ssi driver only checks for the ac97 mode property, so remove the unused ones.
---
Changes since v2:
- Added Timur's Ack and CC the alsa-list
Changes since v1:
- Newly introduced in this series
Documentation/devicetree/bindings/sound/fsl,ssi.txt | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-)
Documentation/devicetree/bindings/sound/fsl,ssi.txt +1 -7
@@ -58,13 +58,7 @@ Optional properties: Documentation/devicetree/bindings/dma/dma.txt. - dma-names: Two dmas have to be defined, "tx" and "rx", if fsl,imx-fiq is not defined. -- fsl,mode: The operating mode for the SSI interface. - "i2s-slave" - I2S mode, SSI is clock slave - "i2s-master" - I2S mode, SSI is clock master - "lj-slave" - left-justified mode, SSI is clock slave - "lj-master" - l.j. mode, SSI is clock master - "rj-slave" - right-justified mode, SSI is clock slave - "rj-master" - r.j., SSI is clock master +- fsl,mode: The operating mode for the AC97 interface only. "ac97-slave" - AC97 mode, SSI is clock slave "ac97-master" - AC97 mode, SSI is clock master
Signature · 1 line
1.9.1
Quoted 4 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
There is no need to use 'i2s-slave' property, since master/slave configuration are passed via machine layer.
Applied both, thanks.