Skip to contentSkip to conversation

ASoC: fsl: Do not force codecs selection by SND_SOC_FSL_ASOC_CARD

PATCH Applied Fabio Estevam 2 participants 2 messages Sep 30, 2014 – Oct 1, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: fsl: Do not force codecs selection by SND_SOC_FSL_ASOC_CARD

From: Fabio Estevam <[email protected]>

The wm8962 driver uses the input subsystem, but it is selected by SND_SOC_FSL_ASOC_CARD, which can be built with CONFIG_INPUT disabled, resulting in this link error:

ERROR: "input_event" [sound/soc/codecs/snd-soc-wm8962.ko] undefined!
ERROR: "input_register_device" [sound/soc/codecs/snd-soc-wm8962.ko] undefined!
ERROR: "devm_input_allocate_device" [sound/soc/codecs/snd-soc-wm8962.ko] undefined!

Do not force the selection of the codecs by SND_SOC_FSL_ASOC_CARD to avoid such problem.

---
 sound/soc/fsl/Kconfig | 3 ---
 1 file changed, 3 deletions(-)
sound/soc/fsl/Kconfig +0 -3
index 6164e78..081e406 100644
@@ -288,9 +288,6 @@ config SND_SOC_FSL_ASOC_CARD
 	select SND_SOC_FSL_ESAI
 	select SND_SOC_FSL_SAI
 	select SND_SOC_FSL_SSI
-	select SND_SOC_CS42XX8_I2C
-	select SND_SOC_SGTL5000
-	select SND_SOC_WM8962
 	help
 	 ALSA SoC Audio support with ASRC feature for Freescale SoCs that have
 	 ESAI/SAI/SSI and connect with external CODECs such as WM8962, CS42888
Signature · 1 line
1.9.1
maintainer Applied
#1 lore raw
Quoted 5 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

The wm8962 driver uses the input subsystem, but it is selected by SND_SOC_FSL_ASOC_CARD, which can be built with CONFIG_INPUT disabled, resulting in this link error:

Applied, thanks. The more important thing here is that this is supposed to be a generic driver with no dependency on any particular CODEC.