block: misplaced rq_complete tracepoint

PATCH In review Hannes Reinecke 3 participants 3 messages Oct 1, 2014 Block layer

Share & tools

Hannes Reinecke

author

2014-10-01 12:32 UTC #0 lore raw

PATCH 1/1 block: misplaced rq_complete tracepoint

The rq_complete tracepoint was never issued for empty requests, causing the resulting blktrace information to never show any completion for those request.

Signed-off-by Hannes Reinecke <[email protected]>

---
 block/blk-core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

block/blk-core.c +2 -2

index 3aff9f5..eb05abf 100644
@@ -2414,11 +2414,11 @@ bool blk_update_request(struct request *req, int error, unsigned int nr_bytes)
 {
 	int total_bytes;
 
+	trace_block_rq_complete(req->q, req, nr_bytes);
+
 	if (!req->bio)
 		return false;
 
-	trace_block_rq_complete(req->q, req, nr_bytes);
-
 	/*
 	 * For fs requests, rq is just carrier of independent bio's
 	 * and each partial completion should be handled separately.

Signature · 1 line

1.8.5.2

Tejun Heo

Acked-by on v1 1/1

2014-10-01 13:54 UTC #1 lore raw

Quoted 5 lines · Hannes Reinecke

The rq_complete tracepoint was never issued for empty requests, causing the resulting blktrace information to never show any completion for those request.
Signed-off-by Hannes Reinecke <[email protected]>

Acked-by Tejun Heo <[email protected]>

Thanks.

Signature · 1 line

tejun

Jens Axboe

maintainer

2014-10-01 14:18 UTC #2 lore raw

In reply to Hannes Reinecke

Quoted 3 lines · Hannes Reinecke

The rq_complete tracepoint was never issued for empty requests, causing the resulting blktrace information to never show any completion for those request.

Thanks Hannes, applied.

Signature · 1 line

Jens Axboe