Skip to contentSkip to conversation

USB: host: st: fix typo 'CONFIG_USB_EHCI_HCD_ST'

PATCH In review Paul Bolle 3 participants 4 messages Oct 3, 2014 – Oct 6, 2014 USB

lore
Share & tools
lore

Paul Bolle

author
#0 lore raw

PATCH 1/1 USB: host: st: fix typo 'CONFIG_USB_EHCI_HCD_ST'

Signed-off-by Paul Bolle <[email protected]>
Fixes 905e300e1043 ("USB: host: st: fix ehci/ohci driver selection")

---
drivers/usb/host/ehci-st.o actually builds (on x86_64. that is) so there's no _obvious_ reason not to fix this typo.

 drivers/usb/host/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/host/Makefile +1 -1
index 0336bb2c0e6f..3beda2655232 100644
@@ -38,7 +38,7 @@ obj-$(CONFIG_USB_EHCI_MXC)	+= ehci-mxc.o
 obj-$(CONFIG_USB_EHCI_HCD_OMAP)	+= ehci-omap.o
 obj-$(CONFIG_USB_EHCI_HCD_ORION)	+= ehci-orion.o
 obj-$(CONFIG_USB_EHCI_HCD_SPEAR)	+= ehci-spear.o
-obj-$(CONFIG_USB_EHCI_HCD_ST)	+= ehci-st.o
+obj-$(CONFIG_USB_EHCI_HCD_STI)	+= ehci-st.o
 obj-$(CONFIG_USB_EHCI_EXYNOS)	+= ehci-exynos.o
 obj-$(CONFIG_USB_EHCI_HCD_AT91) += ehci-atmel.o
 obj-$(CONFIG_USB_EHCI_MSM)	+= ehci-msm.o
Signature · 1 line
1.9.3
Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · On Friday 03 October 2014 10:21:44 Paul Bolle wrote:
Signed-off-by Paul Bolle <[email protected]>
Fixes 905e300e1043 ("USB: host: st: fix ehci/ohci driver selection")

---
drivers/usb/host/ehci-st.o actually builds (on x86_64. that is) so there's no _obvious_ reason not to fix this typo.

I was about to post the same fix, thanks a lot for addressing this. Sorry for my stupid mistake.

Acked-by Arnd Bergmann <[email protected]>
author
#2 lore raw
Quoted 1 line · Arnd Bergmann

I was about to post the same fix, thanks a lot for addressing this.

You're welcome. I just figured that sending a (second) message regarding this typo would have been about as much trouble as sending a one line patch, so I sent that patch.

Quoted 1 line

Sorry for my stupid mistake.

That typo was rather easy to make and hard to notice (make won't shout at you for using an unknown macro, etc). See the thread starting at
https://lkml.kernel.org/r/1411730854.7866.10.camel@x220 for what I've been doing lately to try to catch these type of things early (ie, in linux-next) and for how Valentin hopes to automate that properly.

Paul Bolle