Skip to contentSkip to conversation

Remove optional dependency on PLAT_S5P

PATCH In review Paul Bolle 3 participants 5 messages Oct 6, 2014 Media (V4L/DVB)

lore
Share & tools
lore

Paul Bolle

author
#0 lore raw

PATCH 3/4 Remove optional dependency on PLAT_S5P

Commit d78c16ccde96 ("ARM: SAMSUNG: Remove remaining legacy code") removed the Kconfig symbol PLAT_S5P. Remove an optional dependency on that symbol from this Kconfig file too.

Signed-off-by Paul Bolle <[email protected]>
---
 drivers/media/platform/s5p-tv/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/s5p-tv/Kconfig +1 -1
index a9d56f8936b4..3d11fea5cc92 100644
@@ -9,7 +9,7 @@
 config VIDEO_SAMSUNG_S5P_TV
 	bool "Samsung TV driver for S5P platform"
 	depends on PM_RUNTIME
-	depends on PLAT_S5P || ARCH_EXYNOS || COMPILE_TEST
+	depends on ARCH_EXYNOS || COMPILE_TEST
 	default n
 	---help---
 	  Say Y here to enable selecting the TV output devices for
Signature · 1 line
1.9.3
#1 lore raw

drivers/media/platform/s5p-tv/Kconfig line 15

Quoted 9 lines · On Monday 06 October 2014 11:10:26 Paul Bolle wrote:

config VIDEO_SAMSUNG_S5P_TV
bool "Samsung TV driver for S5P platform"
depends on PM_RUNTIME

drivers/media/platform/s5p-tv/Kconfig +1 -1
-       depends on PLAT_S5P || ARCH_EXYNOS || COMPILE_TEST
+       depends on ARCH_EXYNOS || COMPILE_TEST
        default n
        ---help---
          Say Y here to enable selecting the TV output devices for

I wonder if it should now allow being built for ARCH_S5PV210. Maybe it was a mistake to remove the PLAT_S5P symbol without changing the use here?

Does S5PV210 have this device?

Arnd

#2 lore raw
Quoted 11 lines · Arnd Bergmann

drivers/media/platform/s5p-tv/Kconfig line 15

Quoted 9 lines · On Monday 06 October 2014 11:10:26 Paul Bolle wrote:

config VIDEO_SAMSUNG_S5P_TV
bool "Samsung TV driver for S5P platform"
depends on PM_RUNTIME

drivers/media/platform/s5p-tv/Kconfig +1 -1
-       depends on PLAT_S5P || ARCH_EXYNOS || COMPILE_TEST
+       depends on ARCH_EXYNOS || COMPILE_TEST
        default n
        ---help---
          Say Y here to enable selecting the TV output devices for
Quoted 5 lines

I wonder if it should now allow being built for ARCH_S5PV210. Maybe it was a mistake to remove the PLAT_S5P symbol without changing the use here?

Does S5PV210 have this device?

Yes, it does. Indeed, in all patches in this series we should have replaced PLAT_S5P with ARCH_S5PV210.

--
Thanks,
Sylwester

author
#3 lore raw
Quoted 6 lines · Sylwester Nawrocki
Quoted 2 lines · Arnd Bergmann

Does S5PV210 have this device?

Yes, it does. Indeed, in all patches in this series we should have replaced PLAT_S5P with ARCH_S5PV210.

If somebody would actually do that, that would be great. I lost patience waiting for a patch that did that. So I submitted these cleanup patches that basically change nothing.

Paul Bolle

author
#4 lore raw
In reply to Arnd Bergmann
Quoted 11 lines · Arnd Bergmann

drivers/media/platform/s5p-tv/Kconfig line 15

Quoted 9 lines · On Monday 06 October 2014 11:10:26 Paul Bolle wrote:

config VIDEO_SAMSUNG_S5P_TV
bool "Samsung TV driver for S5P platform"
depends on PM_RUNTIME

drivers/media/platform/s5p-tv/Kconfig +1 -1
-       depends on PLAT_S5P || ARCH_EXYNOS || COMPILE_TEST
+       depends on ARCH_EXYNOS || COMPILE_TEST
        default n
        ---help---
          Say Y here to enable selecting the TV output devices for
Quoted 1 line

I wonder if it should now allow being built for ARCH_S5PV210.

That was what Tomasz Figa claimed in
http://lkml.kernel.org/r/53C676DB.6070002 at samsung.com

Quoted 2 lines

Maybe it was a mistake to remove the PLAT_S5P symbol without changing the use here?

At least it was a bit sloppy to remove the symbol without touching this (and six other) dependencies. But after nearly three months I lost patience waiting for a fix to be submitted.

My cleanup doesn't really change a thing. And a proper fix, if needed, is still possible after this has landed.

Quoted 1 line

Does S5PV210 have this device?

Paul Bolle