Skip to contentSkip to conversation

linuxdoc-tools-native: Makedoc.sh uses /tmp and fails w/ noexec mount

PATCH In review Mark Hatle 1 participant 2 messages Oct 6, 2014

lore
Share & tools
lore

Mark Hatle

author
#0 lore raw

PATCH v3 1/1 linuxdoc-tools-native: Makedoc.sh uses /tmp and fails w/ noexec mount

From: Konrad Scherer <[email protected]>

The Makedoc.sh script uses the following line to set TMPDIR

export TMPDIR=mktemp -d ${TMPDIR:-/tmp}/ldt.XXXXXXXXXX;

and then later in the script:

chmod u+x $TMPDIR/linuxdoc

Since TMPDIR is not set the script will default to /tmp and if /tmp is set to noexec (which is becoming more common), the chmod call fails.

---
 meta/recipes-devtools/linuxdoc-tools/linuxdoc-tools-native_0.9.69.bb | 4 ++++
 1 file changed, 4 insertions(+)
meta/recipes-devtools/linuxdoc-tools/linuxdoc-tools-native_0.9.69.bb +4 -0
index ed6ab73..a8a90fc 100644
@@ -19,3 +19,7 @@ inherit autotools-brokensep native
 do_configure () {
 	oe_runconf
 }
+
+do_install() {
+	oe_runmake 'DESTDIR=${D}' 'TMPDIR=${T}' install
+}
Signature · 1 line
1.9.3
author
#1 lore raw

V3 - Only difference to V2 is the summary line of the commit message. After sending it I realized it wasn't in the right OE format.

V2 - Only difference is adding back in the missing DESTDIR=

Quoted 32 lines · Mark Hatle

From: Konrad Scherer <[email protected]>

The Makedoc.sh script uses the following line to set TMPDIR

export TMPDIR=mktemp -d ${TMPDIR:-/tmp}/ldt.XXXXXXXXXX;

and then later in the script:

chmod u+x $TMPDIR/linuxdoc

Since TMPDIR is not set the script will default to /tmp and if /tmp is set to noexec (which is becoming more common), the chmod call fails.

---
  meta/recipes-devtools/linuxdoc-tools/linuxdoc-tools-native_0.9.69.bb | 4 ++++
  1 file changed, 4 insertions(+)
meta/recipes-devtools/linuxdoc-tools/linuxdoc-tools-native_0.9.69.bb +4 -0
index ed6ab73..a8a90fc 100644
@@ -19,3 +19,7 @@ inherit autotools-brokensep native
  do_configure () {
  	oe_runconf
  }
+
+do_install() {
+	oe_runmake 'DESTDIR=${D}' 'TMPDIR=${T}' install
+}