ipmi: various collected bug fixes
cover ipmi: various collected bug fixes
These have been in linux-next for a while, ready for 3.18.
Thanks,
-corey
PATCH 1/4 ipmi: Clean up the error handling for channel config errors
From: Corey Minyard <[email protected]>
The code to send the channel config errors was missing an error report in one place and needed some more information in another, and had an extraneous bit of code. Clean all that up.
--- drivers/char/ipmi/ipmi_msghandler.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-)
drivers/char/ipmi/ipmi_msghandler.c +9 -6
@@ -2796,7 +2796,6 @@ channel_handler(ipmi_smi_t intf, struct ipmi_recv_msg *msg) = IPMI_CHANNEL_MEDIUM_IPMB; intf->channels[0 ].protocol =IPMI_CHANNEL_PROTOCOL_IPMB ; - rv = -ENOSYS ; intf->curr_channel =IPMI_MAX_CHANNELS ;wake_up (&intf->waitq);
@@ -2821,12 +2820,12 @@ channel_handler(ipmi_smi_t intf, struct ipmi_recv_msg *msg)if (rv) {/* Got an error somehow, just give up. */ + printk(KERN_WARNING PFX +"Error sending channel information for channel" + " %d: %d\n", intf->curr_channel, rv); + intf->curr_channel =IPMI_MAX_CHANNELS ;wake_up (&intf->waitq); - - printk(KERN_WARNING PFX -"Error sending channel information: %d\n" , - rv); } } out:
@@ -2964,8 +2963,12 @@ int ipmi_register_smi(struct ipmi_smi_handlers *handlers, intf->null_user_handler = channel_handler; intf->curr_channel =0 ; rv =send_channel_info_cmd (intf,0 ); -if (rv) +if (rv) { + printk(KERN_WARNING PFX +"Error sending channel information for channel" + " 0, %d\n", rv); goto out; + }/* Wait for the channel info to be read. */ wait_event(intf->waitq,
Signature · 1 line
1.8.3.1
PATCH 2/4 ipmi/of: Don't use unavailable interfaces
In reply to [email protected]From: Benjamin Herrenschmidt <[email protected]>
If an IPMI controller is used by the firmware and as such marked with a reserved status, we shouldn't use it.
--- drivers/char/ipmi/ipmi_si_intf.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/char/ipmi/ipmi_si_intf.c +3 -0
@@ -2658,6 +2658,9 @@ static int ipmi_probe(struct platform_device *dev)if (!match)return -EINVAL ; +if (!of_device_is_available (np)) +return -EINVAL ; + ret =of_address_to_resource (np,0 , &resource);if (ret) {dev_warn (&dev->dev,PFX "invalid address from OF\n" );
Signature · 1 line
1.8.3.1
PATCH 3/4 ipmi: work around gcc-4.9 build warning
In reply to [email protected]From: Arnd Bergmann <[email protected]>
Building ipmi on arm with gcc-4.9 results in this warning for an allmodconfig build:
drivers/char/ipmi/ipmi_si_intf.c: In function 'ipmi_thread':include/linux/time.h:28:5: warning: 'busy_until.tv_sec' may be used uninitialized in this function [-Wmaybe-uninitialized]
if (lhs->tv_sec > rhs->tv_sec)
^
drivers/char/ipmi/ipmi_si_intf.c:1007:18: note: 'busy_until.tv_sec' was declared here
struct timespec busy_until;
^The warning is bogus and this case can not occur. Apparently this is a false positive resulting from gcc getting a little smarter about tracking assignments but not smart enough. Marking the ipmi_thread_busy_wait function as inline gives the gcc optimization logic enough information to figure out for itself that the case cannot happen, which gets rid of the warning without adding any fake initialization.
--- drivers/char/ipmi/ipmi_si_intf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/char/ipmi/ipmi_si_intf.c +3 -3
@@ -965,9 +965,9 @@ static inline int ipmi_si_is_busy(struct timespec *ts)return ts->tv_nsec !=-1 ; } -static int ipmi_thread_busy_wait (enum si_sm_result smi_result, -const struct smi_info *smi_info, -struct timespec *busy_until) +static inline int ipmi_thread_busy_wait (enum si_sm_result smi_result, +const struct smi_info *smi_info, +struct timespec *busy_until) {unsigned int max_busy_us =0 ;
Signature · 1 line
1.8.3.1
PATCH 4/4 ipmi: Clear drvdata when interface is removed
In reply to [email protected]From: Takao Indoh <[email protected]>
This patch fixes a bug on hotmod removing.
After ipmi interface is removed using hotmod, kernel panic occurs when rmmod impi_si. For example, try this:
# echo "remove,"`cat /proc/ipmi/0/params` > \ /sys/module/ipmi_si/parameters/hotmod # rmmod ipmi_si
Then, rmmod fails with the following messages.
------------[ cut here ]------------ WARNING: CPU: 12 PID: 10819 at /mnt/repos/linux/lib/list_debug.c:53 __list_del_entry+0x63/0xd0() (snip) CPU: 12 PID: 10819 Comm: rmmod Not tainted 3.17.0-rc1 #19 Hardware name: FUJITSU-SV PRIMERGY BX920 S2/D3030, BIOS 080015
Rev.3D81.3030 02/10/2012
0000000000000009 ffff88022d547d40 ffffffff81575778 ffff88022d547d88 ffff88022d547d78 ffffffff8104ec5d ffff88023908cdb0 ffffffffa06fa4e0 ffff8800bac20860 0000000000000000 0000000002046090 ffff88022d547dd8
Call Trace: [<ffffffff81575778>] dump_stack+0x45/0x56 [<ffffffff8104ec5d>] warn_slowpath_common+0x7d/0xa0 [<ffffffff8104eccc>] warn_slowpath_fmt+0x4c/0x50 [<ffffffff811f60bf>] ? __kernfs_remove+0xdf/0x220 [<ffffffff81291213>] __list_del_entry+0x63/0xd0 [<ffffffff8129128d>] list_del+0xd/0x30 [<ffffffffa06f285a>] cleanup_one_si+0x2a/0x230 [ipmi_si] [<ffffffffa06f2f05>] ipmi_pnp_remove+0x15/0x20 [ipmi_si] [<ffffffff8131c7d4>] pnp_device_remove+0x24/0x40 [<ffffffff8137175f>] __device_release_driver+0x7f/0xf0 [<ffffffff81372100>] driver_detach+0xb0/0xc0 [<ffffffff81371415>] bus_remove_driver+0x55/0xd0 [<ffffffff8137283c>] driver_unregister+0x2c/0x50 [<ffffffff8131ca02>] pnp_unregister_driver+0x12/0x20 [<ffffffffa06f347c>] cleanup_ipmi_si+0xbc/0xf0 [ipmi_si] [<ffffffff810c33f2>] SyS_delete_module+0x132/0x1c0 [<ffffffff81002ab9>] ? do_notify_resume+0x59/0x80 [<ffffffff8157c45a>] ? int_signal+0x12/0x17 [<ffffffff8157c1d2>] system_call_fastpath+0x16/0x1b ---[ end trace 70b4377268f85c23 ]---
list_del in cleanup_one_si() fails because the smi_info is already removed when hotmod removing.
When ipmi interface is removed by hotmod, smi_info is removed by cleanup_one_si(), but is is still set in drvdata. Therefore when rmmod ipmi_si, ipmi_pnp_remove tries to remove it again and fails.
By this patch, a pointer to smi_info in drvdata is cleared when hotmod removing so that it will be not accessed when rmmod.
changelog:
v2:
- Clear drvdata in cleanup_one_si
- Change subject
v1:
https://lkml.org/lkml/2014/9/8/741
--- drivers/char/ipmi/ipmi_si_intf.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/char/ipmi/ipmi_si_intf.c +3 -0
@@ -3658,6 +3658,9 @@ static void cleanup_one_si(struct smi_info *to_clean)if (!to_clean)return ; +if (to_clean->dev) +dev_set_drvdata (to_clean->dev,NULL ); +list_del (&to_clean->link);/* Tell the driver that we are shutting down. */
Signature · 1 line
1.8.3.1