Skip to contentSkip to conversation

regulator: sky81452: Remove module version

PATCH Applied Axel Lin 3 participants 3 messages Oct 8, 2014 Voltage and current regulator framework

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 regulator: sky81452: Remove module version

The module version is unlikely to be updated, use kernel version should be enough.

Signed-off-by Axel Lin <[email protected]>

---
Hi Gyungoh,
Seems you have added MODULE_VERSION for the sky81452 serial patches. Do you really need that and will keep updating it?
Otherwise, you may want to drop the MODULE_VERSION in sky81452 serial patches.

 drivers/regulator/sky81452-regulator.c | 1 -
 1 file changed, 1 deletion(-)
drivers/regulator/sky81452-regulator.c +0 -1
index 97aff0c..476b80a 100644
@@ -127,4 +127,3 @@ module_platform_driver(sky81452_reg_driver);
 MODULE_DESCRIPTION("Skyworks SKY81452 Regulator driver");
 MODULE_AUTHOR("Gyungoh Yoo <[email protected]>");
 MODULE_LICENSE("GPL");
-MODULE_VERSION("1.0");
Signature · 1 line
1.9.1
#1 lore raw
Quoted 9 lines · Axel Lin

The module version is unlikely to be updated, use kernel version should be enough.

Signed-off-by Axel Lin <[email protected]>

---
Hi Gyungoh,
Seems you have added MODULE_VERSION for the sky81452 serial patches. Do you really need that and will keep updating it?
Otherwise, you may want to drop the MODULE_VERSION in sky81452 serial patches.

I see.
I will remove MODULE_VERSION and resumit.
Thank you.

Quoted 18 lines
 drivers/regulator/sky81452-regulator.c | 1 -
 1 file changed, 1 deletion(-)
drivers/regulator/sky81452-regulator.c +0 -1
index 97aff0c..476b80a 100644
@@ -127,4 +127,3 @@ module_platform_driver(sky81452_reg_driver);
 MODULE_DESCRIPTION("Skyworks SKY81452 Regulator driver");
 MODULE_AUTHOR("Gyungoh Yoo <[email protected]>");
 MODULE_LICENSE("GPL");
-MODULE_VERSION("1.0");
Signature · 1 line
1.9.1
maintainer Applied
#2 lore raw
In reply to Axel Lin
Quoted 2 lines · Axel Lin

The module version is unlikely to be updated, use kernel version should be enough.

Applied, thanks.