Skip to contentSkip to conversation

fetcher: fix BB_STRICT_CHECKSUM datatype check

PATCH In review Alejandro Hernandez 2 participants 2 messages Oct 10, 2014

lore
Share & tools
lore

Alejandro Hernandez

author
#0 lore raw

PATCH v3 1/1 fetcher: fix BB_STRICT_CHECKSUM datatype check

Forcing strict to be a string, to avoid problems when performing comparisons

[YOCTO #6762]

Signed-off-by Alejandro Hernandez <[email protected]>
---
 lib/bb/fetch2/__init__.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/bb/fetch2/__init__.py +1 -1
index 10c3346..5341ebf 100644
@@ -543,7 +543,7 @@ def verify_checksum(ud, d):
 
     if ud.method.recommends_checksum(ud):
         # If strict checking enabled and neither sum defined, raise error
-        strict = d.getVar("BB_STRICT_CHECKSUM", "1") or "0"
+        strict = d.getVar("BB_STRICT_CHECKSUM", True) or "0"
         if (strict == "1") and not (ud.md5_expected or ud.sha256_expected):
             logger.error('No checksum specified for %s, please add at least one to the recipe:\n'
                              'SRC_URI[%s] = "%s"\nSRC_URI[%s] = "%s"' %
Signature · 1 line
1.9.1
#1 lore raw
Quoted 7 lines · Alejandro Hernandez

Forcing strict to be a string, to avoid problems when performing comparisons

[YOCTO #6762]

Signed-off-by Alejandro Hernandez <[email protected]>

This commit message doesn't reflect what this commit does. It's fixing the call to getVar, not changing whether strict is a string or not.

Signature · 5 lines
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics