Skip to contentSkip to conversation

mesa3d xa option cleanup

PATCH New lf 3 participants 5 messages Oct 11, 2014 – Jan 17, 2015

lore
Share & tools
lore

lf

author
#0 lore raw

PATCH 1/2 mesa3d xa option cleanup

---
 package/mesa3d/Config.in | 5 +++++
 package/mesa3d/mesa3d.mk | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)
package/mesa3d/Config.in +5 -0
index 74ebbed..1bd92ea 100644
@@ -43,6 +43,7 @@ config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_NOUVEAU
 	depends on BR2_i386 || BR2_x86_64
 	select BR2_PACKAGE_MESA3D_GALLIUM_DRIVER
 	select BR2_PACKAGE_LIBDRM_NOUVEAU
+	select BR2_PACKAGE_MESA3D_NEEDS_XA
 	help
 	  Supports all Nvidia GPUs.
 
@@ -51,6 +52,7 @@ config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_SVGA
 	depends on BR2_i386 || BR2_x86_64
 	select BR2_PACKAGE_MESA3D_GALLIUM_DRIVER
 	select BR2_PACKAGE_LIBDRM_VMWGFX
+	select BR2_PACKAGE_MESA3D_NEEDS_XA
 	help
 	  This is a virtual GPU driver for VMWare virtual machines.
 
@@ -61,6 +63,9 @@ config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_SWRAST
 	  This is a software opengl implementation using the Gallium3D
 	  infrastructure.
 
+config BR2_PACKAGE_MESA3D_NEEDS_XA
+	bool
+
 comment "DRI drivers needs X.Org and a toolchain w/ dynamic library"
 	depends on BR2_PREFER_STATIC_LIB || !BR2_PACKAGE_XORG7
 
package/mesa3d/mesa3d.mk +1 -1
index 844884b..8fbd72c 100644
@@ -36,7 +36,7 @@ MESA3D_DEPENDENCIES += \
 	libxcb
 MESA3D_CONF_OPTS += --enable-glx
 # quote from mesa3d configure "Building xa requires at least one non swrast gallium driver."
-ifneq ($(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_NOUVEAU)$(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_SVGA),)
+ifneq ($(BR2_PACKAGE_MESA3D_NEEDS_XA),)
 MESA3D_CONF_OPTS += --enable-xa
 else
 MESA3D_CONF_OPTS += --disable-xa
Signature · 1 line
1.9.1
author
#1 lore raw

PATCH 2/2 mesa3d add option for Radeon r300/r600/radeonsi gallium drivers

---
 package/mesa3d/Config.in | 27 +++++++++++++++++++++++++++
 package/mesa3d/mesa3d.mk |  3 +++
 2 files changed, 30 insertions(+)
package/mesa3d/Config.in +27 -0
index 1bd92ea..f149a68 100644
@@ -47,6 +47,33 @@ config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_NOUVEAU
 	help
 	  Supports all Nvidia GPUs.
 
+config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_R300
+	bool "Gallium Radeon R300 driver"
+	depends on BR2_i386 || BR2_x86_64
+	select BR2_PACKAGE_MESA3D_GALLIUM_DRIVER
+	select BR2_PACKAGE_LIBDRM_RADEON
+	select BR2_PACKAGE_MESA3D_NEEDS_XA
+	help
+	  Driver for ATI/AMD Radeon R300/R400/R500 GPUs.
+
+config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_R600
+	bool "Gallium Radeon R600 driver"
+	depends on BR2_i386 || BR2_x86_64
+	select BR2_PACKAGE_MESA3D_GALLIUM_DRIVER
+	select BR2_PACKAGE_LIBDRM_RADEON
+	select BR2_PACKAGE_MESA3D_NEEDS_XA
+	help
+	  Driver for ATI/AMD Radeon R600/R700/HD5000/HD6000 GPUs.
+
+config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_RADEONSI
+	bool "Gallium Radeon SI driver"
+	depends on BR2_i386 || BR2_x86_64
+	select BR2_PACKAGE_MESA3D_GALLIUM_DRIVER
+	select BR2_PACKAGE_LIBDRM_RADEON
+	select BR2_PACKAGE_MESA3D_NEEDS_XA
+	help
+	  Driver for ATI/AMD Radeon HD7000/HD8000/Rx200 GPUs.
+
 config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_SVGA
 	bool "Gallium vmware svga driver"
 	depends on BR2_i386 || BR2_x86_64
package/mesa3d/mesa3d.mk +3 -0
index 8fbd72c..76cfe7a 100644
@@ -56,6 +56,9 @@ endif
 
 #Gallium Drivers
 MESA3D_GALLIUM_DRIVERS-$(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_NOUVEAU)  += nouveau
+MESA3D_GALLIUM_DRIVERS-$(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_R300)     += r300
+MESA3D_GALLIUM_DRIVERS-$(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_R600)     += r600
+MESA3D_GALLIUM_DRIVERS-$(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_RADEONSI) += radeonsi
 MESA3D_GALLIUM_DRIVERS-$(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_SVGA)     += svga
 MESA3D_GALLIUM_DRIVERS-$(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_SWRAST)   += swrast
 # DRI Drivers
Signature · 1 line
1.9.1
#2 lore raw

PATCH 2/2 mesa3d add option for Radeon r300/r600/radeonsi gallium drivers

lf <[email protected]> wrote in news:1413040999-3426-2-git-send-email-micro1183 at gmail.com:

Quoted 2 lines

+MESA3D_GALLIUM_DRIVERS-$(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_R300) +=
r300

[...]

Quoted 2 lines

+MESA3D_GALLIUM_DRIVERS-$(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_RADEONSI) += radeonsi

Hi,

this will not work because buildroot does not contain llvm:

Quote from mesa3d configure log:

checking for RADEON... yes
configure: error: LLVM is required to build Gallium R300 on x86 and x86_64 [...]
configure: error: LLVM 3.4.2 or newer is required for radeonsi

From your patch only the r600 gallium driver can be built using buildroot.

Regards, Bernd

#3 lore raw

PATCH 1/2 mesa3d xa option cleanup

In reply to lf

Hello,

This patch needs a description. Also, we do not accept patches contributed by persons only identified by pseudonyms, so please use your full name to sign off the patch.

The title of the patch should also have "<package>:" as the prefix, so:

mesa3d: cleanup the handling of the XA option

Quoted 5 lines · lf
---
 package/mesa3d/Config.in | 5 +++++
 package/mesa3d/mesa3d.mk | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#4 lore raw

PATCH 1/2 mesa3d xa option cleanup

Hello,

Do you intend to resubmit an updated version of your two patches:

http://patchwork.ozlabs.org/patch/398857/
http://patchwork.ozlabs.org/patch/398858/

We are waiting for those updated versions (with a better commit log + Signed-off-by line with a real name) to commit your patches.

Thanks a lot!

Thomas

Quoted 20 lines · Thomas Petazzoni

Hello,

This patch needs a description. Also, we do not accept patches contributed by persons only identified by pseudonyms, so please use your full name to sign off the patch.

The title of the patch should also have "<package>:" as the prefix, so:

mesa3d: cleanup the handling of the XA option

Quoted 5 lines · lf
---
 package/mesa3d/Config.in | 5 +++++
 package/mesa3d/mesa3d.mk | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com