Lustre: remove old compat code
cover Lustre: remove old compat code
These three patches remove support for code that is no longer needed. Mostly ability to talk to old version of lustre clients and servers.
Oleg Drokin (3):
staging/lustre/ptlrpc: get rid of lustre 1.8 compatible checksums staging/lustre: get rid of deprecaed acl mount option code staging/lustre/quota: Get rid of compat quota code
drivers/staging/lustre/lustre/include/lustre_net.h | 5 -- drivers/staging/lustre/lustre/llite/dir.c | 58 ---------------------- .../staging/lustre/lustre/llite/llite_internal.h | 18 ------- drivers/staging/lustre/lustre/llite/llite_lib.c | 19 ------- .../staging/lustre/lustre/ptlrpc/pack_generic.c | 26 ---------- drivers/staging/lustre/lustre/ptlrpc/sec_null.c | 18 ------- 6 files changed, 144 deletions(-)
Signature · 1 line
1.9.3
PATCH 1/3 staging/lustre/ptlrpc: get rid of lustre 1.8 compatible checksums
Old version of lustre (1.8) calculated RPC checksums differently, but the compat code is no longer important since in-kernel version of lustre is nto compatible with 1.8 lustre servers (that are long deprecated too).
--- drivers/staging/lustre/lustre/include/lustre_net.h | 5 ----- .../staging/lustre/lustre/ptlrpc/pack_generic.c | 26 ---------------------- drivers/staging/lustre/lustre/ptlrpc/sec_null.c | 18 --------------- 3 files changed, 49 deletions(-)
drivers/staging/lustre/lustre/include/lustre_net.h +0 -5
@@ -2627,12 +2627,7 @@ __u32 lustre_msg_get_timeout(struct lustre_msg *msg);__u32 lustre_msg_get_service_time (struct lustre_msg *msg);char *lustre_msg_get_jobid (struct lustre_msg *msg);__u32 lustre_msg_get_cksum (struct lustre_msg *msg); -#if LUSTRE_VERSION_CODE <OBD_OCD_VERSION (2 ,7 ,50 ,0 ) -__u32 lustre_msg_calc_cksum (struct lustre_msg *msg,int compat18); -#else -# warning "remove checksum compatibility support for b1_8"__u32 lustre_msg_calc_cksum (struct lustre_msg *msg); -#endif void lustre_msg_set_handle (struct lustre_msg *msg,struct lustre_handle *handle);void lustre_msg_set_type (struct lustre_msg *msg,__u32 type);
drivers/staging/lustre/lustre/ptlrpc/pack_generic.c +0 -26
@@ -1313,43 +1313,17 @@ __u32 lustre_msg_get_cksum(struct lustre_msg *msg) } } -#if LUSTRE_VERSION_CODE <OBD_OCD_VERSION (2 ,7 ,50 ,0 ) -/* -* In 1.6 and 1.8 the checksum was computed only on struct ptlrpc_body as -* it was in 1.6 (88 bytes, smaller than the full size in 1.8). It makes -* more sense to compute the checksum on the full ptlrpc_body, regardless -* of what size it is, but in order to keep interoperability with 1.8 we -* can optionally also checksum only the first 88 bytes (caller decides). */ -# define ptlrpc_body_cksum_size_compat18 88 - -__u32 lustre_msg_calc_cksum(struct lustre_msg *msg, int compat18) -#else -# warning "remove checksum compatibility support for b1_8"__u32 lustre_msg_calc_cksum (struct lustre_msg *msg) -#endif {switch (msg->lm_magic) {case LUSTRE_MSG_MAGIC_V2 : {struct ptlrpc_body *pb =lustre_msg_ptlrpc_body (msg); -#if LUSTRE_VERSION_CODE <OBD_OCD_VERSION (2 ,7 ,50 ,0 ) -__u32 crc; -unsigned int hsize =4 ; -__u32 len = compat18 ? ptlrpc_body_cksum_size_compat18 : -lustre_msg_buflen (msg,MSG_PTLRPC_BODY_OFF ); -LASSERTF (pb,"invalid msg %p: no ptlrpc body!\n" , msg); -cfs_crypto_hash_digest (CFS_HASH_ALG_CRC32 , (unsigned char *)pb, - len,NULL ,0 , (unsigned char *)&crc, - &hsize); -return crc; -#else -# warning "remove checksum compatibility support for b1_8"__u32 crc;unsigned int hsize =4 ;cfs_crypto_hash_digest (CFS_HASH_ALG_CRC32 , (unsigned char *)pb,lustre_msg_buflen (msg,MSG_PTLRPC_BODY_OFF ),NULL ,0 , (unsigned char *)&crc, &hsize);return crc; -#endif }default :CERROR ("incorrect message magic: %08x\n" , msg->lm_magic);
drivers/staging/lustre/lustre/ptlrpc/sec_null.c +0 -18
@@ -101,16 +101,7 @@ int null_ctx_verify(struct ptlrpc_cli_ctx *ctx, struct ptlrpc_request *req)if (req->rq_early) { cksums =lustre_msg_get_cksum (req->rq_repdata); -#if LUSTRE_VERSION_CODE <OBD_OCD_VERSION (2 ,7 ,50 ,0 ) -if (lustre_msghdr_get_flags (req->rq_reqmsg) & -MSGHDR_CKSUM_INCOMPAT18 ) - cksumc =lustre_msg_calc_cksum (req->rq_repmsg,0 ); -else - cksumc =lustre_msg_calc_cksum (req->rq_repmsg,1 ); -#else -# warning "remove checksum compatibility support for b1_8" cksumc =lustre_msg_calc_cksum (req->rq_repmsg); -#endif if (cksumc != cksums) { CDEBUG(D_SEC, "early reply checksum mismatch: %08x != %08x\n",
@@ -371,16 +362,7 @@ int null_authorize(struct ptlrpc_request *req) }else {__u32 cksum; -#if LUSTRE_VERSION_CODE <OBD_OCD_VERSION (2 ,7 ,50 ,0 ) -if (lustre_msghdr_get_flags (req->rq_reqmsg) & -MSGHDR_CKSUM_INCOMPAT18 ) - cksum =lustre_msg_calc_cksum (rs->rs_repbuf,0 ); -else - cksum =lustre_msg_calc_cksum (rs->rs_repbuf,1 ); -#else -# warning "remove checksum compatibility support for b1_8" cksum =lustre_msg_calc_cksum (rs->rs_repbuf); -#endif lustre_msg_set_cksum (rs->rs_repbuf, cksum); req->rq_reply_off =0 ; }
Signature · 1 line
1.9.3
PATCH 2/3 staging/lustre: get rid of deprecaed acl mount option code
In reply to Oleg DrokinThis is long since unused code, so get rid of it.
--- drivers/staging/lustre/lustre/llite/llite_lib.c | 19 ------------------- 1 file changed, 19 deletions(-)
drivers/staging/lustre/lustre/llite/llite_lib.c +0 -19
@@ -816,25 +816,6 @@ static int ll_options(char *options, int *flags) *flags &= ~tmp; goto next; } -#if LUSTRE_VERSION_CODE <OBD_OCD_VERSION (2 ,5 ,50 ,0 ) - tmp =ll_set_opt ("acl" , s1,LL_SBI_ACL ); -if (tmp) { -/* Ignore deprecated mount option. The client will -* always try to mount with ACL support, whether this -* is used depends on whether server supports it. */ -LCONSOLE_ERROR_MSG (0x152 ,"Ignoring deprecated " -"mount option 'acl'.\n" ); - goto next; - } - tmp =ll_set_opt ("noacl" , s1,LL_SBI_ACL ); -if (tmp) { -LCONSOLE_ERROR_MSG (0x152 ,"Ignoring deprecated " -"mount option 'noacl'.\n" ); - goto next; - } -#else -#warning "{no}acl options have been deprecated since 1.8, please remove them" -#endif tmp =ll_set_opt ("remote_client" , s1,LL_SBI_RMT_CLIENT );if (tmp) { *flags |= tmp;
Signature · 1 line
1.9.3
PATCH 3/3 staging/lustre/quota: Get rid of compat quota code
In reply to Oleg DrokinNobody should be using any fo the old lustre 1.8 era tools anymore, so drop compatibility with those.
--- drivers/staging/lustre/lustre/llite/dir.c | 58 ---------------------- .../staging/lustre/lustre/llite/llite_internal.h | 18 ------- 2 files changed, 76 deletions(-)
drivers/staging/lustre/lustre/llite/dir.c +0 -58
@@ -1694,64 +1694,6 @@ out_poll:OBD_FREE_PTR (check);return rc; } -#if LUSTRE_VERSION_CODE <OBD_OCD_VERSION (2 ,7 ,50 ,0 ) -case LL_IOC_QUOTACTL_18 : { -/* copy the old 1.x quota struct for internal use, then copy -* back into old format struct. For 1.8 compatibility. */ -struct if_quotactl_18 *qctl_18; -struct if_quotactl *qctl_20; - - qctl_18 =kzalloc (sizeof (*qctl_18),GFP_NOFS ); -if (!qctl_18) -return -ENOMEM ; - - qctl_20 =kzalloc (sizeof (*qctl_20),GFP_NOFS ); -if (!qctl_20) { - rc = -ENOMEM ; - goto out_quotactl_18; - } - -if (copy_from_user (qctl_18, (void *)arg,sizeof (*qctl_18))) { - rc = -ENOMEM ; - goto out_quotactl_20; - } - -QCTL_COPY (qctl_20, qctl_18); - qctl_20->qc_idx =0 ; - -/* XXX: dqb_valid was borrowed as a flag to mark that -* only mds quota is wanted */ -if (qctl_18->qc_cmd ==Q_GETQUOTA && - qctl_18->qc_dqblk.dqb_valid) { - qctl_20->qc_valid =QC_MDTIDX ; - qctl_20->qc_dqblk.dqb_valid =0 ; - }else if (qctl_18->obd_uuid.uuid[0 ] !='\0' ) { - qctl_20->qc_valid =QC_UUID ; - qctl_20->obd_uuid = qctl_18->obd_uuid; - }else { - qctl_20->qc_valid =QC_GENERAL ; - } - - rc =quotactl_ioctl (sbi, qctl_20); - -if (rc ==0 ) { -QCTL_COPY (qctl_18, qctl_20); - qctl_18->obd_uuid = qctl_20->obd_uuid; - -if (copy_to_user ((void *)arg, qctl_18, -sizeof (*qctl_18))) - rc = -EFAULT ; - } - -out_quotactl_20: -OBD_FREE_PTR (qctl_20); -out_quotactl_18: -OBD_FREE_PTR (qctl_18); -return rc; - } -#else -#warning "remove old LL_IOC_QUOTACTL_18 compatibility code" -#endif /* LUSTRE_VERSION_CODE < OBD_OCD_VERSION(2, 7, 50, 0) */ case LL_IOC_QUOTACTL : {struct if_quotactl *qctl;
drivers/staging/lustre/lustre/llite/llite_internal.h +0 -18
@@ -1509,24 +1509,6 @@ static inline void d_lustre_revalidate(struct dentry *dentry)spin_unlock (&dentry->d_lock); } -#if LUSTRE_VERSION_CODE <OBD_OCD_VERSION (2 ,7 ,50 ,0 ) -/* Compatibility for old (1.8) compiled userspace quota code */ -struct if_quotactl_18 { -__u32 qc_cmd; -__u32 qc_type; -__u32 qc_id; -__u32 qc_stat; -struct obd_dqinfo qc_dqinfo; -struct obd_dqblk qc_dqblk; -char obd_type[16 ]; -struct obd_uuid obd_uuid; -}; -#define LL_IOC_QUOTACTL_18 _IOWR('f', 162, struct if_quotactl_18 *) -/* End compatibility for old (1.8) compiled userspace quota code */ -#else -#warning "remove old LL_IOC_QUOTACTL_18 compatibility code" -#endif /* LUSTRE_VERSION_CODE < OBD_OCD_VERSION(2, 7, 50, 0) */ -enum {LL_LAYOUT_GEN_NONE = ((__u32)-2 ),/* layout lock was cancelled */ LL_LAYOUT_GEN_EMPTY = ((__u32)-1 )/* for empty layout */
Signature · 1 line
1.9.3