Skip to contentSkip to conversation

arch/x86/purgatory/Makefile: supress kexec-purgatory.c is up to date message

PATCH In review WANG Chao 4 participants 6 messages Oct 14, 2014 – Oct 15, 2014 x86

lore
Share & tools
lore

WANG Chao

author
#0 lore raw

PATCH 1/1 arch/x86/purgatory/Makefile: supress kexec-purgatory.c is up to date message

Supress this unnecessary message during kernel re-build (CONFIG_KEXEC_FILE=y):

make[1]: `arch/x86/purgatory/kexec-purgatory.c' is up to date.

---
 arch/x86/purgatory/Makefile | 1 +
 1 file changed, 1 insertion(+)
arch/x86/purgatory/Makefile +1 -0
index f52e033..2c835e3 100644
@@ -24,6 +24,7 @@ quiet_cmd_bin2c = BIN2C   $@
 
 $(obj)/kexec-purgatory.c: $(obj)/purgatory.ro FORCE
 	$(call if_changed,bin2c)
+	@:
 
 
 obj-$(CONFIG_KEXEC_FILE)	+= kexec-purgatory.o
Signature · 1 line
1.9.3
#2 lore raw
In reply to WANG Chao
Quoted 15 lines · WANG Chao

Supress this unnecessary message during kernel re-build (CONFIG_KEXEC_FILE=y):

make[1]: `arch/x86/purgatory/kexec-purgatory.c' is up to date.

---
 arch/x86/purgatory/Makefile | 1 +
 1 file changed, 1 insertion(+)
arch/x86/purgatory/Makefile +0 -0
index f52e033..2c835e3 100644

arch/x86/purgatory/Makefile quiet_cmd_bin2c = BIN2C $@ · line 27

Quoted 4 lines
arch/x86/purgatory/Makefile +1 -0
@@ -24,6 +24,7 @@ quiet_cmd_bin2c = BIN2C   $@
 
 $(obj)/kexec-purgatory.c: $(obj)/purgatory.ro FORCE
 	$(call if_changed,bin2c)
+	@:

Where can I find the description of "@:" and how does it work?

Thanks
Vivek

author
#3 lore raw
Quoted 17 lines · Vivek Goyal
Quoted 16 lines · WANG Chao

Supress this unnecessary message during kernel re-build (CONFIG_KEXEC_FILE=y):

make[1]: `arch/x86/purgatory/kexec-purgatory.c' is up to date.

---
 arch/x86/purgatory/Makefile | 1 +
 1 file changed, 1 insertion(+)
arch/x86/purgatory/Makefile +0 -0
index f52e033..2c835e3 100644
@@ -24,6 +24,7 @@ quiet_cmd_bin2c = BIN2C   $@
 
Quoted 5 lines

arch/x86/purgatory/Makefile quiet_cmd_bin2c = BIN2C $@ · line 27

Quoted 3 lines
arch/x86/purgatory/Makefile +1 -0
 $(obj)/kexec-purgatory.c: $(obj)/purgatory.ro FORCE
 	$(call if_changed,bin2c)
+	@:

Where can I find the description of "@:" and how does it work?

@ is used to suppress echo'ing. See:
https://www.gnu.org/software/make/manual/html_node/Echoing.html

This is a trick to avoid "... is up to date" message". Check out commit a9358bc ("x86/build: Supress realmode.bin is up to date message").

Thanks
WANG Chao

Acked-by
#4 lore raw
Quoted 24 lines · WANG Chao
Quoted 17 lines · Vivek Goyal
Quoted 16 lines · WANG Chao

Supress this unnecessary message during kernel re-build (CONFIG_KEXEC_FILE=y):

make[1]: `arch/x86/purgatory/kexec-purgatory.c' is up to date.

---
 arch/x86/purgatory/Makefile | 1 +
 1 file changed, 1 insertion(+)
arch/x86/purgatory/Makefile +0 -0
index f52e033..2c835e3 100644
@@ -24,6 +24,7 @@ quiet_cmd_bin2c = BIN2C   $@
 
Quoted 5 lines

arch/x86/purgatory/Makefile quiet_cmd_bin2c = BIN2C $@ · line 27

Quoted 3 lines
arch/x86/purgatory/Makefile +1 -0
 $(obj)/kexec-purgatory.c: $(obj)/purgatory.ro FORCE
 	$(call if_changed,bin2c)
+	@:

Where can I find the description of "@:" and how does it work?

Quoted 5 lines

@ is used to suppress echo'ing. See:
https://www.gnu.org/software/make/manual/html_node/Echoing.html

This is a trick to avoid "... is up to date" message". Check out commit a9358bc ("x86/build: Supress realmode.bin is up to date message").

Thanks for the explanations. Looks good to me.

Vivek

#5 lore raw

[tip:x86/build] x86/purgatory, build: Suppress kexec-purgatory.c is up to date message

In reply to WANG Chao
x86/purgatory, build: Suppress kexec-purgatory.c is up to date message
Commit-ID:  3ea4b8ee2419e21295cabab66c317612c5a55d26
Gitweb:     http://git.kernel.org/tip/3ea4b8ee2419e21295cabab66c317612c5a55d26
Author:     WANG Chao <[email protected]>
AuthorDate: Tue, 14 Oct 2014 12:46:58 +0800
Committer:  H. Peter Anvin <[email protected]>
CommitDate: Wed, 15 Oct 2014 08:31:21 -0700

x86/purgatory, build: Suppress kexec-purgatory.c is up to date message

Suppress this unnecessary message during kernel re-build (CONFIG_KEXEC_FILE=y):

make[1]: `arch/x86/purgatory/kexec-purgatory.c' is up to date.

---
 arch/x86/purgatory/Makefile | 1 +
 1 file changed, 1 insertion(+)
arch/x86/purgatory/Makefile +1 -0
index 899dd24..2c41066 100644
@@ -23,6 +23,7 @@ quiet_cmd_bin2c = BIN2C   $@
 
 $(obj)/kexec-purgatory.c: $(obj)/purgatory.ro FORCE
 	$(call if_changed,bin2c)
+	@:
 
 
 obj-$(CONFIG_KEXEC_FILE)	+= kexec-purgatory.o