Skip to contentSkip to conversation

powerpc/8xx: Optimise MMU TLB handling and add support of 16k pages

PATCH Superseded Christophe Leroy 2 participants 6 messages Sep 17, 2014 – Oct 14, 2014

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

v3 cover powerpc/8xx: Optimise MMU TLB handling and add support of 16k pages

This patchset:
1) provides several MMU TLB handling optimisation on MPC8xx.
2) adds support of 16k pages on MPC8xx.
All changes have been successfully tested on a custom board equipped with MPC885

---
Changes in v2:
- Patch number 10 removed, it was implementing a 16 bit alignment of the PGDIR. It is not worth potentially wasting up to 64k of memory just for removing one instruction (ori).
- Preserve r11 while calculating the level 2 address, therefore no more need to save r11 into CR.

Changes in v3:
- Few fixes following review from Joachim Tjernlund
- Removed the major hack which was saving resisters in memory for CPU6 errata
- Invalidating non present TLB entries earlier (in head_8xx instead of fault.c)

 arch/powerpc/Kconfig                     |   2 +-
 arch/powerpc/include/asm/mmu-8xx.h       |   2 +
 arch/powerpc/include/asm/pgtable-ppc32.h |  20 ++
 arch/powerpc/include/asm/pte-8xx.h       |   7 +-
 arch/powerpc/include/asm/reg.h           |   3 +-
 arch/powerpc/kernel/head_8xx.S           | 370 ++++++++++++-------------
 arch/powerpc/mm/fault.c                  |   9 +-
 7 files changed, 203 insertions(+), 210 deletions(-)
#1 lore raw
Quoted 7 lines · Christophe Leroy

This patchset:
1) provides several MMU TLB handling optimisation on MPC8xx.
2) adds support of 16k pages on MPC8xx.
All changes have been successfully tested on a custom board equipped with MPC885

I've already applied patches 1, 2, 4, 5, 6, 9, and 10 from the previous patchset -- have they changed?

-Scott

#2 lore raw
Quoted 6 lines · Scott Wood
Quoted 5 lines · Christophe Leroy

This patchset:
1) provides several MMU TLB handling optimisation on MPC8xx.
2) adds support of 16k pages on MPC8xx.
All changes have been successfully tested on a custom board equipped with MPC885

Quoted 7 lines
Quoted 2 lines

I've already applied patches 1, 2, 4, 5, 6, 9, and 10 from the previous patchset -- have they changed?

-Scott

No, only 3, 7, 17 are changed, and 20,21 are new.
I didn't notice you already applied some. How should I then proceed now for the remaining ones ? Submit a new set ?

Thanks
Christophe

---
Ce courrier électronique ne contient aucun virus ou logiciel malveillant parce que la protection avast! Antivirus est active.
http://www.avast.com

#3 lore raw
Quoted 9 lines · christophe leroy
Quoted 8 lines · Scott Wood
Quoted 7 lines · Christophe Leroy

This patchset:
1) provides several MMU TLB handling optimisation on MPC8xx.
2) adds support of 16k pages on MPC8xx.
All changes have been successfully tested on a custom board equipped with MPC885

Quoted 9 lines
Quoted 5 lines

I've already applied patches 1, 2, 4, 5, 6, 9, and 10 from the previous patchset -- have they changed?

-Scott

No, only 3, 7, 17 are changed, and 20,21 are new.
I didn't notice you already applied some. How should I then proceed now for the remaining ones ? Submit a new set ?

No, I'll just skip the ones I've already applied.

-Scott

#4 lore raw
Quoted 13 lines · Scott Wood
Quoted 12 lines · christophe leroy
Quoted 11 lines · Scott Wood
Quoted 7 lines · Christophe Leroy

This patchset:
1) provides several MMU TLB handling optimisation on MPC8xx.
2) adds support of 16k pages on MPC8xx.
All changes have been successfully tested on a custom board equipped with MPC885

I've already applied patches 1, 2, 4, 5, 6, 9, and 10 from the previous patchset -- have they changed?

Quoted 9 lines
Quoted 6 lines
Quoted 2 lines

-Scott

No, only 3, 7, 17 are changed, and 20,21 are new.
I didn't notice you already applied some. How should I then proceed now for the remaining ones ? Submit a new set ?

No, I'll just skip the ones I've already applied.

I think I took into account all Joakim's and your's comments in v4. Since I submitted v4, I think I didn't get any new comment. What's the way forward to get the remaining ones applied ?

Christophe

#5 lore raw
Quoted 20 lines · leroy christophe
Quoted 19 lines · Scott Wood
Quoted 18 lines · christophe leroy
Quoted 6 lines · Scott Wood
Quoted 5 lines · Christophe Leroy

This patchset:
1) provides several MMU TLB handling optimisation on MPC8xx.
2) adds support of 16k pages on MPC8xx.
All changes have been successfully tested on a custom board equipped with MPC885

Quoted 7 lines
Quoted 2 lines

I've already applied patches 1, 2, 4, 5, 6, 9, and 10 from the previous patchset -- have they changed?

-Scott

No, only 3, 7, 17 are changed, and 20,21 are new.
I didn't notice you already applied some. How should I then proceed now for the remaining ones ? Submit a new set ?

Quoted 6 lines
Quoted 3 lines

No, I'll just skip the ones I've already applied.

I think I took into account all Joakim's and your's comments in v4. Since I submitted v4, I think I didn't get any new comment. What's the way forward to get the remaining ones applied ?

I haven't had a chance to review v4 yet. I'm currently at conferences and will be on vacation next week, but I will try to look at them soon after that.

-Scott