Skip to contentSkip to conversation

makedumpfile.8: "cache without private" column of the table for -d appears to be incorrect

PATCH In review Harshula Jayasuriya 2 participants 5 messages Oct 14, 2014 – Oct 24, 2014

Subsystems (2)
Live update kexec handover (KHO)
lore
Share & tools
lore

Harshula Jayasuriya

author
#0 lore raw

PATCH 1/1 makedumpfile.8: "cache without private" column of the table for -d appears to be incorrect

Hi,

The makedumpfile man page contains a table explaining the usage of -d. The "cache without private" column implies that -d 4 would exclude "cache without private" pages. However, a -d 4 should only exclude "cache with private".

makedumpfile.h:
------------------------------------------------------------
#define DL_EXCLUDE_CACHE (0x002) /* Exclude Cache Pages
without Private Pages */
------------------------------------------------------------

makedumpfile.8:
------------------------------------------------------------

                     |      |cache  |cache  |      |
                dump | zero |without|with   | user | free
               level | page |private|private| data | page

-------+------+-------+-------+------+------
0 | | | | |
1 | X | | | |
2 | | X | | |
3 | X | X | | |
4 | | X | X | |
5 | X | X | X | |
6 | | X | X | |
7 | X | X | X | |
8 | | | | X |
------------------------------------------------------------

Signed-off-by Harshula Jayasuriya <[email protected]>
---
 makedumpfile.8 | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)
makedumpfile.8 +8 -8
index 9cb12c0..382c6ee 100644
@@ -174,32 +174,32 @@ by dump_level 11, makedumpfile retries it by dump_level 31.
      1 |  X   |       |       |      |
      2 |      |   X   |       |      |
      3 |  X   |   X   |       |      |
-     4 |      |   X   |   X   |      |
-     5 |  X   |   X   |   X   |      |
+     4 |      |       |   X   |      |
+     5 |  X   |       |   X   |      |
      6 |      |   X   |   X   |      |
      7 |  X   |   X   |   X   |      |
      8 |      |       |       |  X   |
      9 |  X   |       |       |  X   |
     10 |      |   X   |       |  X   |
     11 |  X   |   X   |       |  X   |
-    12 |      |   X   |   X   |  X   |
-    13 |  X   |   X   |   X   |  X   |
+    12 |      |       |   X   |  X   |
+    13 |  X   |       |   X   |  X   |
     14 |      |   X   |   X   |  X   |
     15 |  X   |   X   |   X   |  X   |
     16 |      |       |       |      |  X
     17 |  X   |       |       |      |  X
     18 |      |   X   |       |      |  X
     19 |  X   |   X   |       |      |  X
-    20 |      |   X   |   X   |      |  X
-    21 |  X   |   X   |   X   |      |  X
+    20 |      |       |   X   |      |  X
+    21 |  X   |       |   X   |      |  X
     22 |      |   X   |   X   |      |  X
     23 |  X   |   X   |   X   |      |  X
     24 |      |       |       |  X   |  X
     25 |  X   |       |       |  X   |  X
     26 |      |   X   |       |  X   |  X
     27 |  X   |   X   |       |  X   |  X
-    28 |      |   X   |   X   |  X   |  X
-    29 |  X   |   X   |   X   |  X   |  X
+    28 |      |       |   X   |  X   |  X
+    29 |  X   |       |   X   |  X   |  X
     30 |      |   X   |   X   |  X   |  X
     31 |  X   |   X   |   X   |  X   |  X
Signature · 7 lines
1.9.3


_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec
#1 lore raw

Hello,

Quoted 6 lines

Hi,

The makedumpfile man page contains a table explaining the usage of -d. The "cache without private" column implies that -d 4 would exclude "cache without private" pages. However, a -d 4 should only exclude "cache with private".

"cache with private" includes "cache without private" because the latter doesn't mean leaving private cache pages, just mean excluding cache pages except private pages. Meanwhile, "cache with private" means excluding both cache pages (private and non-private). So "with private" meets "without private" in this feature, they aren't exclusive.
This style is for diskdump compatibility, but now I suspect it may be bit confusing.

I don't want to change the behavior of the page filtering, but I guess changing the column names might be meaningful.
I'm curious to know what everyone thought of the two columns. This can be a good opportunity to make the manual easier to understand.

Thanks,
Atsushi Kumagai

Quoted 74 lines

makedumpfile.h:
------------------------------------------------------------
#define DL_EXCLUDE_CACHE (0x002) /* Exclude Cache Pages
without Private Pages */
------------------------------------------------------------

makedumpfile.8:
------------------------------------------------------------

                    |      |cache  |cache  |      |
               dump | zero |without|with   | user | free
              level | page |private|private| data | page

-------+------+-------+-------+------+------
0 | | | | |
1 | X | | | |
2 | | X | | |
3 | X | X | | |
4 | | X | X | |
5 | X | X | X | |
6 | | X | X | |
7 | X | X | X | |
8 | | | | X |
------------------------------------------------------------

Signed-off-by Harshula Jayasuriya <[email protected]>

---
makedumpfile.8 | 16 ++++++++--------

1 file changed, 8 insertions(+), 8 deletions(-)
makedumpfile.8 +8 -9
index 9cb12c0..382c6ee 100644
@@ -174,32 +174,32 @@ by dump_level 11, makedumpfile retries it by dump_level 31.
     1 |  X   |       |       |      |
     2 |      |   X   |       |      |
     3 |  X   |   X   |       |      |
-     4 |      |   X   |   X   |      |
-     5 |  X   |   X   |   X   |      |
+     4 |      |       |   X   |      |
+     5 |  X   |       |   X   |      |
     6 |      |   X   |   X   |      |
     7 |  X   |   X   |   X   |      |
     8 |      |       |       |  X   |
     9 |  X   |       |       |  X   |
    10 |      |   X   |       |  X   |
    11 |  X   |   X   |       |  X   |
-    12 |      |   X   |   X   |  X   |
-    13 |  X   |   X   |   X   |  X   |
+    12 |      |       |   X   |  X   |
+    13 |  X   |       |   X   |  X   |
    14 |      |   X   |   X   |  X   |
    15 |  X   |   X   |   X   |  X   |
    16 |      |       |       |      |  X
    17 |  X   |       |       |      |  X
    18 |      |   X   |       |      |  X
    19 |  X   |   X   |       |      |  X
-    20 |      |   X   |   X   |      |  X
-    21 |  X   |   X   |   X   |      |  X
+    20 |      |       |   X   |      |  X
+    21 |  X   |       |   X   |      |  X
    22 |      |   X   |   X   |      |  X
    23 |  X   |   X   |   X   |      |  X
    24 |      |       |       |  X   |  X
    25 |  X   |       |       |  X   |  X
    26 |      |   X   |       |  X   |  X
    27 |  X   |   X   |       |  X   |  X
-    28 |      |   X   |   X   |  X   |  X
-    29 |  X   |   X   |   X   |  X   |  X
+    28 |      |       |   X   |  X   |  X
+    29 |  X   |       |   X   |  X   |  X
    30 |      |   X   |   X   |  X   |  X
    31 |  X   |   X   |   X   |  X   |  X
 
--
Quoted 1 line

1.9.3

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

author
#2 lore raw

Hi,

Quoted 9 lines · Atsushi Kumagai

Hello,

Quoted 6 lines

Hi,

The makedumpfile man page contains a table explaining the usage of -d. The "cache without private" column implies that -d 4 would exclude "cache without private" pages. However, a -d 4 should only exclude "cache with private".

Quoted 7 lines

"cache with private" includes "cache without private" because the latter doesn't mean leaving private cache pages, just mean excluding cache pages except private pages. Meanwhile, "cache with private" means excluding both cache pages (private and non-private). So "with private" meets "without private" in this feature, they aren't exclusive.
This style is for diskdump compatibility, but now I suspect it may be bit confusing.

Ahhh I see! ;-)

Quoted 2 lines

I don't want to change the behavior of the page filtering, but I guess changing the column names might be meaningful.

Would the following help?

a) s/cache without private/non-private cache/

b) s/cache with private/all cache/

cya,
#

Quoted 80 lines

I'm curious to know what everyone thought of the two columns. This can be a good opportunity to make the manual easier to understand.

Thanks,
Atsushi Kumagai

Quoted 73 lines

makedumpfile.h:
------------------------------------------------------------
#define DL_EXCLUDE_CACHE (0x002) /* Exclude Cache Pages
without Private Pages */
------------------------------------------------------------

makedumpfile.8:
------------------------------------------------------------

                    |      |cache  |cache  |      |
               dump | zero |without|with   | user | free
              level | page |private|private| data | page

-------+------+-------+-------+------+------
0 | | | | |
1 | X | | | |
2 | | X | | |
3 | X | X | | |
4 | | X | X | |
5 | X | X | X | |
6 | | X | X | |
7 | X | X | X | |
8 | | | | X |
------------------------------------------------------------

Signed-off-by Harshula Jayasuriya <[email protected]>

---
makedumpfile.8 | 16 ++++++++--------

1 file changed, 8 insertions(+), 8 deletions(-)
makedumpfile.8 +8 -8
index 9cb12c0..382c6ee 100644
@@ -174,32 +174,32 @@ by dump_level 11, makedumpfile retries it by dump_level 31.
     1 |  X   |       |       |      |
     2 |      |   X   |       |      |
     3 |  X   |   X   |       |      |
-     4 |      |   X   |   X   |      |
-     5 |  X   |   X   |   X   |      |
+     4 |      |       |   X   |      |
+     5 |  X   |       |   X   |      |
     6 |      |   X   |   X   |      |
     7 |  X   |   X   |   X   |      |
     8 |      |       |       |  X   |
     9 |  X   |       |       |  X   |
    10 |      |   X   |       |  X   |
    11 |  X   |   X   |       |  X   |
-    12 |      |   X   |   X   |  X   |
-    13 |  X   |   X   |   X   |  X   |
+    12 |      |       |   X   |  X   |
+    13 |  X   |       |   X   |  X   |
    14 |      |   X   |   X   |  X   |
    15 |  X   |   X   |   X   |  X   |
    16 |      |       |       |      |  X
    17 |  X   |       |       |      |  X
    18 |      |   X   |       |      |  X
    19 |  X   |   X   |       |      |  X
-    20 |      |   X   |   X   |      |  X
-    21 |  X   |   X   |   X   |      |  X
+    20 |      |       |   X   |      |  X
+    21 |  X   |       |   X   |      |  X
    22 |      |   X   |   X   |      |  X
    23 |  X   |   X   |   X   |      |  X
    24 |      |       |       |  X   |  X
    25 |  X   |       |       |  X   |  X
    26 |      |   X   |       |  X   |  X
    27 |  X   |   X   |       |  X   |  X
-    28 |      |   X   |   X   |  X   |  X
-    29 |  X   |   X   |   X   |  X   |  X
+    28 |      |       |   X   |  X   |  X
+    29 |  X   |       |   X   |  X   |  X
    30 |      |   X   |   X   |  X   |  X
    31 |  X   |   X   |   X   |  X   |  X
Quoted 2 lines
Quoted 2 lines

--
1.9.3

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

#3 lore raw
Quoted 22 lines

Hi,

Quoted 9 lines · Atsushi Kumagai

Hello,

Quoted 6 lines

Hi,

The makedumpfile man page contains a table explaining the usage of -d. The "cache without private" column implies that -d 4 would exclude "cache without private" pages. However, a -d 4 should only exclude "cache with private".

Quoted 7 lines

"cache with private" includes "cache without private" because the latter doesn't mean leaving private cache pages, just mean excluding cache pages except private pages. Meanwhile, "cache with private" means excluding both cache pages (private and non-private). So "with private" meets "without private" in this feature, they aren't exclusive.
This style is for diskdump compatibility, but now I suspect it may be bit confusing.

Ahhh I see! ;-)

Quoted 8 lines
Quoted 2 lines

I don't want to change the behavior of the page filtering, but I guess changing the column names might be meaningful.

Would the following help?

a) s/cache without private/non-private cache/

b) s/cache with private/all cache/

Thanks for your suggestion, but now I think each column should be exclusive to make the rule consistent. Actually, other columns (zero page, user data, free page) are exclusive.

So let's name the two like below:

a) non-private cache
b) private cache

                     |      |non-   |       |      |
                dump | zero |private|private| user | free
               level | page |cache  |cache  | data | page

-------+------+-------+-------+------+------
...
4 | | X | X | |
5 | X | X | X | |

then marking the both columns for level 4 will be natural. I'll post a patch later if there is no objection.

Thanks,
Atsushi Kumagai

Quoted 83 lines

cya,
#

Quoted 80 lines

I'm curious to know what everyone thought of the two columns. This can be a good opportunity to make the manual easier to understand.

Thanks,
Atsushi Kumagai

Quoted 73 lines

makedumpfile.h:
------------------------------------------------------------
#define DL_EXCLUDE_CACHE (0x002) /* Exclude Cache Pages
without Private Pages */
------------------------------------------------------------

makedumpfile.8:
------------------------------------------------------------

                    |      |cache  |cache  |      |
               dump | zero |without|with   | user | free
              level | page |private|private| data | page

-------+------+-------+-------+------+------
0 | | | | |
1 | X | | | |
2 | | X | | |
3 | X | X | | |
4 | | X | X | |
5 | X | X | X | |
6 | | X | X | |
7 | X | X | X | |
8 | | | | X |
------------------------------------------------------------

Signed-off-by Harshula Jayasuriya <[email protected]>

---
makedumpfile.8 | 16 ++++++++--------

1 file changed, 8 insertions(+), 8 deletions(-)
makedumpfile.8 +8 -8
index 9cb12c0..382c6ee 100644
@@ -174,32 +174,32 @@ by dump_level 11, makedumpfile retries it by dump_level 31.
     1 |  X   |       |       |      |
     2 |      |   X   |       |      |
     3 |  X   |   X   |       |      |
-     4 |      |   X   |   X   |      |
-     5 |  X   |   X   |   X   |      |
+     4 |      |       |   X   |      |
+     5 |  X   |       |   X   |      |
     6 |      |   X   |   X   |      |
     7 |  X   |   X   |   X   |      |
     8 |      |       |       |  X   |
     9 |  X   |       |       |  X   |
    10 |      |   X   |       |  X   |
    11 |  X   |   X   |       |  X   |
-    12 |      |   X   |   X   |  X   |
-    13 |  X   |   X   |   X   |  X   |
+    12 |      |       |   X   |  X   |
+    13 |  X   |       |   X   |  X   |
    14 |      |   X   |   X   |  X   |
    15 |  X   |   X   |   X   |  X   |
    16 |      |       |       |      |  X
    17 |  X   |       |       |      |  X
    18 |      |   X   |       |      |  X
    19 |  X   |   X   |       |      |  X
-    20 |      |   X   |   X   |      |  X
-    21 |  X   |   X   |   X   |      |  X
+    20 |      |       |   X   |      |  X
+    21 |  X   |       |   X   |      |  X
    22 |      |   X   |   X   |      |  X
    23 |  X   |   X   |   X   |      |  X
    24 |      |       |       |  X   |  X
    25 |  X   |       |       |  X   |  X
    26 |      |   X   |       |  X   |  X
    27 |  X   |   X   |       |  X   |  X
-    28 |      |   X   |   X   |  X   |  X
-    29 |  X   |   X   |   X   |  X   |  X
+    28 |      |       |   X   |  X   |  X
+    29 |  X   |       |   X   |  X   |  X
    30 |      |   X   |   X   |  X   |  X
    31 |  X   |   X   |   X   |  X   |  X
Quoted 3 lines
Quoted 2 lines
Quoted 2 lines

--
1.9.3

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

author
#4 lore raw
Quoted 43 lines · Atsushi Kumagai
Quoted 22 lines

Hi,

Quoted 9 lines · Atsushi Kumagai

Hello,

Quoted 6 lines

Hi,

The makedumpfile man page contains a table explaining the usage of -d. The "cache without private" column implies that -d 4 would exclude "cache without private" pages. However, a -d 4 should only exclude "cache with private".

Quoted 7 lines

"cache with private" includes "cache without private" because the latter doesn't mean leaving private cache pages, just mean excluding cache pages except private pages. Meanwhile, "cache with private" means excluding both cache pages (private and non-private). So "with private" meets "without private" in this feature, they aren't exclusive.
This style is for diskdump compatibility, but now I suspect it may be bit confusing.

Ahhh I see! ;-)

Quoted 8 lines
Quoted 2 lines

I don't want to change the behavior of the page filtering, but I guess changing the column names might be meaningful.

Would the following help?

a) s/cache without private/non-private cache/

b) s/cache with private/all cache/

Thanks for your suggestion, but now I think each column should be exclusive to make the rule consistent. Actually, other columns (zero page, user data, free page) are exclusive.

So let's name the two like below:

a) non-private cache
b) private cache

                     |      |non-   |       |      |
                dump | zero |private|private| user | free
               level | page |cache  |cache  | data | page
Quoted 7 lines

-------+------+-------+-------+------+------
...
4 | | X | X | |
5 | X | X | X | |

then marking the both columns for level 4 will be natural. I'll post a patch later if there is no objection.

Looks good to me!

cya,
#

Quoted 89 lines

Thanks,
Atsushi Kumagai

Quoted 86 lines

cya,
#

Quoted 82 lines

I'm curious to know what everyone thought of the two columns. This can be a good opportunity to make the manual easier to understand.

Thanks,
Atsushi Kumagai

Quoted 75 lines

makedumpfile.h:
------------------------------------------------------------
#define DL_EXCLUDE_CACHE (0x002) /* Exclude Cache Pages
without Private Pages */
------------------------------------------------------------

makedumpfile.8:
------------------------------------------------------------

                    |      |cache  |cache  |      |
               dump | zero |without|with   | user | free
              level | page |private|private| data | page

-------+------+-------+-------+------+------
0 | | | | |
1 | X | | | |
2 | | X | | |
3 | X | X | | |
4 | | X | X | |
5 | X | X | X | |
6 | | X | X | |
7 | X | X | X | |
8 | | | | X |
------------------------------------------------------------

Signed-off-by Harshula Jayasuriya <[email protected]>

---
makedumpfile.8 | 16 ++++++++--------

1 file changed, 8 insertions(+), 8 deletions(-)
makedumpfile.8 +8 -9
index 9cb12c0..382c6ee 100644
@@ -174,32 +174,32 @@ by dump_level 11, makedumpfile retries it by dump_level 31.
     1 |  X   |       |       |      |
     2 |      |   X   |       |      |
     3 |  X   |   X   |       |      |
-     4 |      |   X   |   X   |      |
-     5 |  X   |   X   |   X   |      |
+     4 |      |       |   X   |      |
+     5 |  X   |       |   X   |      |
     6 |      |   X   |   X   |      |
     7 |  X   |   X   |   X   |      |
     8 |      |       |       |  X   |
     9 |  X   |       |       |  X   |
    10 |      |   X   |       |  X   |
    11 |  X   |   X   |       |  X   |
-    12 |      |   X   |   X   |  X   |
-    13 |  X   |   X   |   X   |  X   |
+    12 |      |       |   X   |  X   |
+    13 |  X   |       |   X   |  X   |
    14 |      |   X   |   X   |  X   |
    15 |  X   |   X   |   X   |  X   |
    16 |      |       |       |      |  X
    17 |  X   |       |       |      |  X
    18 |      |   X   |       |      |  X
    19 |  X   |   X   |       |      |  X
-    20 |      |   X   |   X   |      |  X
-    21 |  X   |   X   |   X   |      |  X
+    20 |      |       |   X   |      |  X
+    21 |  X   |       |   X   |      |  X
    22 |      |   X   |   X   |      |  X
    23 |  X   |   X   |   X   |      |  X
    24 |      |       |       |  X   |  X
    25 |  X   |       |       |  X   |  X
    26 |      |   X   |       |  X   |  X
    27 |  X   |   X   |       |  X   |  X
-    28 |      |   X   |   X   |  X   |  X
-    29 |  X   |   X   |   X   |  X   |  X
+    28 |      |       |   X   |  X   |  X
+    29 |  X   |       |   X   |  X   |  X
    30 |      |   X   |   X   |  X   |  X
    31 |  X   |   X   |   X   |  X   |  X
 
--

1.9.3

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec