vxlan: remove the dead codes

PATCH In review [email protected] 4 participants 4 messages Oct 17, 2014 – Oct 18, 2014

Subsystems (2)

Networking Network drivers

lore

Share & tools

lore

[email protected]

author

2014-10-17 06:04 UTC #0 lore raw

PATCH v2 1/1 vxlan: remove the dead codes

From: Li RongQing <[email protected]>

remove the dead codes, no user uses vxlan_salt

Signed-off-by Li RongQing <[email protected]>

---
 drivers/net/vxlan.c |    4 ----
 1 file changed, 4 deletions(-)

drivers/net/vxlan.c +0 -4

index 77ab844..855a81d 100644
@@ -152,8 +152,6 @@ struct vxlan_dev {
 	struct hlist_head fdb_head[FDB_HASH_SIZE];
 };
 
-/* salt for hash table */
-static u32 vxlan_salt __read_mostly;
 static struct workqueue_struct *vxlan_wq;
 
 static void vxlan_sock_work(struct work_struct *work);

@@ -2797,8 +2795,6 @@ static int __init vxlan_init_module(void)
 	if (!vxlan_wq)
 		return -ENOMEM;
 
-	get_random_bytes(&vxlan_salt, sizeof(vxlan_salt));
-
 	rc = register_pernet_subsys(&vxlan_net_ops);
 	if (rc)
 		goto out1;

Signature · 1 line

1.7.10.4

Cong Wang

2014-10-17 17:33 UTC #1 lore raw

Quoted 14 lines · On Thu, Oct 16, 2014 at 11:04 PM, <[email protected]> wrote:

From: Li RongQing <[email protected]>
remove the dead codes, no user uses vxlan_salt
Signed-off-by Li RongQing <[email protected]>
---
 drivers/net/vxlan.c |    4 ----
 1 file changed, 4 deletions(-)
drivers/net/vxlan.c +0 -0
index 77ab844..855a81d 100644

drivers/net/vxlan.c struct vxlan_dev { · line 156

Quoted 5 lines

drivers/net/vxlan.c +0 -2

@@ -152,8 +152,6 @@ struct vxlan_dev {
        struct hlist_head fdb_head[FDB_HASH_SIZE];
 };
 
-/* salt for hash table */
-static u32 vxlan_salt __read_mostly;

Hmm, it has never been used since it was born. Maybe we should really use for vxlan hash table?

David Miller

maintainer

2014-10-17 20:24 UTC #2 lore raw

From: Cong Wang <[email protected]>
Date: Fri, 17 Oct 2014 10:33:08 -0700

Quoted 18 lines · On Thu, Oct 16, 2014 at 11:04 PM, <[email protected]> wrote:

Quoted 17 lines
From: Li RongQing <[email protected]>
remove the dead codes, no user uses vxlan_salt
Signed-off-by Li RongQing <[email protected]>
---
 drivers/net/vxlan.c |    4 ----
 1 file changed, 4 deletions(-)
drivers/net/vxlan.c +0 -0
index 77ab844..855a81d 100644
@@ -152,8 +152,6 @@ struct vxlan_dev {
        struct hlist_head fdb_head[FDB_HASH_SIZE];
 };
 

Quoted 5 lines

drivers/net/vxlan.c struct vxlan_dev { · line 156
Quoted 2 lines
drivers/net/vxlan.c +0 -2
-/* salt for hash table */
-static u32 vxlan_salt __read_mostly;
Hmm, it has never been used since it was born. Maybe we should really use for vxlan hash table?

Yes, agreed, and I am very sure that this was Stephen Hemminger's original intention.

Stephen Hemminger

2014-10-18 09:21 UTC #3 lore raw

Quoted 21 lines · On Fri, 17 Oct 2014 16:24:49 -0400 (EDT) David Miller <[email protected]>…

From: Cong Wang <[email protected]>
Date: Fri, 17 Oct 2014 10:33:08 -0700
Quoted 18 lines · On Thu, Oct 16, 2014 at 11:04 PM, <[email protected]> wrote:
Quoted 17 lines
From: Li RongQing <[email protected]>
remove the dead codes, no user uses vxlan_salt
Signed-off-by Li RongQing <[email protected]>
---
 drivers/net/vxlan.c |    4 ----
 1 file changed, 4 deletions(-)
drivers/net/vxlan.c +0 -0
index 77ab844..855a81d 100644
@@ -152,8 +152,6 @@ struct vxlan_dev {
        struct hlist_head fdb_head[FDB_HASH_SIZE];
 };
 

Quoted 8 lines

Quoted 5 lines
drivers/net/vxlan.c struct vxlan_dev { · line 156
Quoted 2 lines
drivers/net/vxlan.c +0 -2
-/* salt for hash table */
-static u32 vxlan_salt __read_mostly;
Hmm, it has never been used since it was born. Maybe we should really use for vxlan hash table?
Yes, agreed, and I am very sure that this was Stephen Hemminger's original intention.

yes. never did rekeying, and it would have been hard.