Skip to contentSkip to conversation

bandwidthd: Version bump to handle indirect deps properly

PATCH New Nathaniel Roach 1 participant 1 message Oct 19, 2014

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 bandwidthd: Version bump to handle indirect deps properly

Thanks to Romain Naour, Baruch Siach and Thomas Petazzoni, I've solved the build issues in certain cases for bandwidthd.

The issue was that libpcap and libpng would depend on other libraries and upon testing for pcap/libpng the tests would fail due to not being able to find the other libraries.

Bandwidthd's configure script now uses pkg-config for libpng and pcap-config for libpcap. pcap-config's path is specified in configure's arguments.

Some other tweaks have been made including the layout and flow of configure.ac is a bit more logical, and the handling of postgres and sqlite has been tweaked. Finally, the test for X.Org has been removed.

---
Changes v1 to v2
- Fixed spelling of Romain's name (again, sorry!)
- Added Romain, Baruch and Thomas in the Cc:

---
 package/bandwidthd/bandwidthd.mk | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
package/bandwidthd/bandwidthd.mk +3 -3
index 7a2975f..ca991f9 100644
@@ -4,18 +4,18 @@
 #
 ################################################################################
 
-BANDWIDTHD_VERSION = v2.0.1-auto-r08
+BANDWIDTHD_VERSION = v2.0.1-auto-r11
 BANDWIDTHD_SITE = $(call github,nroach44,bandwidthd,$(BANDWIDTHD_VERSION))
 
 # Specified as "any version of the GPL that is current as of your
 # download" by upstream.
 BANDWIDTHD_LICENSE = GPL
 
-BANDWIDTHD_DEPENDENCIES = gd libpng libpcap
+BANDWIDTHD_DEPENDENCIES = gd libpng libpcap host-pkgconf
 
 BANDWIDTHD_AUTORECONF = YES
 
-BANDWIDTHD_CONF_OPTS += --without-x
+BANDWIDTHD_CONF_OPTS += --with-pcap-config=$(STAGING_DIR)/usr/bin/pcap-config
 
 ifeq ($(BR2_PACKAGE_BANDWIDTHD_POSTGRESQL),y)
 BANDWIDTHD_DEPENDENCIES += postgresql
Signature · 1 line
2.1.1