Skip to contentSkip to conversation

drm/mode: document path property and function to set it.

PATCH In review Dave Airlie 2 participants 2 messages Oct 22, 2014

Subsystems (3)
DRM drivers Documentation DRM misc
lore
Share & tools
lore

Dave Airlie

author maintainer
#0 lore raw

PATCH 1/1 drm/mode: document path property and function to set it.

From: Dave Airlie <[email protected]>

These two didn't get documented properly, do so.

Pointed out by Daniel.

Signed-off-by Dave Airlie <[email protected]>
---
 Documentation/DocBook/drm.tmpl |  9 ++++++++-
 drivers/gpu/drm/drm_crtc.c     | 10 ++++++++++
 2 files changed, 18 insertions(+), 1 deletion(-)
Documentation/DocBook/drm.tmpl +8 -1
index bacefc5..0a5cbbb 100644
@@ -2509,7 +2509,7 @@ void intel_crt_init(struct drm_device *dev)
 	</tr>
 	<tr>
 	<td rowspan="21" valign="top" >DRM</td>
-	<td rowspan="2" valign="top" >Generic</td>
+	<td rowspan="3" valign="top" >Generic</td>
 	<td valign="top" >“EDID”</td>
 	<td valign="top" >BLOB | IMMUTABLE</td>
 	<td valign="top" >0</td>

@@ -2524,6 +2524,13 @@ void intel_crt_init(struct drm_device *dev)
 	<td valign="top" >Contains DPMS operation mode value.</td>
 	</tr>
 	<tr>
+	<td valign="top" >“PATH”</td>
+	<td valign="top" >BLOB | IMMUTABLE</td>
+	<td valign="top" >0</td>
+	<td valign="top" >Connector</td>
+	<td valign="top" >Contains topology path to a connector.</td>
+	</tr>
+	<tr>
 	<td rowspan="1" valign="top" >Plane</td>
 	<td valign="top" >“type”</td>
 	<td valign="top" >ENUM | IMMUTABLE</td>
drivers/gpu/drm/drm_crtc.c +10 -0
index 90e7730..363301c 100644
@@ -3980,6 +3980,16 @@ done:
 	return ret;
 }
 
+/**
+ * drm_mode_connector_set_path_property - set tile property on connector
+ * @connector: connector to set property on.
+ * @path: path to use for property.
+ *
+ * This creates a property to expose to userspace to specify a
+ * connector path. This is mainly used for DisplayPort MST where
+ * connectors have a topology and we want to allow userspace to give
+ * them more meaningful names.
+ */
 int drm_mode_connector_set_path_property(struct drm_connector *connector,
 					 char *path)
 {
Signature · 6 lines
2.1.0

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by on v1 1/1
#1 lore raw
Quoted 47 lines · Dave Airlie

From: Dave Airlie <[email protected]>

These two didn't get documented properly, do so.

Pointed out by Daniel.

Signed-off-by Dave Airlie <[email protected]>
---
 Documentation/DocBook/drm.tmpl |  9 ++++++++-
 drivers/gpu/drm/drm_crtc.c     | 10 ++++++++++
 2 files changed, 18 insertions(+), 1 deletion(-)
Documentation/DocBook/drm.tmpl +8 -1
index bacefc5..0a5cbbb 100644
@@ -2509,7 +2509,7 @@ void intel_crt_init(struct drm_device *dev)
 	</tr>
 	<tr>
 	<td rowspan="21" valign="top" >DRM</td>
-	<td rowspan="2" valign="top" >Generic</td>
+	<td rowspan="3" valign="top" >Generic</td>
 	<td valign="top" >“EDID”</td>
 	<td valign="top" >BLOB | IMMUTABLE</td>
 	<td valign="top" >0</td>

@@ -2524,6 +2524,13 @@ void intel_crt_init(struct drm_device *dev)
 	<td valign="top" >Contains DPMS operation mode value.</td>
 	</tr>
 	<tr>
+	<td valign="top" >“PATH”</td>
+	<td valign="top" >BLOB | IMMUTABLE</td>
+	<td valign="top" >0</td>
+	<td valign="top" >Connector</td>
+	<td valign="top" >Contains topology path to a connector.</td>
+	</tr>
+	<tr>
 	<td rowspan="1" valign="top" >Plane</td>
 	<td valign="top" >“type”</td>
 	<td valign="top" >ENUM | IMMUTABLE</td>
drivers/gpu/drm/drm_crtc.c +0 -0
index 90e7730..363301c 100644
@@ -3980,6 +3980,16 @@ done:
 	return ret;
 }

drivers/gpu/drm/drm_crtc.c done: · line 3992

Quoted 10 lines
drivers/gpu/drm/drm_crtc.c +10 -0
+/**
+ * drm_mode_connector_set_path_property - set tile property on connector
+ * @connector: connector to set property on.
+ * @path: path to use for property.
+ *
+ * This creates a property to expose to userspace to specify a
+ * connector path. This is mainly used for DisplayPort MST where
+ * connectors have a topology and we want to allow userspace to give
+ * them more meaningful names.
+ */

The

* Returns:
* Zero on success, error code on failure.

boilerplate is missing, with this is

Reviewed-by Daniel Vetter <[email protected]>
Quoted 10 lines
drivers/gpu/drm/drm_crtc.c +0 -0
 int drm_mode_connector_set_path_property(struct drm_connector *connector,
 					 char *path)
 {
Signature · 6 lines
2.1.0

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel