ncpfs: Return proper error from NCP_IOC_SETROOT ioctl
Jan Kara
reviewerPATCH 1/1 ncpfs: Return proper error from NCP_IOC_SETROOT ioctl
If some error happens in NCP_IOC_SETROOT ioctl, the appropriate error return value is then (in most cases) just overwritten before we return. This can result in reporting success to userspace although error happened. This bug was introduced by commit 2e54eb96e2c8 (BKL: Remove BKL from ncpfs). Propagate the errors correctly.
Coverity-id: 1226925
Fixes 2e54eb96e2c801f33d95b5dade15212ac4d6c4a5
Signed-off-by Jan Kara <[email protected]>
--- fs/ncpfs/ioctl.c | 1 - 1 file changed, 1 deletion(-)
fs/ncpfs/ioctl.c +0 -1
@@ -447,7 +447,6 @@ static long __ncp_ioctl(struct inode *inode, unsigned int cmd, unsigned long arg result = -EIO ; } } - result =0 ; }mutex_unlock (&server->root_setup_lock);
Signature · 1 line
1.8.1.4