Skip to contentSkip to conversation

Fix Unknown symbols in nf_reject_ipvX modules

RFC PATCH In review Li Zhong 2 participants 3 messages Oct 24, 2014 – Oct 27, 2014

Subsystems (2)
Networking netfilter
lore
Share & tools
lore

Li Zhong

author
#0 lore raw

RFC PATCH 1/1 Fix Unknown symbols in nf_reject_ipvX modules

Commit c8d7b98bec43 moved nf_send_resetX() to modules without module license, which causes following errors seen on my system:

[   26.926014] nf_reject_ipv4: Unknown symbol rcu_read_lock_bh_held (err 0)
[   26.926022] nf_reject_ipv4: Unknown symbol rcu_read_lock_held (err 0)
[   26.926030] nf_reject_ipv4: Unknown symbol ip_local_out_sk (err 0)

The code below adds MODULE_LICENSE("GPL") to fix this issue.

Signed-off-by Li Zhong <[email protected]>
---
 net/ipv4/netfilter/nf_reject_ipv4.c | 3 +++
 net/ipv6/netfilter/nf_reject_ipv6.c | 3 +++
 2 files changed, 6 insertions(+)
net/ipv4/netfilter/nf_reject_ipv4.c +3 -0
index b023b4e..d5df20d 100644
@@ -11,6 +11,9 @@
 #include <net/route.h>
 #include <net/dst.h>
 #include <linux/netfilter_ipv4.h>
+#include <linux/module.h>
+
+MODULE_LICENSE("GPL");
 
 /* Send RST reply */
 void nf_send_reset(struct sk_buff *oldskb, int hook)
net/ipv6/netfilter/nf_reject_ipv6.c +3 -0
index 5f5f043..e3e5683 100644
@@ -10,6 +10,9 @@
 #include <net/ip6_fib.h>
 #include <net/ip6_checksum.h>
 #include <linux/netfilter_ipv6.h>
+#include <linux/module.h>
+
+MODULE_LICENSE("GPL");
 
 void nf_send_reset6(struct net *net, struct sk_buff *oldskb, int hook)
 {
maintainer
#1 lore raw
Quoted 8 lines · Li Zhong

Commit c8d7b98bec43 moved nf_send_resetX() to modules without module license, which causes following errors seen on my system:

[   26.926014] nf_reject_ipv4: Unknown symbol rcu_read_lock_bh_held (err 0)
[   26.926022] nf_reject_ipv4: Unknown symbol rcu_read_lock_held (err 0)
[   26.926030] nf_reject_ipv4: Unknown symbol ip_local_out_sk (err 0)

The code below adds MODULE_LICENSE("GPL") to fix this issue.

We already sent a similar patch that should hit Linus' tree soon.

Sorry for the inconvenience.

author
#2 lore raw
Quoted 11 lines · Pablo Neira Ayuso
Quoted 8 lines · Li Zhong

Commit c8d7b98bec43 moved nf_send_resetX() to modules without module license, which causes following errors seen on my system:

[   26.926014] nf_reject_ipv4: Unknown symbol rcu_read_lock_bh_held (err 0)
[   26.926022] nf_reject_ipv4: Unknown symbol rcu_read_lock_held (err 0)
[   26.926030] nf_reject_ipv4: Unknown symbol ip_local_out_sk (err 0)

The code below adds MODULE_LICENSE("GPL") to fix this issue.

We already sent a similar patch that should hit Linus' tree soon.

Ah, Ok, good to know.

Sorry for the noise :)

Quoted 3 lines

Sorry for the inconvenience.

--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html