Skip to contentSkip to conversation

spl: move comment to the right place

PATCH In review andreas.devel at googlemail.com 2 participants 2 messages Oct 25, 2014 – Oct 27, 2014

lore
Share & tools
lore

andreas.devel at googlemail.com

author
#0 lore raw

PATCH 1/1 spl: move comment to the right place

From: Andreas Bie?mann <[email protected]>

Commit ae83d882f5fdf7aa7c5aec09cfafb593153c25d6 moved the fixed size mentioned in the comment but missed the comment.

Signed-off-by Andreas Bie?mann <[email protected]>

---

 common/spl/spl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
common/spl/spl.c +1 -1
index b16664f..d85bab3 100644
@@ -23,6 +23,7 @@ DECLARE_GLOBAL_DATA_PTR;
 #define CONFIG_SYS_UBOOT_START	CONFIG_SYS_TEXT_BASE
 #endif
 #ifndef CONFIG_SYS_MONITOR_LEN
+/* Unknown U-Boot size, let's assume it will not be more than 200 KB */
 #define CONFIG_SYS_MONITOR_LEN	(200 * 1024)
 #endif
 

@@ -92,7 +93,6 @@ void spl_parse_image_header(const struct image_header *header)
 		/* Signature not found - assume u-boot.bin */
 		debug("mkimage signature not found - ih_magic = %x\n",
 			header->ih_magic);
-		/* Let's assume U-Boot will not be more than 200 KB */
 		spl_image.size = CONFIG_SYS_MONITOR_LEN;
 		spl_image.entry_point = CONFIG_SYS_UBOOT_START;
 		spl_image.load_addr = CONFIG_SYS_TEXT_BASE;
Signature · 1 line
1.9.3 (Apple Git-50)
#1 lore raw
Quoted 6 lines · Andreas Bie?mann

From: Andreas Bie?mann <[email protected]>

Commit ae83d882f5fdf7aa7c5aec09cfafb593153c25d6 moved the fixed size mentioned in the comment but missed the comment.

Signed-off-by Andreas Bie?mann <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141027/f5958c6e/attachment.pgp>