Skip to contentSkip to conversation

Remove unused variables from ssl_verify_openssl.c extract_x509_extension()

PATCH In review Steffan Karger 2 participants 3 messages Oct 25, 2014

lore
Share & tools
lore

Steffan Karger

author
#0 lore raw

PATCH 1/1 Remove unused variables from ssl_verify_openssl.c extract_x509_extension()

Signed-off-by Steffan Karger <[email protected]...>
---
 src/openvpn/ssl_verify_openssl.c | 2 --
 1 file changed, 2 deletions(-)
src/openvpn/ssl_verify_openssl.c +0 -2
index 56e1c11..33cd757 100644
@@ -101,9 +101,7 @@ static
 bool extract_x509_extension(X509 *cert, char *fieldname, char *out, int size)
 {
   bool retval = false;
-  X509_EXTENSION *pExt;
   char *buf = 0;
-  int length = 0;
   GENERAL_NAMES *extensions;
   int nid = OBJ_txt2nid(fieldname);
Signature · 1 line
1.9.1
#1 lore raw

ACK.

Your patch has been applied to the release/2.3 branch.

commit 6e469f46e94b2bd0fc1509f2bfbda4d6b5374b14

Author: Steffan Karger
Date:   Sat Oct 25 11:54:11 2014 +0200
     Remove unused variables from ssl_verify_openssl.c extract_x509_extension()

     Signed-off-by: Steffan Karger <[email protected]...>
     Acked-by: Gert Doering <[email protected]...>
     Message-Id: <[email protected]...>
     URL: http://article.gmane.org/gmane.network.openvpn.devel/9195
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering

#2 lore raw

Hi,

Quoted 3 lines · Gert Doering

ACK.

Your patch has been applied to the release/2.3 branch.

... and to master. Given the comment on IRC I wasn't sure if that was only 2.3-specific (like the first patch) or "both branches" (this one :) ).

Quoted 1 line

commit 6e469f46e94b2bd0fc1509f2bfbda4d6b5374b14 (2.3)

commit 86fe01897b9ec3f30c23395cc757f0e0b1393b03 (master)

so, untypical sequence, applied to 2.3 and cherry-picked to master, but in the end, it's a trivial and obviously-correct cleanup.

gert

Signature · 4 lines
USENET is *not* the non-clickable part of WWW!
                                                           //www.muc.de/~gert/
Gert Doering - Munich, Germany                             [email protected]...
fax: +49-89-35655025                        [email protected]...