Skip to contentSkip to conversation

blktap: CONFIG_GCRYPT detection

PATCH In review Martin Pohlack 2 participants 2 messages Oct 28, 2014 – Nov 4, 2014

lore
Share & tools
lore

Martin Pohlack

author
#0 lore raw

PATCH 1/1 blktap: CONFIG_GCRYPT detection

Wrap make variable in () to allow correct evaluation.

This fixes broken CONFIG_GCRYPT detection which was introduced by commit 85896a7c4dc7b6b1dba2db79dfb0ca61738a92a4 in 2012.

Signed-off-by Martin Pohlack <[email protected]>
Reviewed-by Uwe Dannowski <[email protected]>
Reviewed-by Anthony Liguori <[email protected]>
Reviewed-by Matt Wilson <[email protected]>
---
 tools/blktap/drivers/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/blktap/drivers/Makefile +1 -1
index 7461a95..cea8b3b 100644
@@ -11,7 +11,7 @@ CFLAGS   += $(CFLAGS_libxenctrl)
 CFLAGS   += $(CFLAGS_libxenstore)
 CFLAGS   += -D_GNU_SOURCE
 
-ifeq ($CONFIG_GCRYPT,y)
+ifeq ($(CONFIG_GCRYPT),y)
 CFLAGS += -DUSE_GCRYPT
 CRYPT_LIB := -lgcrypt
 else
Signature · 1 line
2.1.1
Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines · Martin Pohlack

Wrap make variable in () to allow correct evaluation.

This fixes broken CONFIG_GCRYPT detection which was introduced by commit 85896a7c4dc7b6b1dba2db79dfb0ca61738a92a4 in 2012.

Signed-off-by Martin Pohlack <[email protected]>
Reviewed-by Uwe Dannowski <[email protected]>
Reviewed-by Anthony Liguori <[email protected]>
Reviewed-by Matt Wilson <[email protected]>
Acked-by Ian Campbell <[email protected]>

You didn't mention if you considered this 4.5 material, but I think it is a pretty obvious/safe bugfix so I've applied it.

Quoted 17 lines
---
 tools/blktap/drivers/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/blktap/drivers/Makefile +1 -1
index 7461a95..cea8b3b 100644
@@ -11,7 +11,7 @@ CFLAGS   += $(CFLAGS_libxenctrl)
 CFLAGS   += $(CFLAGS_libxenstore)
 CFLAGS   += -D_GNU_SOURCE
 
-ifeq ($CONFIG_GCRYPT,y)
+ifeq ($(CONFIG_GCRYPT),y)
 CFLAGS += -DUSE_GCRYPT
 CRYPT_LIB := -lgcrypt
 else