ppc64: erase unnecessary segment info printing
Subsystems (2)
PATCH 1/1 ppc64: erase unnecessary segment info printing
In ppc64 loading, it will print the segment information. This is not wanted since other Archs don't have this. People even think there's something wrong. So erase it to make it be consistent with other Archs.
And if people really want to check these info, they can specify "-d" option. They are printed in print_segments() too.
--- kexec/arch/ppc64/kexec-elf-ppc64.c | 4 ---- 1 file changed, 4 deletions(-)
kexec/arch/ppc64/kexec-elf-ppc64.c +0 -4
@@ -377,10 +377,6 @@ int elf_ppc64_load(int argc, char **argv, const char *buf, off_t len,dbgprintf ("opal_base is %llx\n" , (unsigned long long ) my_opal_base);dbgprintf ("opal_entry is %llx\n" , (unsigned long long ) my_opal_entry); -for (i =0 ; i < info->nr_segments; i++) -fprintf (stderr,"segment[%d].mem:%p memsz:%zu\n" , i, - info->segment[i].mem, info->segment[i].memsz); -return 0 ; }
Signature · 7 lines
1.9.0 _______________________________________________ kexec mailing list [email protected] http://lists.infradead.org/mailman/listinfo/kexec
Hi Simon,
ping.
Could you please have a look at this patch and merge it if you think it's OK?
Thanks
Baoquan
Quoted 35 lines · Baoquan He
In ppc64 loading, it will print the segment information. This is not wanted since other Archs don't have this. People even think there's something wrong. So erase it to make it be consistent with other Archs.
And if people really want to check these info, they can specify "-d" option. They are printed in
print_segments()too.Signed-off-by Baoquan He <[email protected]>--- kexec/arch/ppc64/kexec-elf-ppc64.c | 4 ---- 1 file changed, 4 deletions(-)kexec/arch/ppc64/kexec-elf-ppc64.c +0
-4@@ -377,10 +377,6 @@ int elf_ppc64_load(int argc, char **argv, const char *buf, off_t len,dbgprintf ("opal_base is %llx\n" , (unsigned long long ) my_opal_base);dbgprintf ("opal_entry is %llx\n" , (unsigned long long ) my_opal_entry); -for (i =0 ; i < info->nr_segments; i++) -fprintf (stderr,"segment[%d].mem:%p memsz:%zu\n" , i, - info->segment[i].mem, info->segment[i].memsz); -return 0 ; }Signature · 7 lines
1.9.0 _______________________________________________ kexec mailing list [email protected] http://lists.infradead.org/mailman/listinfo/kexec
_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec
Simon Horman
AppliedQuoted 8 lines · Baoquan He
In ppc64 loading, it will print the segment information. This is not wanted since other Archs don't have this. People even think there's something wrong. So erase it to make it be consistent with other Archs.
And if people really want to check these info, they can specify "-d" option. They are printed in
print_segments()too.Signed-off-by Baoquan He <[email protected]>
Thanks, applied.
Quoted 22 lines
--- kexec/arch/ppc64/kexec-elf-ppc64.c | 4 ---- 1 file changed, 4 deletions(-)kexec/arch/ppc64/kexec-elf-ppc64.c +0
-4@@ -377,10 +377,6 @@ int elf_ppc64_load(int argc, char **argv, const char *buf, off_t len,dbgprintf ("opal_base is %llx\n" , (unsigned long long ) my_opal_base);dbgprintf ("opal_entry is %llx\n" , (unsigned long long ) my_opal_entry); -for (i =0 ; i < info->nr_segments; i++) -fprintf (stderr,"segment[%d].mem:%p memsz:%zu\n" , i, - info->segment[i].mem, info->segment[i].memsz); -return 0 ; }Signature · 1 line
1.9.0
_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec
Quoted 11 lines · Simon Horman
Quoted 8 lines · Baoquan He
In ppc64 loading, it will print the segment information. This is not wanted since other Archs don't have this. People even think there's something wrong. So erase it to make it be consistent with other Archs.
And if people really want to check these info, they can specify "-d" option. They are printed in
print_segments()too.Signed-off-by Baoquan He <[email protected]>Thanks, applied.
Thanks, Simon.
Quoted 20 lines
Quoted 20 lines
--- kexec/arch/ppc64/kexec-elf-ppc64.c | 4 ---- 1 file changed, 4 deletions(-)kexec/arch/ppc64/kexec-elf-ppc64.c +0
-4@@ -377,10 +377,6 @@ int elf_ppc64_load(int argc, char **argv, const char *buf, off_t len,dbgprintf ("opal_base is %llx\n" , (unsigned long long ) my_opal_base);dbgprintf ("opal_entry is %llx\n" , (unsigned long long ) my_opal_entry); -for (i =0 ; i < info->nr_segments; i++) -fprintf (stderr,"segment[%d].mem:%p memsz:%zu\n" , i, - info->segment[i].mem, info->segment[i].memsz); -return 0 ; }
Quoted 3 lines
Quoted 3 lines
Signature · 1 line
1.9.0
_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec