CRISv32: ETRAX_SPI_MMC_BOARD
Jesper,
Your commit be64c1ce6e79 ("CRISv32: Drop obsolete file for SPI driver") landed in today's linux-next (ie, next-20141029). It removes the last user of the Kconfig symbol ETRAX_SPI_MMC_BOARD. Setting that symbol is now pointless.
Is the trivial patch to remove the entry for ETRAX_SPI_MMC_BOARD (and one select statement for it) queued somewhere? If not, should I submit it?
Paul Bolle
Quoted 1 line · Paul Bolle
Jesper,
Hi Paul!
Quoted 8 lines
Your commit
be64c1ce6e79("CRISv32: Drop obsolete file for SPI driver") landed in today's linux-next (ie, next-20141029). It removes the last user of theKconfigsymbolETRAX_SPI_MMC_BOARD. Setting that symbol is now pointless.Is the trivial patch to remove the entry for
ETRAX_SPI_MMC_BOARD(and one select statement for it) queued somewhere? If not, should I submit it?
It was not, but it is now:
CRISv32: Remove last remnants of ETRAX_SPI_MMC_BOARD
There are no users of this symbol left.
--- arch/cris/arch-v32/drivers/Kconfig | 7 ------- 1 file changed, 7 deletions(-)
arch/cris/arch-v32/drivers/Kconfig +0 -7
@@ -361,13 +361,6 @@ config ETRAX_SPI_MMC default MMC select SPI select MMC_SPI - select ETRAX_SPI_MMC_BOARD - -# For the parts that can't be a module (due to restrictions in -# framework elsewhere). -config ETRAX_SPI_MMC_BOARD - boolean - default n # While the board info is MMC_SPI only, the drivers are written to be # independent of MMC_SPI, so we'll keep SPI non-dependent on the
Signature · 8 lines
1.7.10.4 I'll try to think about unreferenced kconfigs in the future, my suspicion is that all those SPI and MMC related configs are also unused, just circular references keeping them unnoticed. Thanks for the heads up.
Quoted 1 line
Paul Bolle
/^JN - Jesper Nilsson
Signature · 1 line
Jesper Nilsson -- [email protected]
Hi Jesper,
Quoted 45 lines · Jesper Nilsson
Quoted 8 lines · Paul Bolle
Your commit
be64c1ce6e79("CRISv32: Drop obsolete file for SPI driver") landed in today's linux-next (ie, next-20141029). It removes the last user of theKconfigsymbolETRAX_SPI_MMC_BOARD. Setting that symbol is now pointless.Is the trivial patch to remove the entry for
ETRAX_SPI_MMC_BOARD(and one select statement for it) queued somewhere? If not, should I submit it?It was not, but it is now:
CRISv32: Remove last remnants of
ETRAX_SPI_MMC_BOARDThere are no users of this symbol left.
Reported-by Paul Bolle <[email protected]>Signed-off-by Jesper Nilsson <[email protected]>--- arch/cris/arch-v32/drivers/Kconfig | 7 ------- 1 file changed, 7 deletions(-)arch/cris/arch-v32/drivers/Kconfig +0
-7@@ -361,13 +361,6 @@ config ETRAX_SPI_MMC default MMC select SPI select MMC_SPI - select ETRAX_SPI_MMC_BOARD - -# For the parts that can't be a module (due to restrictions in -# framework elsewhere). -config ETRAX_SPI_MMC_BOARD - boolean - default n # While the board info is MMC_SPI only, the drivers are written to be # independent of MMC_SPI, so we'll keep SPI non-dependent on theSignature · 4 lines
1.7.10.4 I'll try to think about unreferenced kconfigs in the future,
I'm hoping that Valentin's project will automate detection of these kind of problems for you (see
http://www.linuxplumbersconf.org/2014/ocw/sessions/1863 ).
Quoted 2 lines
my suspicion is that all those SPI and MMC related configs are also unused, just circular references keeping them unnoticed.
Would you have an example?
(I try to check each linux-next release with a 800 line perl monster. It's just smart enough to detect cases like this. Ie, a Kconfig entry, whose Kconfig macro isn't used anywhere in the tree, that is not selecting anything, but that itself is a _target_ of a select statement.
It's not entirely trivial to detect things like that. But perhaps I could still tweak the tests of that this script to detect even more unused Kconfig symbols.)
Quoted 1 line
Thanks for the heads up.
You're welcome. And thanks for taking care of this. Experience shows that these cleanups go more smoothly if maintainers, actual users, etc., do them (instead of random contributors, like me, who are not familiar with the subsystem they're touching).
Paul Bolle