Skip to contentSkip to conversation

ARM: dts: imx6sx-sdb: Allow wakeup from buttons

PATCH New Fabio Estevam 2 participants 2 messages Oct 29, 2014 – Nov 3, 2014

Subsystems (2)
Device tree bindings Arm i.MX and Layerscape
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 ARM: dts: imx6sx-sdb: Allow wakeup from buttons

From: Fabio Estevam <[email protected]>

Allow the two button wakeup the system from low power mode.

Signed-off-by Fabio Estevam <[email protected]>
---
 arch/arm/boot/dts/imx6sx-sdb.dts | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/boot/dts/imx6sx-sdb.dts +2 -0
index 448489b..80ae281 100644
@@ -39,12 +39,14 @@
 		volume-up {
 			label = "Volume Up";
 			gpios = <&gpio1 18 GPIO_ACTIVE_LOW>;
+			gpio-key,wakeup;
 			linux,code = <KEY_VOLUMEUP>;
 		};
 
 		volume-down {
 			label = "Volume Down";
 			gpios = <&gpio1 19 GPIO_ACTIVE_LOW>;
+			gpio-key,wakeup;
 			linux,code = <KEY_VOLUMEDOWN>;
 		};
 	};
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 ARM: dts: imx6sx-sdb: Allow wakeup from buttons

Quoted 14 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Allow the two button wakeup the system from low power mode.

Signed-off-by Fabio Estevam <[email protected]>
---
 arch/arm/boot/dts/imx6sx-sdb.dts | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/boot/dts/imx6sx-sdb.dts +0 -0
index 448489b..80ae281 100644

arch/arm/boot/dts/imx6sx-sdb.dts line 42

Quoted 4 lines
arch/arm/boot/dts/imx6sx-sdb.dts +1 -0
@@ -39,12 +39,14 @@
 		volume-up {
 			label = "Volume Up";
 			gpios = <&gpio1 18 GPIO_ACTIVE_LOW>;
+			gpio-key,wakeup;

I can understand that this is convenient for developers, but I'm not really sure if it's reasonable for users. IOW, is it expected that volume keys can wake up system from low power mode? Or we should only allow that from power key?

Shawn

Quoted 13 lines
arch/arm/boot/dts/imx6sx-sdb.dts +1 -0
 			linux,code = <KEY_VOLUMEUP>;
 		};
 
 		volume-down {
 			label = "Volume Down";
 			gpios = <&gpio1 19 GPIO_ACTIVE_LOW>;
+			gpio-key,wakeup;
 			linux,code = <KEY_VOLUMEDOWN>;
 		};
 	};
Signature · 1 line
1.9.1