Skip to contentSkip to conversation

eal_pci.c: pci_scan_one: fix inaccurate NUMA node error comment

PATCH Applied Matthew Hall 3 participants 3 messages Oct 30, 2014 – Nov 5, 2014 1 message not in the archive

lore
Share & tools
lore

Matthew Hall

author
#0 lore raw

PATCH 1/1 eal_pci.c: pci_scan_one: fix inaccurate NUMA node error comment

Signed-off-by Matthew Hall <[email protected]>
---
 lib/librte_eal/linuxapp/eal/eal_pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/librte_eal/linuxapp/eal/eal_pci.c +1 -1
index 5fe3961..ddb0535 100644
@@ -266,7 +266,7 @@ pci_scan_one(const char *dirname, uint16_t domain, uint8_t bus,
 	snprintf(filename, sizeof(filename), "%s/numa_node",
 		 dirname);
 	if (access(filename, R_OK) != 0) {
-		/* if no NUMA support just set node to 0 */
+		/* if no NUMA support just set node to -1 */
 		dev->numa_node = -1;
 	} else {
 		if (eal_parse_sysfs_value(filename, &tmp) < 0) {
Signature · 1 line
1.9.1

A message that is not in the archive (sent off-list or not yet received): 1414640408-10118-1-git-send-email-mhall-Hv3ogNYU3JfZZajBQzqCxQ@public.gmane.org

Acked-by
#2 lore raw
Quoted 1 line · Matthew Hall
Signed-off-by Matthew Hall <[email protected]>
Acked-by Bruce Richardson <[email protected]>
Quoted 20 lines
---
 lib/librte_eal/linuxapp/eal/eal_pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/librte_eal/linuxapp/eal/eal_pci.c +1 -1
index 5fe3961..ddb0535 100644
@@ -266,7 +266,7 @@ pci_scan_one(const char *dirname, uint16_t domain, uint8_t bus,
 	snprintf(filename, sizeof(filename), "%s/numa_node",
 		 dirname);
 	if (access(filename, R_OK) != 0) {
-		/* if no NUMA support just set node to 0 */
+		/* if no NUMA support just set node to -1 */
 		dev->numa_node = -1;
 	} else {
 		if (eal_parse_sysfs_value(filename, &tmp) < 0) {
Signature · 1 line
1.9.1