Support PMIC operation region for CrystalCove and XPower

PATCH Superseded Aaron Lu 3 participants 13 messages Oct 31, 2014 – Nov 13, 2014

Subsystems (5)

ACPI IIO Multifunction devices (MFD) X-powers multifunction PMIC device drivers +1 more subsystems

lore

Share & tools

lore

Aaron Lu

author

2014-10-31 06:08 UTC #0 lore raw

cover Support PMIC operation region for CrystalCove and XPower

On Intel Baytrail-T and Baytrail-T-CR platforms, there are two customized ACPI operation regions defined for the Power Management Integrated Circuit device, one is for power resource handling and one is for thermal: sensor temperature reporting, trip point setting, etc. There are different PMIC chips used on those platforms and though each has the same two operation regions and functionality, their implementation is different so every PMIC will need a driver. But since their functionality is similar, some common code is abstracted into the intel_soc_pmic_opregion.c.

The last version is posted here:
https://lkml.org/lkml/2014/9/8/801

Changes since then:
1 Move to drivers/acpi as discussed on the above thread;
2 Added support for XPower AXP288 PMIC operation region support; 3 Since operation region handler can not be removed(at the moment at least),
use bool for the two operation region driver configs instead of tristate; Another reason to do this is that, with Mika's MFD ACPI support patch, all those MFD cell devices created will have the same modalias as their parent's so it doesn't make much sense to compile these drivers into modules.

Patch 1 applies on top of Rafael's pm-next branch, and then patch 2 and patch 3 needs merge of Lee's mfd/ib-mfd-iio-3.19 branch where the PMIC driver XPower AXP288 and iio driver axp288_adc is located.

Aaron Lu (3):
ACPI / pmic_opregion: support PMIC operation region for CrystalCove ACPI / pmic_opregion: support PMIC operation region for XPower AXP288 ACPI / pmic_opregion: AXP288: support virtual GPIO in ACPI table

Aaron Lu

author

2014-10-31 06:08 UTC #1 lore raw

PATCH 1/3 ACPI / pmic_opregion: support PMIC operation region for CrystalCove

The Baytrail-T platform firmware has defined two customized operation regions for PMIC chip Crystal Cove - one is for power resource handling and one is for thermal: sensor temperature reporting, trip point setting, etc. This patch adds support for them on top of the existing Crystal Cove PMIC driver.

The reason to split code into a separate file intel_soc_pmic_opregion.c is that there are more PMIC driver with ACPI operation region support coming and we can re-use those code. The intel_soc_pmic_opregion_data structure is created also for this purpose: when we need to support a new PMIC's operation region, we just need to fill those callbacks and the two register mapping tables.

Signed-off-by Aaron Lu <[email protected]>

---
 drivers/acpi/Kconfig                               |  17 +
 drivers/acpi/Makefile                              |   3 +
 .../pmic_opregion/intel_soc_pmic_crc_opregion.c    | 216 +++++++++++++
 .../acpi/pmic_opregion/intel_soc_pmic_opregion.c   | 341 +++++++++++++++++++++
 .../acpi/pmic_opregion/intel_soc_pmic_opregion.h   |  34 ++
 drivers/mfd/intel_soc_pmic_crc.c                   |   3 +
 6 files changed, 614 insertions(+)
 create mode 100644 drivers/acpi/pmic_opregion/intel_soc_pmic_crc_opregion.c
 create mode 100644 drivers/acpi/pmic_opregion/intel_soc_pmic_opregion.c
 create mode 100644 drivers/acpi/pmic_opregion/intel_soc_pmic_opregion.h

drivers/acpi/Kconfig +17 -0

index b23fe37f67c0..df816456dc06 100644
@@ -394,4 +394,21 @@ config ACPI_EXTLOG
 	  driver adds support for that functionality with corresponding
 	  tracepoint which carries that information to userspace.
 
+menuconfig PMIC_OPREGION
+	bool "PMIC (Power Management Integrated Circuit) operation region support"
+	help
+	  Select this option to enable support for ACPI operation
+	  region of the PMIC chip. The operation region can be used
+	  to control power rails and sensor reading/writing on the
+	  PMIC chip.
+
+if PMIC_OPREGION
+config CRC_PMIC_OPREGION
+	bool "ACPI operation region support for CrystalCove PMIC"
+	depends on INTEL_SOC_PMIC
+	help
+	  This config adds ACPI operation region support for CrystalCove PMIC.
+
+endif
+
 endif	# ACPI

drivers/acpi/Makefile +3 -0

index 6d11522f0e48..123f0f159bdc 100644
@@ -88,3 +88,6 @@ obj-$(CONFIG_ACPI_PROCESSOR_AGGREGATOR) += acpi_pad.o
 obj-$(CONFIG_ACPI_APEI)		+= apei/
 
 obj-$(CONFIG_ACPI_EXTLOG)	+= acpi_extlog.o
+
+obj-$(CONFIG_PMIC_OPREGION)	+= pmic_opregion/intel_soc_pmic_opregion.o
+obj-$(CONFIG_CRC_PMIC_OPREGION) += pmic_opregion/intel_soc_pmic_crc_opregion.o

drivers/acpi/pmic_opregion/intel_soc_pmic_crc_opregion.c new file +216 -0

216 lines not on this page · raw message

drivers/acpi/pmic_opregion/intel_soc_pmic_opregion.c new file +341 -0

341 lines not on this page · raw message

drivers/acpi/pmic_opregion/intel_soc_pmic_opregion.h new file +34 -0

new file mode 100644
index 000000000000..3c21eeb1a775
@@ -0,0 +1,34 @@
+#ifndef __INTEL_SOC_PMIC_OPREGION_H
+#define __INTEL_SOC_PMIC_OPREGION_H
+
+struct pmic_pwr_reg {
+	int reg;	/* corresponding PMIC register */
+	int bit;	/* control bit for power */
+};
+
+struct pmic_pwr_table {
+	int address;	/* operation region address */
+	struct pmic_pwr_reg pwr_reg;
+};
+
+struct pmic_dptf_table {
+	int address;	/* operation region address */
+	int reg;	/* corresponding thermal register */
+};
+
+struct intel_soc_pmic_opregion_data {
+	int (*get_power)(struct regmap *r, struct pmic_pwr_reg *preg, u64 *value);
+	int (*update_power)(struct regmap *r, struct pmic_pwr_reg *preg, bool on);
+	int (*get_raw_temp)(struct regmap *r, int reg);
+	int (*update_aux)(struct regmap *r, int reg, int raw_temp);
+	int (*get_policy)(struct regmap *r, int reg, u64 *value);
+	int (*update_policy)(struct regmap *r, int reg, int enable);
+	struct pmic_pwr_table *pwr_table;
+	int pwr_table_count;
+	struct pmic_dptf_table *dptf_table;
+	int dptf_table_count;
+};
+
+int intel_soc_pmic_install_opregion_handler(struct device *dev, acpi_handle handle, struct regmap *regmap, struct intel_soc_pmic_opregion_data *d);
+
+#endif

drivers/mfd/intel_soc_pmic_crc.c +3 -0

index 7107cab832e6..48845d636bba 100644
@@ -106,6 +106,9 @@ static struct mfd_cell crystal_cove_dev[] = {
 		.num_resources = ARRAY_SIZE(gpio_resources),
 		.resources = gpio_resources,
 	},
+	{
+		.name = "crystal_cove_region",
+	},
 };
 
 static struct regmap_config crystal_cove_regmap_config = {

Signature · 1 line

1.9.3

Aaron Lu

author

2014-10-31 06:08 UTC #2 lore raw

PATCH 2/3 ACPI / pmic_opregion: support PMIC operation region for XPower AXP288

In reply to Aaron Lu

The Baytrail-T-CR platform firmware has defined two customized operation regions for PMIC chip Dollar Cove XPower - one is for power resource handling and one is for thermal just like the CrystalCove one. This patch adds support for them on top of the common PMIC opregion region code.

Signed-off-by Aaron Lu <[email protected]>

---
 drivers/acpi/Kconfig                               |   6 +
 drivers/acpi/Makefile                              |   1 +
 .../pmic_opregion/intel_soc_pmic_xpower_opregion.c | 277 +++++++++++++++++++++
 drivers/mfd/axp20x.c                               |   3 +
 4 files changed, 287 insertions(+)
 create mode 100644 drivers/acpi/pmic_opregion/intel_soc_pmic_xpower_opregion.c

drivers/acpi/Kconfig +6 -0

index df816456dc06..1b7b753cadcc 100644
@@ -409,6 +409,12 @@ config CRC_PMIC_OPREGION
 	help
 	  This config adds ACPI operation region support for CrystalCove PMIC.
 
+config XPOWER_PMIC_OPREGION
+	bool "ACPI operation region support for XPower AXP288 PMIC"
+	depends on AXP288_ADC
+	help
+	  This config adds ACPI operation region support for XPower AXP288 PMIC.
+
 endif
 
 endif	# ACPI

drivers/acpi/Makefile +1 -0

index 123f0f159bdc..f2a6a1d56ef7 100644
@@ -91,3 +91,4 @@ obj-$(CONFIG_ACPI_EXTLOG)	+= acpi_extlog.o
 
 obj-$(CONFIG_PMIC_OPREGION)	+= pmic_opregion/intel_soc_pmic_opregion.o
 obj-$(CONFIG_CRC_PMIC_OPREGION) += pmic_opregion/intel_soc_pmic_crc_opregion.o
+obj-$(CONFIG_XPOWER_PMIC_OPREGION) += pmic_opregion/intel_soc_pmic_xpower_opregion.o

drivers/acpi/pmic_opregion/intel_soc_pmic_xpower_opregion.c new file +277 -0

277 lines not on this page · raw message

drivers/mfd/axp20x.c +3 -0

index acbb4c3bf98c..daf3c8d33b4d 100644
@@ -354,6 +354,9 @@ static struct mfd_cell axp288_cells[] = {
 		.num_resources = ARRAY_SIZE(axp288_battery_resources),
 		.resources = axp288_battery_resources,
 	},
+	{
+		.name = "axp288_opregion",
+	},
 };
 
 static struct axp20x_dev *axp20x_pm_power_off;

Signature · 1 line

1.9.3

Aaron Lu

author

2014-10-31 06:08 UTC #3 lore raw

PATCH 3/3 ACPI / pmic_opregion: AXP288: support virtual GPIO in ACPI table

In reply to Aaron Lu

The same virtual GPIO strategy is also used for the AXP288 PMIC in that various control methods that are used to do power rail handling and sensor reading/setting will touch GPIO fields defined under the PMIC device. The GPIO fileds are only defined by the ACPI code while the actual hardware doesn't really have a GPIO controller, but to make those control method execution succeed, we have to install a GPIO handler for the PMIC device handle. Since we do not need the virtual GPIO strategy, we can simply do nothing in that handler.

Signed-off-by Aaron Lu <[email protected]>

---
 .../pmic_opregion/intel_soc_pmic_xpower_opregion.c | 27 ++++++++++++++++++----
 1 file changed, 23 insertions(+), 4 deletions(-)

drivers/acpi/pmic_opregion/intel_soc_pmic_xpower_opregion.c +23 -4

index ab462708aecf..e25c83da90a5 100644
@@ -251,13 +251,32 @@ static struct intel_soc_pmic_opregion_data intel_xpower_pmic_opregion_data = {
 	.dptf_table_count = ARRAY_SIZE(dptf_table),
 };
 
+static acpi_status intel_xpower_pmic_gpio_handler(u32 function,
+		acpi_physical_address address, u32 bit_width, u64 *value,
+		void *handler_context, void *region_context)
+{
+	return AE_OK;
+}
 
 static int intel_xpower_pmic_opregion_probe(struct platform_device *pdev)
 {
-	struct axp20x_dev *axp20x = dev_get_drvdata(pdev->dev.parent);
-	return intel_soc_pmic_install_opregion_handler(&pdev->dev,
-			ACPI_HANDLE(pdev->dev.parent), axp20x->regmap,
-			&intel_xpower_pmic_opregion_data);
+	struct device *parent = pdev->dev.parent;
+	struct axp20x_dev *axp20x = dev_get_drvdata(parent);
+	acpi_status status;
+	int result;
+
+	result = intel_soc_pmic_install_opregion_handler(&pdev->dev,
+					ACPI_HANDLE(parent), axp20x->regmap,
+					&intel_xpower_pmic_opregion_data);
+	if (!result) {
+		status = acpi_install_address_space_handler(
+				ACPI_HANDLE(parent), ACPI_ADR_SPACE_GPIO,
+				intel_xpower_pmic_gpio_handler, NULL, NULL);
+		if (ACPI_FAILURE(status))
+			result = -ENODEV;
+	}
+
+	return result;
 }
 
 static struct platform_driver intel_xpower_pmic_opregion_driver = {

Signature · 1 line

1.9.3

Aaron Lu

author

2014-11-11 02:04 UTC #4 lore raw

In reply to Aaron Lu

Quoted 21 lines · Aaron Lu

On Intel Baytrail-T and Baytrail-T-CR platforms, there are two customized ACPI operation regions defined for the Power Management Integrated Circuit device, one is for power resource handling and one is for thermal: sensor temperature reporting, trip point setting, etc. There are different PMIC chips used on those platforms and though each has the same two operation regions and functionality, their implementation is different so every PMIC will need a driver. But since their functionality is similar, some common code is abstracted into the intel_soc_pmic_opregion.c.
The last version is posted here:
https://lkml.org/lkml/2014/9/8/801
Changes since then:
1 Move to drivers/acpi as discussed on the above thread;
2 Added support for XPower AXP288 PMIC operation region support; 3 Since operation region handler can not be removed(at the moment at least),
use bool for the two operation region driver configs instead of tristate; Another reason to do this is that, with Mika's MFD ACPI support patch, all those MFD cell devices created will have the same modalias as their parent's so it doesn't make much sense to compile these drivers into modules.

Quoted 3 lines

Patch 1 applies on top of Rafael's pm-next branch, and then patch 2 and patch 3 needs merge of Lee's mfd/ib-mfd-iio-3.19 branch where the PMIC driver XPower AXP288 and iio driver axp288_adc is located.

Since patch 2-3 are based on top of the mfd/ib-mfd-iio-3.19 branch, it would be easy to go through the mfd/ib-mfd-iio-3.19 branch.

Rafael,
Can I get your ACK for the three patches?

Lee,
Can you please take the series if Rafael gives it ack?

Thanks,
Aaron

Quoted 12 lines

Aaron Lu (3):
ACPI / pmic_opregion: support PMIC operation region for CrystalCove ACPI / pmic_opregion: support PMIC operation region for XPower AXP288 ACPI / pmic_opregion: AXP288: support virtual GPIO in ACPI table
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Lee Jones

2014-11-11 11:11 UTC #5 lore raw

Quoted 26 lines · Aaron Lu

Quoted 21 lines · Aaron Lu
On Intel Baytrail-T and Baytrail-T-CR platforms, there are two customized ACPI operation regions defined for the Power Management Integrated Circuit device, one is for power resource handling and one is for thermal: sensor temperature reporting, trip point setting, etc. There are different PMIC chips used on those platforms and though each has the same two operation regions and functionality, their implementation is different so every PMIC will need a driver. But since their functionality is similar, some common code is abstracted into the intel_soc_pmic_opregion.c.
The last version is posted here:
https://lkml.org/lkml/2014/9/8/801
Changes since then:
1 Move to drivers/acpi as discussed on the above thread;
2 Added support for XPower AXP288 PMIC operation region support; 3 Since operation region handler can not be removed(at the moment at least),
use bool for the two operation region driver configs instead of tristate; Another reason to do this is that, with Mika's MFD ACPI support patch, all those MFD cell devices created will have the same modalias as their parent's so it doesn't make much sense to compile these drivers into modules.
Quoted 3 lines
Patch 1 applies on top of Rafael's pm-next branch, and then patch 2 and patch 3 needs merge of Lee's mfd/ib-mfd-iio-3.19 branch where the PMIC driver XPower AXP288 and iio driver axp288_adc is located.

Quoted 8 lines

Since patch 2-3 are based on top of the mfd/ib-mfd-iio-3.19 branch, it would be easy to go through the mfd/ib-mfd-iio-3.19 branch.
Rafael,
Can I get your ACK for the three patches?
Lee,
Can you please take the series if Rafael gives it ack?

Yes, no problem.

Quoted 6 lines

Quoted 5 lines
Aaron Lu (3):
ACPI / pmic_opregion: support PMIC operation region for CrystalCove ACPI / pmic_opregion: support PMIC operation region for XPower AXP288 ACPI / pmic_opregion: AXP288: support virtual GPIO in ACPI table

Signature · 4 lines

Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Rafael J. Wysocki

2014-11-11 23:14 UTC #6 lore raw

Quoted 31 lines · Lee Jones

Quoted 29 lines · Aaron Lu
Quoted 21 lines · Aaron Lu
On Intel Baytrail-T and Baytrail-T-CR platforms, there are two customized ACPI operation regions defined for the Power Management Integrated Circuit device, one is for power resource handling and one is for thermal: sensor temperature reporting, trip point setting, etc. There are different PMIC chips used on those platforms and though each has the same two operation regions and functionality, their implementation is different so every PMIC will need a driver. But since their functionality is similar, some common code is abstracted into the intel_soc_pmic_opregion.c.
The last version is posted here:
https://lkml.org/lkml/2014/9/8/801
Changes since then:
1 Move to drivers/acpi as discussed on the above thread;
2 Added support for XPower AXP288 PMIC operation region support; 3 Since operation region handler can not be removed(at the moment at least),
use bool for the two operation region driver configs instead of tristate; Another reason to do this is that, with Mika's MFD ACPI support patch, all those MFD cell devices created will have the same modalias as their parent's so it doesn't make much sense to compile these drivers into modules.
Quoted 3 lines
Patch 1 applies on top of Rafael's pm-next branch, and then patch 2 and patch 3 needs merge of Lee's mfd/ib-mfd-iio-3.19 branch where the PMIC driver XPower AXP288 and iio driver axp288_adc is located.
Since patch 2-3 are based on top of the mfd/ib-mfd-iio-3.19 branch, it would be easy to go through the mfd/ib-mfd-iio-3.19 branch.

Quoted 7 lines

Quoted 5 lines
Rafael,
Can I get your ACK for the three patches?
Lee,
Can you please take the series if Rafael gives it ack?
Yes, no problem.

Well, since the code is going to reside mostly in drivers/acpi, I think I should be applying the patches and from your response it looks like you are fine with them. Is that correct?

Rafael

Aaron Lu

author

2014-11-12 01:48 UTC #7 lore raw

Quoted 35 lines · Rafael J. Wysocki

Quoted 34 lines · Lee Jones
Quoted 32 lines · Aaron Lu
Quoted 21 lines · Aaron Lu
On Intel Baytrail-T and Baytrail-T-CR platforms, there are two customized ACPI operation regions defined for the Power Management Integrated Circuit device, one is for power resource handling and one is for thermal: sensor temperature reporting, trip point setting, etc. There are different PMIC chips used on those platforms and though each has the same two operation regions and functionality, their implementation is different so every PMIC will need a driver. But since their functionality is similar, some common code is abstracted into the intel_soc_pmic_opregion.c.
The last version is posted here:
https://lkml.org/lkml/2014/9/8/801
Changes since then:
1 Move to drivers/acpi as discussed on the above thread;
2 Added support for XPower AXP288 PMIC operation region support; 3 Since operation region handler can not be removed(at the moment at least),
use bool for the two operation region driver configs instead of tristate; Another reason to do this is that, with Mika's MFD ACPI support patch, all those MFD cell devices created will have the same modalias as their parent's so it doesn't make much sense to compile these drivers into modules.
Quoted 3 lines
Patch 1 applies on top of Rafael's pm-next branch, and then patch 2 and patch 3 needs merge of Lee's mfd/ib-mfd-iio-3.19 branch where the PMIC driver XPower AXP288 and iio driver axp288_adc is located.
Since patch 2-3 are based on top of the mfd/ib-mfd-iio-3.19 branch, it would be easy to go through the mfd/ib-mfd-iio-3.19 branch.
Rafael,
Can I get your ACK for the three patches?

Quoted 8 lines

Quoted 4 lines
Quoted 2 lines
Lee,
Can you please take the series if Rafael gives it ack?
Yes, no problem.
Well, since the code is going to reside mostly in drivers/acpi, I think I should be applying the patches and from your response it looks like you are fine with them. Is that correct?

Oh I thought you may not want to merge another branch into your next branch so I asked this question. If you can handle the whole thing in your tree, that's of course not a problem :-)

Thanks,
Aaron

Rafael J. Wysocki

2014-11-13 00:30 UTC #8 lore raw

Quoted 41 lines · Aaron Lu

Quoted 40 lines · Rafael J. Wysocki
Quoted 38 lines · Lee Jones
Quoted 26 lines · Aaron Lu
Quoted 21 lines · Aaron Lu
On Intel Baytrail-T and Baytrail-T-CR platforms, there are two customized ACPI operation regions defined for the Power Management Integrated Circuit device, one is for power resource handling and one is for thermal: sensor temperature reporting, trip point setting, etc. There are different PMIC chips used on those platforms and though each has the same two operation regions and functionality, their implementation is different so every PMIC will need a driver. But since their functionality is similar, some common code is abstracted into the intel_soc_pmic_opregion.c.
The last version is posted here:
https://lkml.org/lkml/2014/9/8/801
Changes since then:
1 Move to drivers/acpi as discussed on the above thread;
2 Added support for XPower AXP288 PMIC operation region support; 3 Since operation region handler can not be removed(at the moment at least),
use bool for the two operation region driver configs instead of tristate; Another reason to do this is that, with Mika's MFD ACPI support patch, all those MFD cell devices created will have the same modalias as their parent's so it doesn't make much sense to compile these drivers into modules.
Quoted 3 lines
Patch 1 applies on top of Rafael's pm-next branch, and then patch 2 and patch 3 needs merge of Lee's mfd/ib-mfd-iio-3.19 branch where the PMIC driver XPower AXP288 and iio driver axp288_adc is located.
Quoted 8 lines
Since patch 2-3 are based on top of the mfd/ib-mfd-iio-3.19 branch, it would be easy to go through the mfd/ib-mfd-iio-3.19 branch.
Rafael,
Can I get your ACK for the three patches?
Lee,
Can you please take the series if Rafael gives it ack?
Yes, no problem.

Quoted 7 lines

Quoted 3 lines
Well, since the code is going to reside mostly in drivers/acpi, I think I should be applying the patches and from your response it looks like you are fine with them. Is that correct?
Oh I thought you may not want to merge another branch into your next branch so I asked this question. If you can handle the whole thing in your tree, that's of course not a problem :-)

Merging one more branch wouldn't be a problem, but we'll take care of that later.

For now, would it be possible to rename the subdir to "pmic" instead of "pmic_opregion"? The "_opregion" part doesn't seem to add much value here.

And can the names of the files be somewhat shorter too? Like "intel_pmic.[h][c]" and "intel_pmic_crc.c"?

Signature · 2 lines

I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

Aaron Lu

author

2014-11-13 08:39 UTC #9 lore raw

Quoted 50 lines · Rafael J. Wysocki

Quoted 41 lines · Aaron Lu
Quoted 40 lines · Rafael J. Wysocki
Quoted 38 lines · Lee Jones
Quoted 26 lines · Aaron Lu
Quoted 21 lines · Aaron Lu
On Intel Baytrail-T and Baytrail-T-CR platforms, there are two customized ACPI operation regions defined for the Power Management Integrated Circuit device, one is for power resource handling and one is for thermal: sensor temperature reporting, trip point setting, etc. There are different PMIC chips used on those platforms and though each has the same two operation regions and functionality, their implementation is different so every PMIC will need a driver. But since their functionality is similar, some common code is abstracted into the intel_soc_pmic_opregion.c.
The last version is posted here:
https://lkml.org/lkml/2014/9/8/801
Changes since then:
1 Move to drivers/acpi as discussed on the above thread;
2 Added support for XPower AXP288 PMIC operation region support; 3 Since operation region handler can not be removed(at the moment at least),
use bool for the two operation region driver configs instead of tristate; Another reason to do this is that, with Mika's MFD ACPI support patch, all those MFD cell devices created will have the same modalias as their parent's so it doesn't make much sense to compile these drivers into modules.
Quoted 3 lines
Patch 1 applies on top of Rafael's pm-next branch, and then patch 2 and patch 3 needs merge of Lee's mfd/ib-mfd-iio-3.19 branch where the PMIC driver XPower AXP288 and iio driver axp288_adc is located.
Quoted 8 lines
Since patch 2-3 are based on top of the mfd/ib-mfd-iio-3.19 branch, it would be easy to go through the mfd/ib-mfd-iio-3.19 branch.
Rafael,
Can I get your ACK for the three patches?
Lee,
Can you please take the series if Rafael gives it ack?
Yes, no problem.
Quoted 7 lines
Quoted 3 lines
Well, since the code is going to reside mostly in drivers/acpi, I think I should be applying the patches and from your response it looks like you are fine with them. Is that correct?
Oh I thought you may not want to merge another branch into your next branch so I asked this question. If you can handle the whole thing in your tree, that's of course not a problem :-)

Quoted 5 lines

Merging one more branch wouldn't be a problem, but we'll take care of that later.
For now, would it be possible to rename the subdir to "pmic" instead of "pmic_opregion"? The "_opregion" part doesn't seem to add much value here.

No problem.

Quoted 3 lines

And can the names of the files be somewhat shorter too? Like "intel_pmic.[h][c]" and "intel_pmic_crc.c"?

Sure, will update and send v2, thanks for the advice.

Regards,
Aaron

Lee Jones

2014-11-12 09:44 UTC #10 lore raw

In reply to Rafael J. Wysocki

Quoted 35 lines · Rafael J. Wysocki

Quoted 34 lines · Lee Jones
Quoted 32 lines · Aaron Lu
Quoted 21 lines · Aaron Lu
On Intel Baytrail-T and Baytrail-T-CR platforms, there are two customized ACPI operation regions defined for the Power Management Integrated Circuit device, one is for power resource handling and one is for thermal: sensor temperature reporting, trip point setting, etc. There are different PMIC chips used on those platforms and though each has the same two operation regions and functionality, their implementation is different so every PMIC will need a driver. But since their functionality is similar, some common code is abstracted into the intel_soc_pmic_opregion.c.
The last version is posted here:
https://lkml.org/lkml/2014/9/8/801
Changes since then:
1 Move to drivers/acpi as discussed on the above thread;
2 Added support for XPower AXP288 PMIC operation region support; 3 Since operation region handler can not be removed(at the moment at least),
use bool for the two operation region driver configs instead of tristate; Another reason to do this is that, with Mika's MFD ACPI support patch, all those MFD cell devices created will have the same modalias as their parent's so it doesn't make much sense to compile these drivers into modules.
Quoted 3 lines
Patch 1 applies on top of Rafael's pm-next branch, and then patch 2 and patch 3 needs merge of Lee's mfd/ib-mfd-iio-3.19 branch where the PMIC driver XPower AXP288 and iio driver axp288_adc is located.
Since patch 2-3 are based on top of the mfd/ib-mfd-iio-3.19 branch, it would be easy to go through the mfd/ib-mfd-iio-3.19 branch.
Rafael,
Can I get your ACK for the three patches?

Quoted 8 lines

Quoted 4 lines
Quoted 2 lines
Lee,
Can you please take the series if Rafael gives it ack?
Yes, no problem.
Well, since the code is going to reside mostly in drivers/acpi, I think I should be applying the patches and from your response it looks like you are fine with them. Is that correct?

I read that this set has dependencies on patches which are already in the MFD tree. If that's not the case please go ahead and apply them with my Ack for the MFD components.

Signature · 4 lines

Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Rafael J. Wysocki

2014-11-13 00:32 UTC #11 lore raw

Quoted 42 lines · Lee Jones

Quoted 40 lines · Rafael J. Wysocki
Quoted 38 lines · Lee Jones
Quoted 26 lines · Aaron Lu
Quoted 21 lines · Aaron Lu
On Intel Baytrail-T and Baytrail-T-CR platforms, there are two customized ACPI operation regions defined for the Power Management Integrated Circuit device, one is for power resource handling and one is for thermal: sensor temperature reporting, trip point setting, etc. There are different PMIC chips used on those platforms and though each has the same two operation regions and functionality, their implementation is different so every PMIC will need a driver. But since their functionality is similar, some common code is abstracted into the intel_soc_pmic_opregion.c.
The last version is posted here:
https://lkml.org/lkml/2014/9/8/801
Changes since then:
1 Move to drivers/acpi as discussed on the above thread;
2 Added support for XPower AXP288 PMIC operation region support; 3 Since operation region handler can not be removed(at the moment at least),
use bool for the two operation region driver configs instead of tristate; Another reason to do this is that, with Mika's MFD ACPI support patch, all those MFD cell devices created will have the same modalias as their parent's so it doesn't make much sense to compile these drivers into modules.
Quoted 3 lines
Patch 1 applies on top of Rafael's pm-next branch, and then patch 2 and patch 3 needs merge of Lee's mfd/ib-mfd-iio-3.19 branch where the PMIC driver XPower AXP288 and iio driver axp288_adc is located.
Quoted 8 lines
Since patch 2-3 are based on top of the mfd/ib-mfd-iio-3.19 branch, it would be easy to go through the mfd/ib-mfd-iio-3.19 branch.
Rafael,
Can I get your ACK for the three patches?
Lee,
Can you please take the series if Rafael gives it ack?
Yes, no problem.

Quoted 7 lines

Quoted 3 lines
Well, since the code is going to reside mostly in drivers/acpi, I think I should be applying the patches and from your response it looks like you are fine with them. Is that correct?
I read that this set has dependencies on patches which are already in the MFD tree. If that's not the case please go ahead and apply them with my Ack for the MFD components.

I thought you had a branch that I could pull into my tree and apply the patches on top of it. At least that was my understanding of the Aaron's message, so please let me know if that's not the case.

Rafael

Lee Jones

2014-11-13 10:41 UTC #12 lore raw

Quoted 47 lines · Rafael J. Wysocki

Quoted 46 lines · Lee Jones
Quoted 43 lines · Rafael J. Wysocki
Quoted 31 lines · Lee Jones
Quoted 29 lines · Aaron Lu
Quoted 21 lines · Aaron Lu
On Intel Baytrail-T and Baytrail-T-CR platforms, there are two customized ACPI operation regions defined for the Power Management Integrated Circuit device, one is for power resource handling and one is for thermal: sensor temperature reporting, trip point setting, etc. There are different PMIC chips used on those platforms and though each has the same two operation regions and functionality, their implementation is different so every PMIC will need a driver. But since their functionality is similar, some common code is abstracted into the intel_soc_pmic_opregion.c.
The last version is posted here:
https://lkml.org/lkml/2014/9/8/801
Changes since then:
1 Move to drivers/acpi as discussed on the above thread;
2 Added support for XPower AXP288 PMIC operation region support; 3 Since operation region handler can not be removed(at the moment at least),
use bool for the two operation region driver configs instead of tristate; Another reason to do this is that, with Mika's MFD ACPI support patch, all those MFD cell devices created will have the same modalias as their parent's so it doesn't make much sense to compile these drivers into modules.
Quoted 3 lines
Patch 1 applies on top of Rafael's pm-next branch, and then patch 2 and patch 3 needs merge of Lee's mfd/ib-mfd-iio-3.19 branch where the PMIC driver XPower AXP288 and iio driver axp288_adc is located.
Since patch 2-3 are based on top of the mfd/ib-mfd-iio-3.19 branch, it would be easy to go through the mfd/ib-mfd-iio-3.19 branch.
Quoted 7 lines
Quoted 5 lines
Rafael,
Can I get your ACK for the three patches?
Lee,
Can you please take the series if Rafael gives it ack?
Yes, no problem.
Well, since the code is going to reside mostly in drivers/acpi, I think I should be applying the patches and from your response it looks like you are fine with them. Is that correct?

Quoted 7 lines

Quoted 3 lines
I read that this set has dependencies on patches which are already in the MFD tree. If that's not the case please go ahead and apply them with my Ack for the MFD components.
I thought you had a branch that I could pull into my tree and apply the patches on top of it. At least that was my understanding of the Aaron's message, so please let me know if that's not the case.

That is absolutely the case. 'mfd/ib-mfd-iio-3.19' is good to go.

Signature · 4 lines

Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog