Skip to contentSkip to conversation

phy: phy-core: use the np present in of_phandle_args to get the PHY

PATCH New Kishon Vijay Abraham I 1 participant 1 message Oct 31, 2014 Generic PHY framework

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 phy: phy-core: use the np present in of_phandle_args to get the PHY

Instead of using the node pointer of the PHY provider and then scanning its child nodes to get a reference to the PHY, directly use the node pointer present in of_phandle_args to get a reference to the PHY.

---
I sent the wrong version of the patch before. Now I'm sending the proper one without errors and warnings.

 drivers/phy/phy-core.c |   10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)
drivers/phy/phy-core.c +1 -9
index ff5eec5..1606ce9 100644
@@ -414,21 +414,13 @@ struct phy *of_phy_simple_xlate(struct device *dev, struct of_phandle_args
 {
 	struct phy *phy;
 	struct class_dev_iter iter;
-	struct device_node *node = dev->of_node;
-	struct device_node *child;
 
 	class_dev_iter_init(&iter, phy_class, NULL, NULL);
 	while ((dev = class_dev_iter_next(&iter))) {
 		phy = to_phy(dev);
-		if (node != phy->dev.of_node) {
-			for_each_child_of_node(node, child) {
-				if (child == phy->dev.of_node)
-					goto phy_found;
-			}
+		if (args->np != phy->dev.of_node)
 			continue;
-		}
 
-phy_found:
 		class_dev_iter_exit(&iter);
 		return phy;
 	}
Signature · 1 line
1.7.9.5