Skip to contentSkip to conversation

regulator: Lower priorit of constraint logging

PATCH In review Mark Brown 2 participants 2 messages Oct 31, 2014 Voltage and current regulator framework

lore
Share & tools
lore

Mark Brown

author maintainer
#0 lore raw

PATCH 1/1 regulator: Lower priorit of constraint logging

Some systems have very large numbers of regulators so the constraint logging done at startup can end up being a very big part of the boot output which is both verobse and slows things down if the console is a serial console. Lower to dev_dbg() instead, we may want to provide a boot parameter to raise this in future but for now people can edit the source.

---
 drivers/regulator/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/regulator/core.c +1 -1
index 55a87a2722d8..bbf93c9caca3 100644
@@ -828,7 +828,7 @@ static void print_constraints(struct regulator_dev *rdev)
 	if (!count)
 		sprintf(buf, "no parameters");
 
-	rdev_info(rdev, "%s\n", buf);
+	rdev_dbg(rdev, "%s\n", buf);
 
 	if ((constraints->min_uV != constraints->max_uV) &&
 	    !(constraints->valid_ops_mask & REGULATOR_CHANGE_VOLTAGE))
Signature · 1 line
2.1.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 3 lines · Mark Brown

Some systems have very large numbers of regulators so the constraint logging done at startup can end up being a very big part of the boot output which is both verobse and slows things down if the console is

s/verobse/verbose/

Quoted 5 lines

a serial console. Lower to dev_dbg() instead, we may want to provide a boot parameter to raise this in future but for now people can edit the source.

You might want to run 's/priorit/priority/' on the subject.

Otherwise

Quoted 20 lines
---
 drivers/regulator/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/regulator/core.c +1 -1
index 55a87a2722d8..bbf93c9caca3 100644
@@ -828,7 +828,7 @@ static void print_constraints(struct regulator_dev *rdev)
 	if (!count)
 		sprintf(buf, "no parameters");
 
-	rdev_info(rdev, "%s\n", buf);
+	rdev_dbg(rdev, "%s\n", buf);
 
 	if ((constraints->min_uV != constraints->max_uV) &&
 	    !(constraints->valid_ops_mask & REGULATOR_CHANGE_VOLTAGE))
Signature · 1 line
2.1.1