Skip to contentSkip to conversation

imx:mx6sl_pins add pad settings for usb

PATCH New Peng Fan 3 participants 4 messages Nov 1, 2014 – Nov 3, 2014

Subsystems (2)
Arm (32-bit) Arm i.MX and Layerscape
lore
Share & tools
lore

Peng Fan

author
#0 lore raw

PATCH 1/2 imx:mx6sl_pins add pad settings for usb

Add pad settings for usb support.

This patch "imx:mx6slevk add usb support" missed to add pad definition.

Signed-off-by Peng Fan <[email protected]>
---
 arch/arm/include/asm/arch-mx6/mx6sl_pins.h | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm/include/asm/arch-mx6/mx6sl_pins.h +5 -0
index 045ccc4..17b4798 100644
@@ -34,5 +34,10 @@ enum {
 	MX6_PAD_FEC_REF_CLK__FEC_REF_OUT			= IOMUX_PAD(0x424, 0x134, 0x10, 0x000, 0, 0),
 	MX6_PAD_FEC_RX_ER__GPIO_4_19				= IOMUX_PAD(0x0428, 0x0138, 5, 0x0000, 0, 0),
 	MX6_PAD_FEC_TX_CLK__GPIO_4_21				= IOMUX_PAD(0x0434, 0x0144, 5, 0x0000, 0, 0),
+
+	MX6_PAD_EPDC_PWRCOM__ANATOP_USBOTG1_ID			= IOMUX_PAD(0x03D0, 0x00E0, 4, 0x05DC, 0, 0),
+
+	MX6_PAD_KEY_COL4__USB_USBOTG1_PWR			= IOMUX_PAD(0x0484, 0x017C, 6, 0x0000, 0, 0),
+	MX6_PAD_KEY_COL5__USB_USBOTG2_PWR			= IOMUX_PAD(0x0488, 0x0180, 6, 0x0000, 0, 0),
 };
 #endif	/* __ASM_ARCH_MX6_MX6SL_PINS_H__ */
Signature · 1 line
1.8.4.5
author
#1 lore raw

PATCH 2/2 arm:imx-common add function prototype for gpr set

This patch "arm:imx-common introduce a new function to set gpr" missed to add the function prototype.

Signed-off-by Peng Fan <[email protected]>
---
 arch/arm/include/asm/imx-common/iomux-v3.h | 3 +++
 1 file changed, 3 insertions(+)
arch/arm/include/asm/imx-common/iomux-v3.h +3 -0
index a8ca49c..23421b5 100644
@@ -182,6 +182,9 @@ typedef u64 iomux_v3_cfg_t;
 void imx_iomux_v3_setup_pad(iomux_v3_cfg_t pad);
 void imx_iomux_v3_setup_multiple_pads(iomux_v3_cfg_t const *pad_list,
 				     unsigned count);
+/* Set bits for general purpose registers */
+void mxc_iomux_set_gpr_register(int group, int start_bit, int num_bits,
+				int value);
 
 /* macros for declaring and using pinmux array */
 #if defined(CONFIG_MX6QDL)
Signature · 1 line
1.8.4.5
#2 lore raw

PATCH 2/2 arm:imx-common add function prototype for gpr set

Hi Peng,

Quoted 3 lines · Peng Fan

This patch "arm:imx-common introduce a new function to set gpr" missed to add the function prototype.

A fix of a previous patch makes sense when the patch was already merged. In that case, the fix should also have in the message the commit-id of the patch causing the issue.

Your patches are not yet merged: please send a new version of the patchset fixing the issues you have found.

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
reviewer
#3 lore raw

PATCH 1/2 imx:mx6sl_pins add pad settings for usb

In reply to Peng Fan
Quoted 4 lines · Peng Fan

Add pad settings for usb support.

This patch "imx:mx6slevk add usb support" missed to add pad definition.

Then please resend the patch with the pad definition.

Thanks