Skip to contentSkip to conversation

Bluetooth: Print error message for HCI_Hardware_Error event

PATCH Applied Marcel Holtmann 2 participants 2 messages Nov 2, 2014

Subsystems (2)
Bluetooth drivers Bluetooth
lore
Share & tools
lore

Marcel Holtmann

author maintainer
#0 lore raw

PATCH 1/1 Bluetooth: Print error message for HCI_Hardware_Error event

When the HCI_Hardware_Error event is send by the controller or injected by the driver, then at least print an error message.

Signed-off-by Marcel Holtmann <[email protected]>
---
 include/net/bluetooth/hci.h |  5 +++++
 net/bluetooth/hci_event.c   | 11 +++++++++++
 2 files changed, 16 insertions(+)
include/net/bluetooth/hci.h +5 -0
index 6e8f24967308..ecfa306e1375 100644
@@ -1463,6 +1463,11 @@ struct hci_ev_cmd_status {
 	__le16   opcode;
 } __packed;
 
+#define HCI_EV_HARDWARE_ERROR		0x10
+struct hci_ev_hardware_error {
+	__u8     code;
+} __packed;
+
 #define HCI_EV_ROLE_CHANGE		0x12
 struct hci_ev_role_change {
 	__u8     status;
net/bluetooth/hci_event.c +11 -0
index 3dd2550b4c07..2f02ff0ed781 100644
@@ -2925,6 +2925,13 @@ static void hci_cmd_status_evt(struct hci_dev *hdev, struct sk_buff *skb)
 	}
 }
 
+static void hci_hardware_error_evt(struct hci_dev *hdev, struct sk_buff *skb)
+{
+	struct hci_ev_hardware_error *ev = (void *) skb->data;
+
+	BT_ERR("%s hardware error 0x%2.2x", hdev->name, ev->code);
+}
+
 static void hci_role_change_evt(struct hci_dev *hdev, struct sk_buff *skb)
 {
 	struct hci_ev_role_change *ev = (void *) skb->data;

@@ -4746,6 +4753,10 @@ void hci_event_packet(struct hci_dev *hdev, struct sk_buff *skb)
 		hci_cmd_status_evt(hdev, skb);
 		break;
 
+	case HCI_EV_HARDWARE_ERROR:
+		hci_hardware_error_evt(hdev, skb);
+		break;
+
 	case HCI_EV_ROLE_CHANGE:
 		hci_role_change_evt(hdev, skb);
 		break;
Signature · 1 line
1.9.3
Applied
#1 lore raw

Hi Marcel,

Quoted 8 lines · Marcel Holtmann

When the HCI_Hardware_Error event is send by the controller or injected by the driver, then at least print an error message.

Signed-off-by Marcel Holtmann <[email protected]>
---
 include/net/bluetooth/hci.h |  5 +++++
 net/bluetooth/hci_event.c   | 11 +++++++++++
 2 files changed, 16 insertions(+)

Applied to bluetooth-next. Thanks.

Johan