Skip to contentSkip to conversation

v4l-utils/libdvbv5: restore deleted functions to keep API/ABI compatible

PATCH In review [email protected] 2 participants 3 messages Nov 2, 2014 Media (V4L/DVB)

lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 1/1 v4l-utils/libdvbv5: restore deleted functions to keep API/ABI compatible

From: Akihiro Tsukada <[email protected]>

dvb_new_freq_is_needed() was integrated to dvb_new_entry_is_needed(), and dvb_scan_add_entry() was added a new parameter.
As those changes broke API/ABI compatibility,
restore the original functions.

Signed-off-by Akihiro Tsukada <[email protected]>
---
 lib/include/libdvbv5/dvb-scan.h | 21 ++++++++++++-----
 lib/libdvbv5/dvb-scan.c         | 50 +++++++++++++++++++++++++++--------------
 2 files changed, 48 insertions(+), 23 deletions(-)
lib/include/libdvbv5/dvb-scan.h +15 -6
index aad6d01..c480426 100644
@@ -385,17 +385,26 @@ void dvb_add_scaned_transponders(struct dvb_v5_fe_parms *parms,
  */
 int dvb_estimate_freq_shift(struct dvb_v5_fe_parms *parms);
 
-int dvb_new_entry_is_needed(struct dvb_entry *entry,
-			   struct dvb_entry *last_entry,
-			   uint32_t freq, int shift,
-			   enum dvb_sat_polarization pol, uint32_t stream_id);
+int dvb_new_freq_is_needed(struct dvb_entry *entry, struct dvb_entry *last_entry,
+			   uint32_t freq, enum dvb_sat_polarization pol, int shift);
 
 struct dvb_entry *dvb_scan_add_entry(struct dvb_v5_fe_parms *parms,
 				     struct dvb_entry *first_entry,
 			             struct dvb_entry *entry,
 			             uint32_t freq, uint32_t shift,
-			             enum dvb_sat_polarization pol,
-			             uint32_t stream_id);
+			             enum dvb_sat_polarization pol);
+
+int dvb_new_entry_is_needed(struct dvb_entry *entry,
+			    struct dvb_entry *last_entry,
+			    uint32_t freq, int shift,
+			    enum dvb_sat_polarization pol, uint32_t stream_id);
+
+struct dvb_entry *dvb_scan_add_entry_ex(struct dvb_v5_fe_parms *parms,
+					struct dvb_entry *first_entry,
+					struct dvb_entry *entry,
+					uint32_t freq, uint32_t shift,
+					enum dvb_sat_polarization pol,
+					uint32_t stream_id);
 
 void dvb_update_transponders(struct dvb_v5_fe_parms *parms,
 			     struct dvb_v5_descriptors *dvb_scan_handler,
lib/libdvbv5/dvb-scan.c +33 -17

98 lines not on this page · raw message

Signature · 1 line
2.1.3
#1 lore raw
Quoted 6 lines · On 02/11/14 13:01, [email protected] wrote:

From: Akihiro Tsukada <[email protected]>

dvb_new_freq_is_needed() was integrated to dvb_new_entry_is_needed(), and dvb_scan_add_entry() was added a new parameter.
As those changes broke API/ABI compatibility,
restore the original functions.

I suppose you introduced the new functions to generalize the API. Can't you keep the new functions and make dvb_new_freq_is_needed a thin wrapper around them?

Thanks,
Gregor

author
#2 lore raw

Hi,

the patch is aimed to do just as you wrote,
i.e. add wrapper funcs with the original names.
sorry for my bad english.
--
akihiro