Skip to contentSkip to conversation

Bluetooth: Introduce HCI_QUIRK_STRICT_DUPLICATE_FILTER

PATCH In review Marcel Holtmann 2 participants 2 messages Nov 2, 2014 – Nov 3, 2014

Subsystems (2)
lore
Share & tools
lore

Marcel Holtmann

author maintainer
#0 lore raw

PATCH 1/2 Bluetooth: Introduce HCI_QUIRK_STRICT_DUPLICATE_FILTER

Some vendors decide to use a struct duplicate filter policy that only filters on Bluetooth device addresses. This means that when the RSSI changes, these devices are not reported again. During discovery it is useful to actually get the RSSI updates.

Since this is specific to each controller, add a new quirk setting that allows drivers to tell the core what kind of filtering policy the controller uses.

---
 include/net/bluetooth/hci.h | 9 +++++++++
 1 file changed, 9 insertions(+)
include/net/bluetooth/hci.h +9 -0
index ecfa306e1375..2e08f5a89463 100644
@@ -129,6 +129,15 @@ enum {
 	 * during the hdev->setup vendor callback.
 	 */
 	HCI_QUIRK_INVALID_BDADDR,
+
+	/* When this quirk is set, the duplicate filtering during
+	 * scanning is based on Bluetooth devices addresses. To allow
+	 * RSSI based updates, restart scanning if needed.
+	 *
+	 * This quirk can be set before hci_register_dev is called or
+	 * during the hdev->setup vendor callback.
+	 */
+	HCI_QUIRK_STRICT_DUPLICATE_FILTER,
 };
 
 /* HCI device flags */
Signature · 1 line
1.9.3
#1 lore raw

Hi Marcel,

Quoted 5 lines · Marcel Holtmann

Some vendors decide to use a struct duplicate filter policy that only filters on Bluetooth device addresses. This means that when the RSSI changes, these devices are not reported again. During discovery it is useful to actually get the RSSI updates.

Quoted 8 lines

Since this is specific to each controller, add a new quirk setting that allows drivers to tell the core what kind of filtering policy the controller uses.

---
 include/net/bluetooth/hci.h | 9 +++++++++
 1 file changed, 9 insertions(+)

Both patches in this set have been applied to bluetooth-next. Thanks.

Btw, I fixed the s/struct/strict/ typo in the message.

Johan