IBM Akebono: Remove select of IBM_EMAC_RGMII_WOL
Subsystems (2)
PATCH 1/1 IBM Akebono: Remove select of IBM_EMAC_RGMII_WOL
Commit 2a2c74b2efcb ("IBM Akebono: Add the Akebono platform") added a select of IBM_EMAC_RGMII_WOL. But that Kconfig symbol isn't (yet) part of the tree. So this select has been a nop since that commit was included in v3.16-rc1.
The code to add this symbol is not included in next-20141103. So let's remove this select. It can be readded when that symbol is actually added to the tree.
---
Untested. Done on top of next-20141103.
Third time's a charm? First raised in
https://lkml.org/lkml/2014/5/1/106 . Reminder sent in
https://lkml.org/lkml/2014/9/4/645 . I'm not aware of any news on this front, so this trivial patch seems reasonable now.
A patch to readd this select could be added - if people still care about it, that is - in the series that adds this symbol. A web search suggests Alistair takes care of that series, so Alistair gets a Cc: here.
arch/powerpc/platforms/44x/Kconfig | 1 - 1 file changed, 1 deletion(-)
arch/powerpc/platforms/44x/Kconfig +0 -1
@@ -214,7 +214,6 @@ config AKEBONO select ETHERNET select NET_VENDOR_IBM select IBM_EMAC_EMAC4 - select IBM_EMAC_RGMII_WOL select USB if USB_SUPPORT select USB_OHCI_HCD_PLATFORM if USB_OHCI_HCD select USB_EHCI_HCD_PLATFORM if USB_EHCI_HCD
Signature · 1 line
1.9.3
Hi Jiri,
Quoted 14 lines · Paul Bolle
Commit
2a2c74b2efcb("IBM Akebono: Add the Akebono platform") added a select ofIBM_EMAC_RGMII_WOL. But thatKconfigsymbol isn't (yet) part of the tree. So this select has been a nop since that commit was included in v3.16-rc1.The code to add this symbol is not included in next-20141103. So let's remove this select. It can be readded when that symbol is actually added to the tree.
Signed-off-by Paul Bolle <[email protected]>Cc Alistair Popple <[email protected]>---
Untested. Done on top of next-20141103.
Quoted 8 lines
Third time's a charm? First raised in
https://lkml.org/lkml/2014/5/1/106 . Reminder sent in
https://lkml.org/lkml/2014/9/4/645 . I'm not aware of any news on this front, so this trivial patch seems reasonable now.A patch to readd this select could be added - if people still care about it, that is - in the series that adds this symbol. A web search suggests Alistair takes care of that series, so Alistair gets a Cc: here.
This select of IBM_EMAC_RGMII_WOL still shows up in next-20141221 and v3.19-rc1. Did you have a chance to look at this patch?
Quoted 8 lines
arch/powerpc/platforms/44x/Kconfig | 1 - 1 file changed, 1 deletion(-)arch/powerpc/platforms/44x/Kconfig +0
-0
arch/powerpc/platforms/44x/Kconfig config AKEBONO · line 219
Quoted 7 lines
arch/powerpc/platforms/44x/Kconfig +0
-1@@ -214,7 +214,6 @@ config AKEBONO select ETHERNET select NET_VENDOR_IBM select IBM_EMAC_EMAC4 - select IBM_EMAC_RGMII_WOL select USB if USB_SUPPORT select USB_OHCI_HCD_PLATFORM if USB_OHCI_HCD select USB_EHCI_HCD_PLATFORM if USB_EHCI_HCD
Thanks,
Paul Bolle
Hi Paul,
These days I've been made maintainer of the PPC4XX tree so maybe adding Acked-
by: Alistair Popple <[email protected]> might help?
Jiri, if you would rather this go via the main PPC tree please let us know and we'll see if Michael Ellerman (added to CC) would be willing to take it (he has taken over most of the day to day maintenance of the PPC tree). Thanks!
Regards,
Alistair
Quoted 53 lines · On Mon, 22 Dec 2014 11:14:33 Paul Bolle wrote:
Hi Jiri,
Quoted 14 lines · Paul Bolle
Commit
2a2c74b2efcb("IBM Akebono: Add the Akebono platform") added a select ofIBM_EMAC_RGMII_WOL. But thatKconfigsymbol isn't (yet) part of the tree. So this select has been a nop since that commit was included in v3.16-rc1.The code to add this symbol is not included in next-20141103. So let's remove this select. It can be readded when that symbol is actually added to the tree.
Signed-off-by Paul Bolle <[email protected]>Cc Alistair Popple <[email protected]>---
Untested. Done on top of next-20141103.Quoted 8 lines
Third time's a charm? First raised in
https://lkml.org/lkml/2014/5/1/106 . Reminder sent in
https://lkml.org/lkml/2014/9/4/645 . I'm not aware of any news on this front, so this trivial patch seems reasonable now.A patch to readd this select could be added - if people still care about it, that is - in the series that adds this symbol. A web search suggests Alistair takes care of that series, so Alistair gets a Cc: here.
This select of
IBM_EMAC_RGMII_WOLstill shows up in next-20141221 and v3.19-rc1. Did you have a chance to look at this patch?Quoted 16 lines
arch/powerpc/platforms/44x/Kconfig | 1 - 1 file changed, 1 deletion(-)(quoted diff) +0
-0b/arch/powerpc/platforms/44x/Kconfig index
d2ac1c116454..5538e57c36c1100644arch/powerpc/platforms/44x/Kconfig +0
-1@@ -214,7 +214,6 @@ config AKEBONO select ETHERNET select NET_VENDOR_IBM select IBM_EMAC_EMAC4 - select IBM_EMAC_RGMII_WOLarch/powerpc/platforms/44x/Kconfig config AKEBONO · line 219
Quoted 3 lines
arch/powerpc/platforms/44x/Kconfig +0
-0select USB if USB_SUPPORT select USB_OHCI_HCD_PLATFORM if USB_OHCI_HCD select USB_EHCI_HCD_PLATFORM if USB_EHCI_HCDThanks,
Paul Bolle
Michael Ellerman
reviewerQuoted 8 lines · Alistair Popple
Hi Paul,
These days I've been made maintainer of the PPC4XX tree so maybe adding Acked-
by: Alistair Popple <[email protected]> might help?Jiri, if you would rather this go via the main PPC tree please let us know and we'll see if Michael Ellerman (added to CC) would be willing to take it (he has taken over most of the day to day maintenance of the PPC tree). Thanks!
It never went to linuxppc as far as I can see, though I am happy to take it. Although it is a trivial patch I'd still rather you CC'ed us on patches to arch/powerpc.
cheers