nfs: remove spurious WARN_ON_ONCE in write path
Subsystems (2)
PATCH 1/1 nfs: remove spurious WARN_ON_ONCE in write path
This WARN_ON_ONCE was supposed to catch reference counting bugs, but can trigger in inappropriate situations.
This was reproducible using NFSv2 on an architecture with 64K pages -- we verified that it was not a reference counting bug and the warning was safe to ignore.
Reported-by Will Deacon <[email protected]>
Tested-by Will Deacon <[email protected]>
Signed-off-by Weston Andros Adamson <[email protected]>
--- fs/nfs/write.c | 2 -- 1 file changed, 2 deletions(-)
fs/nfs/write.c +0 -2
@@ -715,8 +715,6 @@ static void nfs_inode_remove_request(struct nfs_page *req)if (test_and_clear_bit (PG_INODE_REF , &req->wb_flags))nfs_release_request (req); -else -WARN_ON_ONCE (1 ); } static void
Signature · 1 line
1.9.3 (Apple Git-50)
I’m not sure it we want to CC stable on this one - the single warning can simply be ignored.
-dros
Quoted 32 lines · Weston Andros Adamson
This
WARN_ON_ONCEwas supposed to catch reference counting bugs, but can trigger in inappropriate situations.This was reproducible using NFSv2 on an architecture with 64K pages -- we verified that it was not a reference counting bug and the warning was safe to ignore.
Reported-by Will Deacon <[email protected]>Tested-by Will Deacon <[email protected]>Signed-off-by Weston Andros Adamson <[email protected]>---
fs/nfs/write.c| 2 --1 file changed, 2 deletions(-)fs/nfs/write.c +0
-2@@ -715,8 +715,6 @@ static void nfs_inode_remove_request(struct nfs_page *req)if (test_and_clear_bit (PG_INODE_REF , &req->wb_flags))nfs_release_request (req); -else -WARN_ON_ONCE (1 ); }static void
Signature · 1 line
1.9.3 (Apple Git-50)