Skip to contentSkip to conversation

usb: dwc3: remove warning of disable scramble check

PATCH In review Huang Rui 2 participants 4 messages Nov 4, 2014 – Nov 5, 2014

Subsystems (2)
lore
Share & tools
lore

Huang Rui

author
#0 lore raw

PATCH 1/1 usb: dwc3: remove warning of disable scramble check

Some SoC's FPGA platform will need this quirk, but it will complain if running at true SoC platform. This is a normal case, so remove this warning.

---

Hi,

This patch is based on balbi/testing/next branch.

Thanks,
Rui

---
 drivers/usb/dwc3/core.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/usb/dwc3/core.c +0 -3
index 8ae42b8..3f1f0ab 100644
@@ -531,9 +531,6 @@ static int dwc3_core_init(struct dwc3 *dwc)
 		dwc->is_fpga = true;
 	}
 
-	WARN_ONCE(dwc->disable_scramble_quirk && !dwc->is_fpga,
-			"disable_scramble cannot be used on non-FPGA builds\n");
-
 	if (dwc->disable_scramble_quirk && dwc->is_fpga)
 		reg |= DWC3_GCTL_DISSCRAMBLE;
 	else
Signature · 1 line
1.9.1
#1 lore raw
Quoted 3 lines · Huang Rui

Some SoC's FPGA platform will need this quirk, but it will complain if running at true SoC platform. This is a normal case, so remove this warning.

nope, why do you need disable_scramble on actual SoC ? Without an erratum number I will not accept this, sorry.

Signature · 1 line
balbi
author
#2 lore raw
Quoted 8 lines · Felipe Balbi
Quoted 3 lines · Huang Rui

Some SoC's FPGA platform will need this quirk, but it will complain if running at true SoC platform. This is a normal case, so remove this warning.

nope, why do you need disable_scramble on actual SoC ? Without an erratum number I will not accept this, sorry.

Oh, that's my faulty. I can set disable_scramble_quirk=false after actual SoC, at that time, we can drop FPGA support. :)

Thanks,
Rui

#3 lore raw
Quoted 6 lines · Huang Rui
Quoted 5 lines · Felipe Balbi
Quoted 3 lines · Huang Rui

Some SoC's FPGA platform will need this quirk, but it will complain if running at true SoC platform. This is a normal case, so remove this warning.

Quoted 6 lines
Quoted 3 lines

nope, why do you need disable_scramble on actual SoC ? Without an erratum number I will not accept this, sorry.

Oh, that's my faulty. I can set disable_scramble_quirk=false after actual SoC, at that time, we can drop FPGA support. :)

correct, thank you

Signature · 1 line
balbi