bitbake.conf/base.bbclass: Drop PRINC support

PRINC is no longer needed since we have the PR service instead which people should be using. Drop the PRINC code.

This has been deprecated with a warning for a while so we can remove it now.

Signed-off-by Richard Purdie <[email protected]>

meta/classes/base.bbclass +0 -16

index e1b25ff..b2c4f08 100644
@@ -369,22 +369,6 @@ python () {
          else:
              appendVar('EXTRA_OECONF', extraconf)
 
-    # If PRINC is set, try and increase the PR value by the amount specified
-    # The PR server is now the preferred way to handle PR changes based on
-    # the checksum of the recipe (including bbappend).  The PRINC is now
-    # obsolete.  Return a warning to the user.
-    princ = d.getVar('PRINC', True)
-    if princ and princ != "0":
-        bb.warn("Use of PRINC %s was detected in the recipe %s (or one of its .bbappends)\nUse of PRINC is deprecated.  The PR server should be used to automatically increment the PR.  See: https://wiki.yoctoproject.org/wiki/PR_Service." % (princ, d.getVar("FILE", True)))
-        pr = d.getVar('PR', True)
-        pr_prefix = re.search("\D+",pr)
-        prval = re.search("\d+",pr)
-        if pr_prefix is None or prval is None:
-            bb.error("Unable to analyse format of PR variable: %s" % pr)
-        nval = int(prval.group(0)) + int(princ)
-        pr = pr_prefix.group(0) + str(nval) + pr[prval.end():]
-        d.setVar('PR', pr)
-
      pn = d.getVar('PN', True)
      license = d.getVar('LICENSE', True)
      if license == "INVALID":

meta/conf/bitbake.conf +0 -0

index 2a8a37f..8842d6b 100644

Won't this just silently make use of PRINC a no-op? What about the users that had their head in the sand for the last few months but still expect PRINC to have some effect (and maybe don't use PR server)? I would think escalating this to an error would make more sense (and follow other warnings that are now errors).

Quoted 5 lines · Gary Thomas

Won't this just silently make use of PRINC a no-op? What about the users that had their head in the sand for the last few months but still expect PRINC to have some effect (and maybe don't use PR server)? I would think escalating this to an error would make more sense (and follow other warnings that are now errors).

I agree with Gary, move this to ERROR now and drop in 1.9.

Quoted 8 lines · Otavio Salvador

Quoted 5 lines · Gary Thomas

Won't this just silently make use of PRINC a no-op? What about the users that had their head in the sand for the last few months but still expect PRINC to have some effect (and maybe don't use PR server)? I would think escalating this to an error would make more sense (and follow other warnings that are now errors).

I agree with Gary, move this to ERROR now and drop in 1.9.

Its been printing warnings since May 2013. I tried to merge this 6 months ago, I was told to wait another release, by you:

http://lists.openembedded.org/pipermail/openembedded-core/2014-March/090169.html

Now I need to keep the patch for another 6 months. This really is taking too long IMO. I may well get bored and just drop the patch (and forget any other ideas about trying to cleanup things).