drm/i915: move rps irq disable one level up
Subsystems (2)
PATCH 5/8 drm/i915: move rps irq disable one level up
We disable the RPS interrupts for all platforms at the same spot, so move it one level up in the callstack to simplify things.
No functional change.
Signed-off-by Imre Deak <[email protected]>
--- drivers/gpu/drm/i915/intel_pm.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)
drivers/gpu/drm/i915/intel_pm.c +3 -6
@@ -4532,8 +4532,6 @@ static void gen6_disable_rps(struct drm_device *dev)I915_WRITE (GEN6_RC_CONTROL ,0 );I915_WRITE (GEN6_RPNSWREQ ,1 <<31 ); - -gen6_disable_rps_interrupts (dev); }static void cherryview_disable_rps (struct drm_device *dev)
@@ -4541,8 +4539,6 @@ static void cherryview_disable_rps(struct drm_device *dev)struct drm_i915_private *dev_priv = dev->dev_private;I915_WRITE (GEN6_RC_CONTROL ,0 ); - -gen6_disable_rps_interrupts (dev); }static void valleyview_disable_rps (struct drm_device *dev)
@@ -4556,8 +4552,6 @@ static void valleyview_disable_rps(struct drm_device *dev)I915_WRITE (GEN6_RC_CONTROL ,0 );gen6_gt_force_wake_put (dev_priv,FORCEWAKE_ALL ); - -gen6_disable_rps_interrupts (dev); }static void intel_print_rc6_info (struct drm_device *dev,u32 mode)
@@ -6223,6 +6217,9 @@ void intel_disable_gt_powersave(struct drm_device *dev)valleyview_disable_rps (dev); elsegen6_disable_rps (dev ); + +gen6_disable_rps_interrupts (dev); + dev_priv->rps.enabled = false;mutex_unlock (&dev_priv->rps.hw_lock); }
Signature · 6 lines
1.8.4 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v2 5/8 drm/i915: move rps irq disable one level up
We disable the RPS interrupts for all platforms at the same spot, so move it one level up in the callstack to simplify things.
No functional change.
v2:
- rebase on the GEN9 patches where RPS isn't supported yet, so we don't need to disable RPS interrupts on it (Paulo)
Signed-off-by Imre Deak <[email protected]>
--- drivers/gpu/drm/i915/intel_pm.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-)
drivers/gpu/drm/i915/intel_pm.c +8 -6
@@ -4532,8 +4532,6 @@ static void gen6_disable_rps(struct drm_device *dev)I915_WRITE (GEN6_RC_CONTROL ,0 );I915_WRITE (GEN6_RPNSWREQ ,1 <<31 ); - -gen6_disable_rps_interrupts (dev); }static void cherryview_disable_rps (struct drm_device *dev)
@@ -4541,8 +4539,6 @@ static void cherryview_disable_rps(struct drm_device *dev)struct drm_i915_private *dev_priv = dev->dev_private;I915_WRITE (GEN6_RC_CONTROL ,0 ); - -gen6_disable_rps_interrupts (dev); }static void valleyview_disable_rps (struct drm_device *dev)
@@ -4556,8 +4552,6 @@ static void valleyview_disable_rps(struct drm_device *dev)I915_WRITE (GEN6_RC_CONTROL ,0 );gen6_gt_force_wake_put (dev_priv,FORCEWAKE_ALL ); - -gen6_disable_rps_interrupts (dev); }static void intel_print_rc6_info (struct drm_device *dev,u32 mode)
@@ -6223,6 +6217,14 @@ void intel_disable_gt_powersave(struct drm_device *dev)valleyview_disable_rps (dev); elsegen6_disable_rps (dev ); + +/* +* TODO: disable RPS interrupts on GEN9 too once RPS support +* is added for it. +*/ +if (INTEL_INFO (dev)->gen !=9 ) +gen6_disable_rps_interrupts (dev); + dev_priv->rps.enabled = false;mutex_unlock (&dev_priv->rps.hw_lock); }
Signature · 6 lines
1.8.4 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx