lib/flex_array: make build optional
Subsystems (5)
PATCH 1/1 lib/flex_array: make build optional
From: Aristeu Rozanski <[email protected]>
flex_array currently is built unconditionally:
text data bss dec hex filename 2294 1008 1568 4870 1306 lib/flex_array.o 2294 1008 1568 4870 1306 (TOTALS)
and it's used by procfs, selinux and openvswitch. This patch is useful for situations in which memory footprint is a concern and those features aren't used.
--- fs/proc/Kconfig | 1 + lib/Kconfig | 10 ++++++++++ lib/Makefile | 3 ++- net/openvswitch/Kconfig | 1 + security/selinux/Kconfig | 1 + 5 files changed, 15 insertions(+), 1 deletion(-)
fs/proc/Kconfig +1 -0
@@ -1,6 +1,7 @@ config PROC_FS bool "/proc file system support" if EXPERT default y + select FLEX_ARRAY help This is a virtual file system providing information about the status of the system. "Virtual" means that it doesn't take up any space on
lib/Kconfig +10 -0
@@ -432,6 +432,16 @@ config GLOB_SELFTEST module load) by a small amount, so you're welcome to play with it, but you probably don't need it. +config FLEX_ARRAY + bool "Flexible array" + default n + help + This option enables an implementation of flexible arrays which + allows creating arrays of fixed size elements with an arbritrary + size without requiring the single allocation of a contiguous area. + + See Documentation/flexible-arrays.txt + # # Netlink attribute parsing support is select'ed if needed #
lib/Makefile +2 -1
@@ -24,7 +24,7 @@ obj-y += lockref.o obj-y += bcd.o div64.o sort.o parser.o halfmd4.o debug_locks.o random32.o \ bust_spinlocks.o hexdump.o kasprintf.o bitmap.o scatterlist.o \ - gcd.o lcm.o list_sort.o uuid.o flex_array.o iovec.o clz_ctz.o \ + gcd.o lcm.o list_sort.o uuid.o iovec.o clz_ctz.o \ bsearch.o find_last_bit.o find_next_bit.o llist.o memweight.o kfifo.o \ percpu-refcount.o percpu_ida.o hash.o rhashtable.o obj-y += string_helpers.o
@@ -35,6 +35,7 @@ obj-$(CONFIG_TEST_LKM) += test_module.o obj-$(CONFIG_TEST_USER_COPY) += test_user_copy.o obj-$(CONFIG_TEST_BPF) += test_bpf.o obj-$(CONFIG_TEST_FIRMWARE) += test_firmware.o +obj-$(CONFIG_FLEX_ARRAY) += flex_array.o ifeq ($(CONFIG_DEBUG_KOBJECT),y) CFLAGS_kobject.o += -DDEBUG
net/openvswitch/Kconfig +1 -0
@@ -5,6 +5,7 @@ config OPENVSWITCH tristate "Open vSwitch" select LIBCRC32C + select FLEX_ARRAY ---help--- Open vSwitch is a multilayer Ethernet switch targeted at virtualized environments. In addition to supporting a variety of features
security/selinux/Kconfig +1 -0
@@ -2,6 +2,7 @@ config SECURITY_SELINUX bool "NSA SELinux Support" depends on SECURITY_NETWORK && AUDIT && NET && INET select NETWORK_SECMARK + select FLEX_ARRAY default n help This selects NSA Security-Enhanced Linux (SELinux).
Signature · 1 line
1.8.3.1
lib/Kconfig config GLOB_SELFTEST · line 443
Quoted 9 lines · Aristeu Rozanski
lib/Kconfig +9
-0+config FLEX_ARRAY + bool "Flexible array" + default n + help + This option enables an implementation of flexible arrays which + allows creating arrays of fixed size elements with an arbritrary + size without requiring the single allocation of a contiguous area. + + See Documentation/flexible-arrays.txt
Is there any reason to expose this to the user via Kconfig?
No sane person would even turn it on if they don't need it.
Quoted 13 lines · Dave Hansen
lib/Kconfig config GLOB_SELFTEST · line 443
Quoted 9 lines · Aristeu Rozanski
lib/Kconfig +9
-0+config FLEX_ARRAY + bool "Flexible array" + default n + help + This option enables an implementation of flexible arrays which + allows creating arrays of fixed size elements with an arbritrary + size without requiring the single allocation of a contiguous area. + + See Documentation/flexible-arrays.txtIs there any reason to expose this to the user via
Kconfig?
Quoted 1 line
No sane person would even turn it on if they don't need it.
IOW, I think you should just make it:
config FLEX_ARRAY
def_bool n
Quoted 14 lines · Dave Hansen
Quoted 13 lines · Dave Hansen
lib/Kconfig config GLOB_SELFTEST · line 443
Quoted 9 lines · Aristeu Rozanski
lib/Kconfig +9
-0+config FLEX_ARRAY + bool "Flexible array" + default n + help + This option enables an implementation of flexible arrays which + allows creating arrays of fixed size elements with an arbritrary + size without requiring the single allocation of a contiguous area. + + See Documentation/flexible-arrays.txtIs there any reason to expose this to the user via
Kconfig?
Quoted 6 lines
Quoted 1 line
No sane person would even turn it on if they don't need it.
IOW, I think you should just make it:
config
FLEX_ARRAY
def_booln
Joe Pershes complained on a similar patch on making it default to 'n'. Will rework the patches this way.
Signature · 1 line
Aristeu
Quoted 17 lines · Aristeu Rozanski
Quoted 16 lines · Dave Hansen
Quoted 14 lines · Dave Hansen
lib/Kconfig config GLOB_SELFTEST · line 443
Quoted 9 lines · Aristeu Rozanski
lib/Kconfig +9
-0+config FLEX_ARRAY + bool "Flexible array" + default n + help + This option enables an implementation of flexible arrays which + allows creating arrays of fixed size elements with an arbritrary + size without requiring the single allocation of a contiguous area. + + See Documentation/flexible-arrays.txtIs there any reason to expose this to the user via
Kconfig?No sane person would even turn it on if they don't need it.
Quoted 7 lines
Quoted 4 lines
IOW, I think you should just make it:
config
FLEX_ARRAY
def_boolnJoe Pershes complained on a similar patch on making it default to 'n'. Will rework the patches this way.
Already done.
- Josh Triplett
David Rientjes
Acked-byQuoted 4 lines · Josh Triplett
Already done.
Thanks Josh, and the "unflex array" patch title is great.
Quoted 11 lines · Aristeu Rozanski
From: Aristeu Rozanski <[email protected]>
flex_arraycurrently is built unconditionally:text data bss dec hex filename 2294 1008 1568 4870 1306 lib/flex_array.o 2294 1008 1568 4870 1306 (TOTALS)and it's used by procfs, selinux and openvswitch. This patch is useful for situations in which memory footprint is a concern and those features aren't used.
Quoted 12 lines
Cc Changli Gao <[email protected]>Cc Dave Hansen <[email protected]>Cc David Rientjes <[email protected]>Cc Eric Paris <[email protected]>Cc Hannes Frederic Sowa <[email protected]>Cc Jesse Gross <[email protected]>Cc Jonathan Corbet <[email protected]>Cc Paul Gortmaker <[email protected]>Cc Pravin Shelar <[email protected]>Cc Alexander Viro <[email protected]>Cc Josh Triplett <[email protected]>Signed-off-by Aristeu Rozanski <[email protected]>
I already have a patch for this sitting in the tiny tree (branch tiny/unflex-array) for the next merge window, and that patch hides the symbol from the user, just selecting it internally.
I've updated the tinification project list to mark that and several other projects as "done" or "in progress".
- Josh Triplett
Quoted 88 lines
fs/proc/Kconfig | 1 + lib/Kconfig | 10 ++++++++++ lib/Makefile | 3 ++- net/openvswitch/Kconfig | 1 + security/selinux/Kconfig | 1 + 5 files changed, 15 insertions(+), 1 deletion(-)fs/proc/Kconfig +1
-0@@ -1,6 +1,7 @@ config PROC_FS bool "/proc file system support" if EXPERT default y + select FLEX_ARRAY help This is a virtual file system providing information about the status of the system. "Virtual" means that it doesn't take up any space onlib/Kconfig +10
-0@@ -432,6 +432,16 @@ config GLOB_SELFTEST module load) by a small amount, so you're welcome to play with it, but you probably don't need it. +config FLEX_ARRAY + bool "Flexible array" + default n + help + This option enables an implementation of flexible arrays which + allows creating arrays of fixed size elements with an arbritrary + size without requiring the single allocation of a contiguous area. + + See Documentation/flexible-arrays.txt + # # Netlink attribute parsing support is select'ed if needed #lib/Makefile +2
-1@@ -24,7 +24,7 @@ obj-y += lockref.o obj-y += bcd.o div64.o sort.o parser.o halfmd4.o debug_locks.o random32.o \ bust_spinlocks.o hexdump.o kasprintf.o bitmap.o scatterlist.o \ - gcd.o lcm.o list_sort.o uuid.o flex_array.o iovec.o clz_ctz.o \ + gcd.o lcm.o list_sort.o uuid.o iovec.o clz_ctz.o \ bsearch.o find_last_bit.o find_next_bit.o llist.o memweight.o kfifo.o \ percpu-refcount.o percpu_ida.o hash.o rhashtable.o obj-y += string_helpers.o@@ -35,6 +35,7 @@ obj-$(CONFIG_TEST_LKM) += test_module.o obj-$(CONFIG_TEST_USER_COPY) += test_user_copy.o obj-$(CONFIG_TEST_BPF) += test_bpf.o obj-$(CONFIG_TEST_FIRMWARE) += test_firmware.o +obj-$(CONFIG_FLEX_ARRAY) += flex_array.o ifeq ($(CONFIG_DEBUG_KOBJECT),y) CFLAGS_kobject.o += -DDEBUGnet/openvswitch/Kconfig +1
-0@@ -5,6 +5,7 @@ config OPENVSWITCH tristate "Open vSwitch" select LIBCRC32C + select FLEX_ARRAY ---help--- Open vSwitch is a multilayer Ethernet switch targeted at virtualized environments. In addition to supporting a variety of featuressecurity/selinux/Kconfig +1
-0@@ -2,6 +2,7 @@ config SECURITY_SELINUX bool "NSA SELinux Support" depends on SECURITY_NETWORK && AUDIT && NET && INET select NETWORK_SECMARK + select FLEX_ARRAY default n help This selects NSA Security-Enhanced Linux (SELinux).Signature · 1 line
1.8.3.1